Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add fields as protected to allow for class extension #530

Merged

Conversation

AndreKurait
Copy link
Member

Description

Add fields as protected to allow for class extension

  • Category: Enhancement
  • Why these changes are required? To allow for other projects to extend from this one
  • What is the old behavior before changes and new behavior after changes? Classes did not allow visibility into member variables which would be needed in superclass extension.

Issues Resolved

N/A

Is this a backport? If so, please add backport PR # and/or commits #
N/A

Testing

Unit Tests

Check List

  • [ x] New functionality includes testing
    • [ x] All tests pass, including unit test, integration test and doctest
  • [ x] New functionality has been documented
  • [x ] Commits are signed per the DCO using --signoff

By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.
For more information on following Developer Certificate of Origin and signing off your commits, please check here.

Signed-off-by: Andre Kurait <akurait@amazon.com>
Signed-off-by: Andre Kurait <akurait@amazon.com>
@AndreKurait AndreKurait merged commit 61902aa into opensearch-project:main Feb 27, 2024
4 of 5 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants