Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Get with auth header fix #576

Merged

Conversation

AndreKurait
Copy link
Member

@AndreKurait AndreKurait commented Apr 11, 2024

Description

Get with auth header fix line endings fix

  • Category: Bug fix
  • Why these changes are required? Unit test correctness on existing repo clones
  • What is the old behavior before changes and new behavior after changes? Some users were not getting the file updated to crlf

Issues Resolved

N/A

Is this a backport? If so, please add backport PR # and/or commits #

Testing

Check List

  • [ x] New functionality includes testing
    • [ x] All tests pass, including unit test, integration test and doctest
  • New functionality has been documented
  • [ x] Commits are signed per the DCO using --signoff

By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.
For more information on following Developer Certificate of Origin and signing off your commits, please check here.

Signed-off-by: Andre Kurait <akurait@amazon.com>
Signed-off-by: Andre Kurait <akurait@amazon.com>
@AndreKurait AndreKurait marked this pull request as ready for review April 11, 2024 15:20
@AndreKurait AndreKurait merged commit 7befc09 into opensearch-project:main Apr 11, 2024
4 of 5 checks passed
@AndreKurait AndreKurait deleted the get_withAuthHeaderFix branch April 11, 2024 16:31
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants