Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Mend Fixes: MSK IAM Auth, Testcontainers, ApacheJMeter #577

Merged
merged 3 commits into from
Apr 15, 2024

Conversation

mikaylathompson
Copy link
Collaborator

Signed-off-by: Mikayla Thompson thomika@amazon.com

Description

[Describe what this change achieves]

  • Category: Maintenance
  • Why these changes are required? Fixing vulnerabilities identified by Mend
  • What is the old behavior before changes and new behavior after changes? hopefully exactly the same

Issues Resolved

Resolves #397
Resolves #482
Resolves #528

Testing

Unit tests & manual testing

Check List

  • New functionality includes testing
    • All tests pass, including unit test, integration test and doctest
  • New functionality has been documented
  • Commits are signed per the DCO using --signoff

By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.
For more information on following Developer Certificate of Origin and signing off your commits, please check here.

Signed-off-by: Mikayla Thompson <thomika@amazon.com>
Signed-off-by: Mikayla Thompson <thomika@amazon.com>
Signed-off-by: Mikayla Thompson <thomika@amazon.com>
Copy link

codecov bot commented Apr 11, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 75.97%. Comparing base (15ad146) to head (bba99fa).
Report is 37 commits behind head on main.

Additional details and impacted files
@@             Coverage Diff              @@
##               main     #577      +/-   ##
============================================
- Coverage     76.43%   75.97%   -0.47%     
- Complexity     1408     1497      +89     
============================================
  Files           155      162       +7     
  Lines          6044     6339     +295     
  Branches        543      563      +20     
============================================
+ Hits           4620     4816     +196     
- Misses         1052     1149      +97     
- Partials        372      374       +2     
Flag Coverage Δ
unittests 75.97% <ø> (-0.47%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Copy link
Member

@peternied peternied left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

While the mend check didn't seem to notice these fixes, it did find a fix for CVE-2024-21634 in ion-java-1.0.2.jar 🤷

Looks good to merge to me.

@mikaylathompson mikaylathompson merged commit 911c9fa into opensearch-project:main Apr 15, 2024
6 of 7 checks passed
@mikaylathompson mikaylathompson deleted the mend-fixes branch April 15, 2024 23:09
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
3 participants