Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove parallel test execution and mark long tests #588

Merged
merged 1 commit into from
Apr 19, 2024

Conversation

AndreKurait
Copy link
Member

Description

We're seeing some intermittent test failures during parallel execution due. While we would like to make the tests robust to these timing differences, for the maturity of the project and for the meantime, seeking to disable parallel test execution.

Also, marked some long running tests (> 2s per run) as longTest

  • Category: Enhancement
  • Why these changes are required? Test Reliablity
  • What is the old behavior before changes and new behavior after changes? Tests would intermittently fail, now tests take ~30 seconds and run reliably

Issues Resolved

MIGRATIONS-1666

Is this a backport? If so, please add backport PR # and/or commits #

Testing

Ran on M1 Pro macbook, got build and test execution down to 29s https://gradle.com/s/6sybg3hsa6lry

Check List

  • [x ] New functionality includes testing
    • [x ] All tests pass, including unit test, integration test and doctest
  • New functionality has been documented
  • [ x] Commits are signed per the DCO using --signoff

By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.
For more information on following Developer Certificate of Origin and signing off your commits, please check here.

Copy link

codecov bot commented Apr 16, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 75.96%. Comparing base (2b853a9) to head (90b91f2).
Report is 1 commits behind head on main.

Additional details and impacted files
@@             Coverage Diff              @@
##               main     #588      +/-   ##
============================================
+ Coverage     75.74%   75.96%   +0.22%     
+ Complexity     1495     1492       -3     
============================================
  Files           162      162              
  Lines          6348     6348              
  Branches        572      572              
============================================
+ Hits           4808     4822      +14     
+ Misses         1160     1147      -13     
+ Partials        380      379       -1     
Flag Coverage Δ
unittests 75.96% <ø> (+0.22%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@zelinh zelinh deleted the branch opensearch-project:main April 16, 2024 20:17
@zelinh zelinh closed this Apr 16, 2024
@AndreKurait AndreKurait reopened this Apr 17, 2024
Signed-off-by: Andre Kurait <akurait@amazon.com>
Copy link
Collaborator

@gregschohn gregschohn left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm. thx!

@AndreKurait AndreKurait merged commit b9eec6b into opensearch-project:main Apr 19, 2024
7 checks passed
@AndreKurait AndreKurait deleted the FixFlakyTests branch April 19, 2024 16:41
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants