Updated RFS Docker Compose to handle AWS Creds; fix S3Repo bug #597
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Chris Helma <chelma+github@amazon.com>
Signed-off-by: Chris Helma <chelma+github@amazon.com>
chelma
requested review from
AndreKurait,
gregschohn,
kartg,
lewijacn,
mikaylathompson,
okhasawn and
sumobrian
as code owners
mikaylathompson
approved these changes
Apr 22, 2024
| @@ -8,6 +8,9 @@ services: | |||
| environment: | |||
| - discovery.type=single-node | |||
| - path.repo=/snapshots | |||
| - AWS_ACCESS_KEY_ID=${access_key} | |||
There was a problem hiding this comment.
is there a reason you're not using the typical env var naming conventions locally? (e.g. not - AWS_ACCESS_KEY_ID=${AWS_ACCESS_KEY_ID} and the corresponding change in the documentation). Not a big deal, but I'm not sure I understand the reason.
There was a problem hiding this comment.
It's so that you can use a different set of credentials on the host machine if you want to. I was having trouble with my host machine (mac laptop) picking up and using the creds intended for the RFS Containers, which was pretty annoying because that meant that when I ran the AWS CLI to get renewed creds for the Containers using STS, the CLI would use the expired credential set I was trying to renew! 🙃
AndreKurait
pushed a commit
to AndreKurait/opensearch-migrations
that referenced
this pull request
Apr 23, 2024
…earch-project#597) * Updated RFS README for using AWS Creds in Docker Compose Signed-off-by: Chris Helma <chelma+github@amazon.com> * Fixed bug in S3Repo handling; added unit tests Signed-off-by: Chris Helma <chelma+github@amazon.com> --------- Signed-off-by: Chris Helma <chelma+github@amazon.com> Signed-off-by: Andre Kurait <akurait@amazon.com>
mikaylathompson
pushed a commit
to mikaylathompson/opensearch-migrations
that referenced
this pull request
Apr 23, 2024
…earch-project#597) * Updated RFS README for using AWS Creds in Docker Compose Signed-off-by: Chris Helma <chelma+github@amazon.com> * Fixed bug in S3Repo handling; added unit tests Signed-off-by: Chris Helma <chelma+github@amazon.com> --------- Signed-off-by: Chris Helma <chelma+github@amazon.com>
mikaylathompson
pushed a commit
to mikaylathompson/opensearch-migrations
that referenced
this pull request
Apr 23, 2024
…earch-project#597) * Updated RFS README for using AWS Creds in Docker Compose Signed-off-by: Chris Helma <chelma+github@amazon.com> * Fixed bug in S3Repo handling; added unit tests Signed-off-by: Chris Helma <chelma+github@amazon.com> --------- Signed-off-by: Chris Helma <chelma+github@amazon.com> Signed-off-by: Mikayla Thompson <thomika@amazon.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Issues Resolved
Done while working on https://opensearch.atlassian.net/browse/MIGRATIONS-1600
Testing
./gradlew tests)Check List
By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.
For more information on following Developer Certificate of Origin and signing off your commits, please check here.