Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Downgrade aws-msk-iam-auth to latest good version (2.0.3) #598

Merged

Conversation

mikaylathompson
Copy link
Collaborator

Description

The latest version of aws-msk-iam-auth has a bug that prevents it from correctly acquiring IAM credentials on an EC2 instance. This bug is documented in their GH (aws/aws-msk-iam-auth#168) and a PR has been merged, but no release with this fix has been cut.

We are downgrading our version of this library to the latest without this bug (2.0.3), which has been tested and verified on one of our EC2 instances.

Issues Resolved

n/a (but it's breaking the build on main)

Testing

Manual testing

Check List

  • New functionality includes testing
    • All tests pass, including unit test, integration test and doctest
  • New functionality has been documented
  • Commits are signed per the DCO using --signoff

By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.
For more information on following Developer Certificate of Origin and signing off your commits, please check here.

This reverts commit 545af03.

Signed-off-by: Mikayla Thompson <thomika@amazon.com>
Signed-off-by: Mikayla Thompson <thomika@amazon.com>
Copy link
Collaborator

@lewijacn lewijacn left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM thanks!

@mikaylathompson mikaylathompson merged commit 328dbb7 into opensearch-project:main Apr 22, 2024
5 checks passed
@mikaylathompson mikaylathompson deleted the debugging-msk-creds branch April 22, 2024 19:10
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants