-
Notifications
You must be signed in to change notification settings - Fork 27
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Enhance logging with Async and high performance appenders #602
Changes from 6 commits
d98fe23
a641dff
0a18fbb
718aa6a
5d5d8c7
f5eac21
643e8e9
File filter
Filter by extension
Conversations
Jump to
Diff view
Diff view
There are no files selected for viewing
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -0,0 +1,2 @@ | ||
Log4jContextSelector=org.apache.logging.log4j.core.async.AsyncLoggerContextSelector | ||
AsyncLogger.WaitStrategy=Yield |
Original file line number | Diff line number | Diff line change |
---|---|---|
|
@@ -6,7 +6,9 @@ appender.console.type = Console | |
appender.console.name = STDERR | ||
appender.console.target = SYSTEM_ERR | ||
appender.console.layout.type = PatternLayout | ||
appender.console.layout.pattern = [%-5level] %d{yyyy-MM-dd HH:mm:ss,SSS}{UTC} [%t] %c{1} - %msg%equals{ ctx=%mdc}{ ctx=\{\}}{}%n | ||
appender.console.layout.pattern = [%-5level] %d{DEFAULT_MICROS}{UTC} [%t] %c{1} - %msg%equals{ ctx=%mdc}{ ctx=\{\}}{}%n | ||
appender.console.direct = true | ||
AndreKurait marked this conversation as resolved.
Show resolved
Hide resolved
|
||
appender.console.includeLocation = true | ||
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. Can you elaborate on including this/why it's important? https://logging.apache.org/log4j/2.x/manual/async.html#location-location-location
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. Removed, had originally included it due to the |
||
|
||
rootLogger.level = info | ||
rootLogger.appenderRefs = stderr | ||
|
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -0,0 +1,2 @@ | ||
Log4jContextSelector=org.apache.logging.log4j.core.async.AsyncLoggerContextSelector | ||
AsyncLogger.WaitStrategy=Yield | ||
AndreKurait marked this conversation as resolved.
Show resolved
Hide resolved
|
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -1,4 +1,4 @@ | ||
status = error | ||
status = error | ||
|
||
# Root logger options | ||
rootLogger.level = info | ||
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Mostly a side note -- it's very weird that Mend decided it didn't need to run on this push (see here). You're adding and updating dependencies!
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Does it ever run on a PR, or only once it's merged?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Yeah, usually I can see the results when I modify
build.gradle
files before merging. But it's currently doing this same thing to me on the werkzeug PR.But definitely not a blocker for this!