-
Notifications
You must be signed in to change notification settings - Fork 27
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Centralized all dependencies in TrafficCapture #605
Centralized all dependencies in TrafficCapture #605
Conversation
Signed-off-by: Peter Nied <petern@amazon.com>
Signed-off-by: Peter Nied <petern@amazon.com>
Signed-off-by: Peter Nied <petern@amazon.com>
Signed-off-by: Peter Nied <petern@amazon.com>
Signed-off-by: Peter Nied <petern@amazon.com>
Signed-off-by: Peter Nied <petern@amazon.com>
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #605 +/- ##
============================================
- Coverage 75.84% 75.60% -0.25%
+ Complexity 1545 1541 -4
============================================
Files 168 168
Lines 6446 6455 +9
Branches 574 575 +1
============================================
- Hits 4889 4880 -9
- Misses 1177 1192 +15
- Partials 380 383 +3
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. |
Signed-off-by: Peter Nied <petern@amazon.com>
Signed-off-by: Peter Nied <petern@amazon.com>
Signed-off-by: Peter Nied <petern@amazon.com>
Signed-off-by: Peter Nied <petern@amazon.com>
Signed-off-by: Peter Nied <petern@amazon.com>
… dependencies Signed-off-by: Peter Nied <petern@amazon.com>
Signed-off-by: Peter Nied <peternied@hotmail.com>
This reverts commit 8c2bdae. Signed-off-by: Peter Nied <peternied@hotmail.com>
Signed-off-by: Peter Nied <peternied@hotmail.com>
Signed-off-by: Peter Nied <peternied@hotmail.com>
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This is really cool. Thanks for putting this together.
I have a couple questions so that I can better understand how it works.
Thanks!
Signed-off-by: Peter Nied <petern@amazon.com>
Signed-off-by: Peter Nied <petern@amazon.com>
Signed-off-by: Peter Nied <petern@amazon.com>
I'd be interested in a gradle task to be able to make a diff between changes (at least manual for now). I was playing around with the following but not sure if it's correct.
|
Signed-off-by: Peter Nied <peternied@hotmail.com>
Signed-off-by: Peter Nied <peternied@hotmail.com>
Signed-off-by: Peter Nied <peternied@hotmail.com>
Signed-off-by: Peter Nied <peternied@hotmail.com>
Signed-off-by: Peter Nied <peternied@hotmail.com>
Signed-off-by: Peter Nied <peternied@hotmail.com>
@AndreKurait I'm not going to invest in doing much more than Comparison on TrafficReplayer classpathDifferences are largely snapping to new versions, the removed fastdoubleparser was dropped by jackson-databine, and netty added a new architecture for riscv64.
|
I’m good with that approach. Thanks! |
Description
Create versions property for all shared dependencies. This should make version bumps easier across all the sub projects along.
Testing
./gradlew assemble
Issues
Check List
New functionality includes testingAll tests pass, including unit test, integration test and doctestNew functionality has been documentedBy submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.
For more information on following Developer Certificate of Origin and signing off your commits, please check here.