Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Werkzeug Fix Attempts #606

Conversation

mikaylathompson
Copy link
Collaborator

Description

[Describe what this change achieves]

  • Category (Enhancement, New feature, Bug fix, Test fix, Refactoring, Maintenance, Documentation)
  • Why these changes are required?
  • What is the old behavior before changes and new behavior after changes?

Issues Resolved

[List any issues this PR will resolve]

Is this a backport? If so, please add backport PR # and/or commits #

Testing

[Please provide details of testing done: unit testing, integration testing and manual testing]

Check List

  • New functionality includes testing
    • All tests pass, including unit test, integration test and doctest
  • New functionality has been documented
  • Commits are signed per the DCO using --signoff

By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.
For more information on following Developer Certificate of Origin and signing off your commits, please check here.

Signed-off-by: Mikayla Thompson <thomika@amazon.com>
Signed-off-by: Mikayla Thompson <thomika@amazon.com>
Copy link

codecov bot commented Apr 23, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 75.94%. Comparing base (384401e) to head (b37733a).
Report is 12 commits behind head on main.

Additional details and impacted files
@@             Coverage Diff              @@
##               main     #606      +/-   ##
============================================
+ Coverage     75.91%   75.94%   +0.03%     
- Complexity     1491     1493       +2     
============================================
  Files           162      162              
  Lines          6348     6348              
  Branches        572      572              
============================================
+ Hits           4819     4821       +2     
+ Misses         1152     1149       -3     
- Partials        377      378       +1     
Flag Coverage Δ
unittests 75.94% <ø> (+0.03%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@AndreKurait AndreKurait marked this pull request as ready for review May 7, 2024 19:52
@mikaylathompson mikaylathompson merged commit 516ba38 into opensearch-project:main May 7, 2024
7 checks passed
@mikaylathompson mikaylathompson deleted the attempt-werkzeug-mend-fix branch May 7, 2024 19:54
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants