Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Favor ByteBuf Duplicates, NettyJsonContentAuthSigner and StreamChannelConnectionCaptureSerializer Refactoring #615

Merged
merged 18 commits into from
May 3, 2024
Merged

Favor ByteBuf Duplicates, NettyJsonContentAuthSigner and StreamChannelConnectionCaptureSerializer Refactoring #615

merged 18 commits into from
May 3, 2024

Commits on May 2, 2024

  1. Prefer duplicate to slices 

    Signed-off-by: Andre Kurait <akurait@amazon.com>
    @AndreKurait
    AndreKurait committed May 2, 2024
    Configuration menu
    Copy the full SHA
    66f9e58 View commit details
    Browse the repository at this point in the history

  2. Simplify ParsedHttpMessagesAsDicts Base64 Encoding 

    Signed-off-by: Andre Kurait <akurait@amazon.com>
    @AndreKurait
    AndreKurait committed May 2, 2024
    Configuration menu
    Copy the full SHA
    3d28553 View commit details
    Browse the repository at this point in the history

  3. Fix release in NettyJsonContentCompressor 

    Signed-off-by: Andre Kurait <akurait@amazon.com>
    @AndreKurait
    AndreKurait committed May 2, 2024
    Configuration menu
    Copy the full SHA
    4bf9a0f View commit details
    Browse the repository at this point in the history

  4. Refactor NettyJsonContentAuthSigner for safer operation 

    Signed-off-by: Andre Kurait <akurait@amazon.com>
    @AndreKurait
    AndreKurait committed May 2, 2024
    Configuration menu
    Copy the full SHA
    e2d7aaf View commit details
    Browse the repository at this point in the history

  5. Remove reader index modification in HttpJsonTransformingConsumer 

    Signed-off-by: Andre Kurait <akurait@amazon.com>
    @AndreKurait
    AndreKurait committed May 2, 2024
    Configuration menu
    Copy the full SHA
    05271b2 View commit details
    Browse the repository at this point in the history

  6. Add duplicate before each byteBuf read 

    Signed-off-by: Andre Kurait <akurait@amazon.com>
    @AndreKurait
    AndreKurait committed May 2, 2024
    Configuration menu
    Copy the full SHA
    daf2b23 View commit details
    Browse the repository at this point in the history

  7. Add StreamChannelConnectionCaptureSerializerTest for buffer with fewe… 

    …r bytes written than capacity

Signed-off-by: Andre Kurait <akurait@amazon.com>
    @AndreKurait
    AndreKurait committed May 2, 2024
    Configuration menu
    Copy the full SHA
    7943c26 View commit details
    Browse the repository at this point in the history

  8. Fix StreamChannelConnectionCaptureSerializer behavior for nioBuffers … 

    …that have larger capacity than limit

Signed-off-by: Andre Kurait <akurait@amazon.com>
    @AndreKurait
    AndreKurait committed May 2, 2024
    Configuration menu
    Copy the full SHA
    5afd1a0 View commit details
    Browse the repository at this point in the history

  9. Log when NettyJsonContentAuthSigner fails to sign message 

    Signed-off-by: Andre Kurait <akurait@amazon.com>
    @AndreKurait
    AndreKurait committed May 2, 2024
    Configuration menu
    Copy the full SHA
    bcc1c97 View commit details
    Browse the repository at this point in the history

  10. Fill headers before body in ParsedHttpMessagesAsDicts 

    Signed-off-by: Andre Kurait <akurait@amazon.com>
    @AndreKurait
    AndreKurait committed May 2, 2024
    Configuration menu
    Copy the full SHA
    578cb0b View commit details
    Browse the repository at this point in the history

  11. Add StreamChannelConnectionCaptureSerializerTests around segmentedObs… 

    …ervations at capacity of stream

Signed-off-by: Andre Kurait <akurait@amazon.com>
    @AndreKurait
    AndreKurait committed May 2, 2024
    Configuration menu
    Copy the full SHA
    171dea0 View commit details
    Browse the repository at this point in the history

  12. Fix StreamChannelConnectionCaptureSerializer edge case around segment… 

    …edObservations at capacity of stream

Signed-off-by: Andre Kurait <akurait@amazon.com>
    @AndreKurait
    AndreKurait committed May 2, 2024
    Configuration menu
    Copy the full SHA
    9f78caf View commit details
    Browse the repository at this point in the history

  13. Fix ResultsToLogsConsumerTest with body at end of tuple output 

    Signed-off-by: Andre Kurait <akurait@amazon.com>
    @AndreKurait
    AndreKurait committed May 2, 2024
    Configuration menu
    Copy the full SHA
    8bc47ca View commit details
    Browse the repository at this point in the history

  14. Add LeakDetection to StreamChannelConnectionCaptureSerializerTest 

    Signed-off-by: Andre Kurait <akurait@amazon.com>
    @AndreKurait
    AndreKurait committed May 2, 2024
    Configuration menu
    Copy the full SHA
    7fbd7a5 View commit details
    Browse the repository at this point in the history

  15. Remove memory leaks in ConditionallyReliableLoggingHttpHandlerTest 

    Signed-off-by: Andre Kurait <akurait@amazon.com>
    @AndreKurait
    AndreKurait committed May 2, 2024
    Configuration menu
    Copy the full SHA
    1b66165 View commit details
    Browse the repository at this point in the history

Commits on May 3, 2024

  1. Add PessimisticallyCalculateMaxWritableSpace 

    Signed-off-by: Andre Kurait <akurait@amazon.com>
    @AndreKurait
    AndreKurait committed May 3, 2024
    Configuration menu
    Copy the full SHA
    0325b24 View commit details
    Browse the repository at this point in the history

  2. Address PR comments 

    Signed-off-by: Andre Kurait <akurait@amazon.com>
    @AndreKurait
    AndreKurait committed May 3, 2024
    Configuration menu
    Copy the full SHA
    61dbc8f View commit details
    Browse the repository at this point in the history

  3. Simplify TestUtils getStringFromContent 

    Signed-off-by: Andre Kurait <akurait@amazon.com>
    @AndreKurait
    AndreKurait committed May 3, 2024
    Configuration menu
    Copy the full SHA
    7b270fa View commit details
    Browse the repository at this point in the history