Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Increase default MAX_PAYLOAD_BYTES_TO_PRINT to 100MiB #622

Merged

Conversation

AndreKurait
Copy link
Member

@AndreKurait AndreKurait commented Apr 30, 2024

Description

Increases MAX_PAYLOAD_BYTES_TO_PRINT to 100 MiB to keep in line with AWS Opensearch Support

  • Category: Bug Fix
  • Why these changes are required? The default configuration should work with aws opensearch
  • What is the old behavior before changes and new behavior after changes? Large requests over 1MB would not be included in the tuple output. Now by default all requests that are supported within AWS Managed Opensearch will work.

Issues Resolved

MIGRATIONS-1715

Is this a backport? If so, please add backport PR # and/or commits #

Testing

Unit Testing

Check List

  • [x ] New functionality includes testing
    • [ x] All tests pass, including unit test, integration test and doctest
  • [x ] New functionality has been documented
  • [x ] Commits are signed per the DCO using --signoff

By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.
For more information on following Developer Certificate of Origin and signing off your commits, please check here.

Signed-off-by: Andre Kurait <akurait@amazon.com>
Copy link
Collaborator

@gregschohn gregschohn left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is sloppy, but I'm fine doing this since we're already tracking the bytes anyway. I'm also OK since we'll likely soon be discarding this code to stream it w/out the aggregator anyway.

@AndreKurait AndreKurait merged commit 3e6b6c5 into opensearch-project:main May 2, 2024
5 checks passed
@AndreKurait AndreKurait deleted the IncreaseMaxRequestSize branch May 2, 2024 21:15
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants