Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Mend - fix werkzeug issue Part1 #638

Closed
wants to merge 1 commit into from
Closed

Conversation

AndreKurait
Copy link
Member

@AndreKurait AndreKurait commented May 7, 2024

Description

We are currently getting a mend issue for werkzeug even though we’ve updated it.
Experimentation showed that deleting the requirements.txt refreshes the mend check.

This should be merged, and after mend runs, #639 should be merged.

  • Category: Maintenance
  • Why these changes are required? Refresh Mend check
  • What is the old behavior before changes and new behavior after changes? Mend shows up failing for werkzeug

Issues Resolved

MIGRATIONS-1728

Is this a backport? If so, please add backport PR # and/or commits #

Testing

Branch testing for mend fix, commit will be reverted

Check List

  • [ x] New functionality includes testing
    • [x ] All tests pass, including unit test, integration test and doctest
  • [x ] New functionality has been documented
  • [x ] Commits are signed per the DCO using --signoff

By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.
For more information on following Developer Certificate of Origin and signing off your commits, please check here.

Signed-off-by: Andre Kurait <akurait@amazon.com>
@AndreKurait AndreKurait changed the title Update dev-requirements.txt Mend - fix werkzeug issue Part1 May 8, 2024
@AndreKurait AndreKurait marked this pull request as ready for review May 8, 2024 16:43
@peternied
Copy link
Member

@AndreKurait Can you see about running mend on your fork to confirm that its working rather than trial an erroring in the shared repo? Just occurred to me, did you manage to reachout to the maintainers of opensearch-py about issues like this?

Finally, if we don't have any better ideas about how to properly trigger and test the mend workflow, what would you think about filing a ticket with support?

@AndreKurait
Copy link
Member Author

AndreKurait commented May 10, 2024

@AndreKurait Can you see about running mend on your fork to confirm that its working rather than trial an erroring in the shared repo? Just occurred to me, did you manage to reachout to the maintainers of opensearch-py about issues like this?

Finally, if we don't have any better ideas about how to properly trigger and test the mend workflow, what would you think about filing a ticket with support?

I tested on a branch on this repo. I tried changing settings such as incremental scan or other whitesource settings. The only change that fixed the issue was deleting both dev-requirements.txt and requirements.txt

I just sent a support email to mend to see if they can fix the issue without going through this process

@AndreKurait AndreKurait deleted the AndreKurait-patch-1 branch May 15, 2024 15:22
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants