Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[DRAFT] Add Dockerfile for local jenkins build #641

Closed
wants to merge 2 commits into from

Conversation

sumobrian
Copy link
Collaborator

Description

[Describe what this change achieves]

  • Category (Enhancement, New feature, Bug fix, Test fix, Refactoring, Maintenance, Documentation)
  • Why these changes are required?
  • What is the old behavior before changes and new behavior after changes?

Issues Resolved

[List any issues this PR will resolve]

Is this a backport? If so, please add backport PR # and/or commits #

Testing

[Please provide details of testing done: unit testing, integration testing and manual testing]

Check List

  • New functionality includes testing
    • All tests pass, including unit test, integration test and doctest
  • New functionality has been documented
  • Commits are signed per the DCO using --signoff

By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.
For more information on following Developer Certificate of Origin and signing off your commits, please check here.

Signed-off-by: Brian Presley <bjpres@amazon.com>
@sumobrian sumobrian added the draft Indicate that a PR is in draft mode and not ready to merged label May 9, 2024
@sumobrian sumobrian changed the title Add Dockerfile for local jenkins build [DRAFT] Add Dockerfile for local jenkins build May 9, 2024
Copy link

codecov bot commented May 9, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 75.73%. Comparing base (7b270fa) to head (35be449).
Report is 13 commits behind head on main.

Additional details and impacted files
@@             Coverage Diff              @@
##               main     #641      +/-   ##
============================================
- Coverage     75.79%   75.73%   -0.07%     
+ Complexity     1543     1539       -4     
============================================
  Files           168      168              
  Lines          6437     6437              
  Branches        575      575              
============================================
- Hits           4879     4875       -4     
  Misses         1179     1179              
- Partials        379      383       +4     
Flag Coverage Δ
unittests 75.73% <ø> (-0.07%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@peternied
Copy link
Member

@sumobrian Could you fill out the pull request template to provide context on this change?

@peternied peternied marked this pull request as draft May 9, 2024 17:56
@peternied peternied removed the draft Indicate that a PR is in draft mode and not ready to merged label May 9, 2024
@peternied
Copy link
Member

FYI - I've removed the 'draft' label and switched this PR to draft; GitHub supports marking pull requests as in a draft state,

@sumobrian sumobrian closed this Jun 26, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants