Add/Modify OSI options on Migration Console

[lewijacn]

Description

This change makes the following minor modifications for our OSI migration setup for the migration console

• Removes incorrect separate OSI pipeline IAM roles for source and target clusters. This must be the same role and have adjusted accordingly
• Add option to include-index-regex. This allows a user to specify multiple selection regexes that we will use to select which indices to migrate when configuring the template for OSI. As a default we will still try to move everything except system indices if not specified.
• Properly hookup missing CW log settings following OSI required conventions
• Minor cleanup in spots of OSI script

Issues Resolved

[List any issues this PR will resolve]

Testing

Local and AWS testing

Check List

• New functionality includes testing
  • All tests pass, including unit test, integration test and doctest
• New functionality has been documented
• Commits are signed per the DCO using --signoff

By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.
For more information on following Developer Certificate of Origin and signing off your commits, please check here.

[peternied]

How do we verify changes to the osi pipeline template?

[lewijacn]

How do we verify changes to the osi pipeline template?

Previously we didn't. Have added some unit tests around this area to give us some more confidence about what we are generating

[codecov]

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 75.72%. Comparing base (2ae2959) to head (a087c93).
Report is 14 commits behind head on main.

Additional details and impacted files

@@             Coverage Diff              @@
##               main     #643      +/-   ##
============================================
- Coverage     75.84%   75.72%   -0.13%     
+ Complexity     1545     1543       -2     
============================================
  Files           168      168              
  Lines          6446     6455       +9     
  Branches        574      575       +1     
============================================
- Hits           4889     4888       -1     
- Misses         1177     1187      +10     
  Partials        380      380              

Flag	Coverage Δ
unittests	75.72% <ø> (-0.13%)	⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

[peternied]

I'm going to walk through these instructions before doing a deeper dive into the change you've made - thanks for including the README.md @lewijacn