-
Notifications
You must be signed in to change notification settings - Fork 27
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add/Modify OSI options on Migration Console #643
Add/Modify OSI options on Migration Console #643
Conversation
…et pipeline roles Signed-off-by: Tanner Lewis <lewijacn@amazon.com>
Signed-off-by: Tanner Lewis <lewijacn@amazon.com>
Signed-off-by: Tanner Lewis <lewijacn@amazon.com>
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
How do we verify changes to the osi pipeline template?
TrafficCapture/dockerSolution/src/main/docker/migrationConsole/osiMigration.py
Outdated
Show resolved
Hide resolved
Signed-off-by: Tanner Lewis <lewijacn@amazon.com>
Previously we didn't. Have added some unit tests around this area to give us some more confidence about what we are generating |
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #643 +/- ##
============================================
- Coverage 75.84% 75.72% -0.13%
+ Complexity 1545 1543 -2
============================================
Files 168 168
Lines 6446 6455 +9
Branches 574 575 +1
============================================
- Hits 4889 4888 -1
- Misses 1177 1187 +10
Partials 380 380
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. |
I'm going to walk through these instructions before doing a deeper dive into the change you've made - thanks for including the README.md @lewijacn |
Description
This change makes the following minor modifications for our OSI migration setup for the migration console
include-index-regex
. This allows a user to specify multiple selection regexes that we will use to select which indices to migrate when configuring the template for OSI. As a default we will still try to move everything except system indices if not specified.Issues Resolved
[List any issues this PR will resolve]
Testing
Local and AWS testing
Check List
By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.
For more information on following Developer Certificate of Origin and signing off your commits, please check here.