Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix Javadoc #645

Merged
merged 2 commits into from
May 9, 2024
Merged

Fix Javadoc #645

merged 2 commits into from
May 9, 2024

Conversation

AndreKurait
Copy link
Member

Description

Fix Javadoc Errors

  • Category: Documentation
  • Why these changes are required? Required for release to maven
  • What is the old behavior before changes and new behavior after changes? Javadoc fails on build

Issues Resolved

N/A

Is this a backport? If so, please add backport PR # and/or commits #

Testing

./gradlew javadoc

Check List

  • [ x] New functionality includes testing
    • [ x] All tests pass, including unit test, integration test and doctest
  • [ x] New functionality has been documented
  • [ x] Commits are signed per the DCO using --signoff

By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.
For more information on following Developer Certificate of Origin and signing off your commits, please check here.

Signed-off-by: Andre Kurait <akurait@amazon.com>
Copy link

codecov bot commented May 9, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 75.76%. Comparing base (2ae2959) to head (b39e502).
Report is 5 commits behind head on main.

Additional details and impacted files
@@             Coverage Diff              @@
##               main     #645      +/-   ##
============================================
- Coverage     75.84%   75.76%   -0.08%     
- Complexity     1545     1546       +1     
============================================
  Files           168      168              
  Lines          6446     6446              
  Branches        574      574              
============================================
- Hits           4889     4884       -5     
- Misses         1177     1180       +3     
- Partials        380      382       +2     
Flag Coverage Δ
unittests 75.76% <ø> (-0.08%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Copy link
Member

@peternied peternied left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Could you update the CI workflow to catch errors like this so we don't miss them before merging?

@AndreKurait
Copy link
Member Author

Could you update the CI workflow to catch errors like this so we don't miss them before merging?

Added anytime we run our tests

Signed-off-by: Andre Kurait <akurait@amazon.com>
@peternied peternied merged commit 4fe92d0 into opensearch-project:main May 9, 2024
6 of 7 checks passed
@AndreKurait AndreKurait deleted the fixJavadoc branch May 9, 2024 20:28
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants