-
Notifications
You must be signed in to change notification settings - Fork 27
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Extend E2E script to allow CDK customization #651
Conversation
Signed-off-by: Tanner Lewis <lewijacn@amazon.com>
Signed-off-by: Tanner Lewis <lewijacn@amazon.com>
Signed-off-by: Tanner Lewis <lewijacn@amazon.com>
Signed-off-by: Tanner Lewis <lewijacn@amazon.com>
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #651 +/- ##
============================================
- Coverage 75.84% 75.55% -0.30%
+ Complexity 1545 1541 -4
============================================
Files 168 168
Lines 6446 6455 +9
Branches 574 575 +1
============================================
- Hits 4889 4877 -12
- Misses 1177 1195 +18
- Partials 380 383 +3
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Overall, makes sense. I have one questions but it's not a blocker.
// For a context block to be provided as a string (as in the case of providing via command line) it will need to be properly escaped | ||
// to be captured. This requires JSON to parse twice, 1. Returns a normal JSON string with no escaping 2. Returns a JSON object for use |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thank you for the comment!
@@ -3,14 +3,20 @@ | |||
# Note: As this script will deploy an E2E solution in AWS, it assumes all the dependencies of the migration solution (e.g. aws cli, cdk cli, |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
No action necessarily required, just a question for you - are you having trouble with maintaining/extending/debugging this script? Have we considered migrating its functionality to something like Python, etc?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I'm 1000% onboard with migrating this script to python, so much so that I let AI take a swing at it the other day to see how well it could do with it, and with some parameters it did a decent job and might be worth looking into as a reference
Signed-off-by: Tanner Lewis <lewijacn@amazon.com>
Description
This change includes the following changes to allow more customization with our awsE2ESolutionSetup.sh script as well as minor bug fixes:
clean-up-all
option to e2e script for cleaning up all deployed resources after runningIssues Resolved
https://opensearch.atlassian.net/browse/MIGRATIONS-1690
Testing
CDK tests and manual AWS testing
Check List
By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.
For more information on following Developer Certificate of Origin and signing off your commits, please check here.