-
Notifications
You must be signed in to change notification settings - Fork 27
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add console_link library to migration console, implement cat-indices #657
Add console_link library to migration console, implement cat-indices #657
Conversation
Setup a docker-compose environment to run jenkins and have a couple build options to build with local (current) changes. I'm also setting up/testing some changes for loading the Jenkinsfile from the repo. Signed-off-by: Greg Schohn <greg.schohn@gmail.com>
Signed-off-by: Mikayla Thompson <thomika@amazon.com>
Signed-off-by: Mikayla Thompson <thomika@amazon.com>
Couple high level thoughts from scanning over:
|
Signed-off-by: Mikayla Thompson <thomika@amazon.com>
Signed-off-by: Mikayla Thompson <thomika@amazon.com>
Yep, that works! It can really be anywhere as long as we can
Yeah, I ended up at console link as I'm thinking of this as the piece that links our frontends and backends, but I have zero attachment to it. And at the very least, I like the idea of the cli command being |
Signed-off-by: Mikayla Thompson <thomika@amazon.com>
Okay, changed the name of the cli, so the example from above is now:
|
@@ -95,6 +95,8 @@ services: | |||
- migrations | |||
volumes: | |||
- sharedReplayerOutput:/shared-replayer-output | |||
- ./migrationConsole/console_link/services.yaml:/etc/migration_services.yaml | |||
- ./migrationConsole/console_link:/root/console_link |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Is this needed since image already has the library?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
No, it's not needed, but it means that I can make code changes locally and instantly test it on the docker container. What do you think about making a note that this is a temporary thing, but keeping it in for now? This seems like the sort of thing that's okay on the e2e branch, but I want a reminder to take it out before we merge to main
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Ah gotcha, yeah I'm fine with a comment for now
Signed-off-by: Mikayla Thompson <thomika@amazon.com>
1f6e4d1
into
opensearch-project:e2e-tests-q2
Description
Unintentionally pulled in @gregschohn 's jenkins changes, will rebase branch to get those out.
But the actual content:
the beginnings of a python library that serves as the link between a frontend (CLI in this case, though web API works too) and various backends (source & target clusters, replayer & backfill services, etc.).
What's included in this PR specifically
Docker env support for cat indices:
Issues Resolved
[List any issues this PR will resolve]
Is this a backport? If so, please add backport PR # and/or commits #
Testing
[Please provide details of testing done: unit testing, integration testing and manual testing]
Check List
By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.
For more information on following Developer Certificate of Origin and signing off your commits, please check here.
Setup a docker-compose environment to run jenkins and have a couple build options to build with local (current) changes.
I'm also setting up/testing some changes for loading the Jenkinsfile from the repo.
Signed-off-by: Greg Schohn greg.schohn@gmail.com