Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Console] Populate services.yaml in CDK for ECS RFS backfill #734

Conversation

mikaylathompson
Copy link
Collaborator

Note

This is based off of #728, so the diff is much smaller than it appears here -- it should just be the final 3 commits. It should not be merged until that one is. At that point, I'll merge from main if necessary and ensure that the diff shrinks to just the incremental commits.

Description

Backfill is added a full concept in #728, which also defines the structure for the backfill entry in the services.yaml file.

In this PR, that structure is filled out for the case of RFS running on ECS and deployed via CDK.

I also realized that cluster_name needs to be a required field because it will be necessary for the ecs update-service calls made by the RFS-on-ECS backend adapter.

Issues Resolved

MIGRATIONS-1777

Testing

Commits add unit tests. Also manually tested via ./awsE2ESolutionSetup.sh.

Check List

  • New functionality includes testing
    • All tests pass, including unit test, integration test and doctest
  • New functionality has been documented
  • Commits are signed per the DCO using --signoff

By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.
For more information on following Developer Certificate of Origin and signing off your commits, please check here.

Signed-off-by: Mikayla Thompson <thomika@amazon.com>
Signed-off-by: Mikayla Thompson <thomika@amazon.com>
Signed-off-by: Mikayla Thompson <thomika@amazon.com>
@mikaylathompson mikaylathompson force-pushed the populate-ecs-rfs-backfill-services-yaml branch from 672a3e8 to a15d440 Compare June 18, 2024 20:53
Copy link

codecov bot commented Jun 18, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 64.84%. Comparing base (e2dc574) to head (1bd15c0).
Report is 6 commits behind head on main.

Additional details and impacted files
@@             Coverage Diff              @@
##               main     #734      +/-   ##
============================================
+ Coverage     64.78%   64.84%   +0.06%     
- Complexity     1586     1590       +4     
============================================
  Files           238      238              
  Lines          9879     9879              
  Branches        771      771              
============================================
+ Hits           6400     6406       +6     
+ Misses         3069     3065       -4     
+ Partials        410      408       -2     
Flag Coverage Δ
unittests 64.08% <ø> (+0.06%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

metrics_source: this.metrics_source
metrics_source: this.metrics_source,
backfill: this.backfill
? (this.backfill instanceof RFSBackfillYaml
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Its strange that this logic is in ServicesYaml. By using polymorphism the different types can self-describe how they are formatted as json internally

Signed-off-by: Mikayla Thompson <thomika@amazon.com>
@mikaylathompson mikaylathompson merged commit fdb0c77 into opensearch-project:main Jun 18, 2024
10 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants