Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fixed a few bugs in the gradle setup for rfs #736

Merged
merged 2 commits into from
Jun 19, 2024

Conversation

chelma
Copy link
Member

@chelma chelma commented Jun 19, 2024

Description

  • Fixed a few RFS gradle bugs
  • Switched RFS Docker Compose back to ES 7.10
  • ES 7.17 test source container is not standing up correctly

Issues Resolved

N/A

Testing

manual testing

Check List

  • New functionality includes testing
    • All tests pass, including unit test, integration test and doctest
  • New functionality has been documented
  • Commits are signed per the DCO using --signoff

By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.
For more information on following Developer Certificate of Origin and signing off your commits, please check here.

Signed-off-by: Chris Helma <chelma+github@amazon.com>
Signed-off-by: Chris Helma <chelma+github@amazon.com>
Copy link

codecov bot commented Jun 19, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 64.01%. Comparing base (6381c73) to head (e6007cb).
Report is 51 commits behind head on main.

Additional details and impacted files
@@             Coverage Diff              @@
##               main     #736      +/-   ##
============================================
+ Coverage     57.41%   64.01%   +6.59%     
- Complexity        0     1588    +1588     
============================================
  Files            11      223     +212     
  Lines           573     9092    +8519     
  Branches          0      771     +771     
============================================
+ Hits            329     5820    +5491     
- Misses          244     2862    +2618     
- Partials          0      410     +410     
Flag Coverage Δ
unittests 64.01% <ø> (?)

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Copy link
Member

@AndreKurait AndreKurait left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for taking a look. Let's quickly follow up on if we can get 7_17 working for the demo

.withTag("latest")
.exec()
}
}

task removeClientContainer(type: DockerRemoveContainer) {
dependsOn waitClientContainer
dependsOn commitSourceContainer
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

why would you need to wait for the source to be committed? Shouldn't the client finishing be independent of when the sync happens?

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Good question. We probably don't need to do this, but it made the sequence of operations clearer in my mind when I was trying to figure out why the commitSourceContainer task didn't appear to be firing. In reality the commit task was firing, it just didn't report anything to stdout.

@chelma chelma merged commit b797e4f into opensearch-project:main Jun 19, 2024
7 checks passed
@chelma chelma deleted the rfs-gradle-fix branch June 19, 2024 13:56
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants