Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix broken python requirements file #738

Merged
merged 1 commit into from
Jun 19, 2024

Conversation

peternied
Copy link
Member

Description

When running python3 -m pip install -r requirements.txt on this file an errors occurs because >== isn't a validate qualifier for version information. This is causing issue with GitHub dependency scans and might have been the source of issues with mend and other tools configuration.

Testing

Validated locally - with python3 -m pip install -r requirements.txt. I'll follow up separaretely on #688 to make sure we are using the error checking form of this build script

Check List

  • New functionality includes testing
    • All tests pass, including unit test, integration test and doctest
  • New functionality has been documented
  • Commits are signed per the DCO using --signoff

By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.
For more information on following Developer Certificate of Origin and signing off your commits, please check here.

When running `python3 -m pip install -r requirements.txt` on this file
an errors occurs because `>==` isn't a validate qualifier for version
information.  This is causing issue with GitHub dependency scans and
might have been the source of issues with mend and other tools
configuration.

See https://github.com/opensearch-project/opensearch-migrations/security/dependabot/11

Signed-off-by: Peter Nied <peternied@hotmail.com>
Copy link

codecov bot commented Jun 19, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 63.92%. Comparing base (b9d2d5f) to head (c024deb).
Report is 2 commits behind head on main.

Additional details and impacted files
@@             Coverage Diff              @@
##               main     #738      +/-   ##
============================================
+ Coverage     63.89%   63.92%   +0.03%     
  Complexity     1584     1584              
============================================
  Files           223      223              
  Lines          9092     9092              
  Branches        771      771              
============================================
+ Hits           5809     5812       +3     
+ Misses         2874     2871       -3     
  Partials        409      409              
Flag Coverage Δ
unittests 63.92% <ø> (+0.03%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@peternied
Copy link
Member Author

Created issue Flaky test test_0006_OSB [1] and retrying the E2E Testing suite

@peternied
Copy link
Member Author

peternied commented Jun 19, 2024

Second failure on test_0006_OSB [1], updated the issue and retrying the E2E Testing suite

@mikaylathompson
Copy link
Collaborator

One note on debugging the test failures, it's actually two tests failing, both 0002 and 0006. It seems very unlikely to be related to this code change, but is a slightly more interesting debugging picture.

 =========================== short test summary info ============================
FAILED tests.py::E2ETests::test_0002_document - Exception: All 15 retry attempts failed. Please check the logs for more information.
FAILED tests.py::E2ETests::test_0006_OSB - AssertionError: Items in the first set but not the second:
'reindexed-logs' : Valid indices for source and target are not equal - Source = {'logs-231998', 'logs-191998', 'reindexed-logs', 'logs-241998', 'nyc_taxis', 'geonames', 'logs-201998', 'logs-221998', 'sonested', 'logs-181998', 'logs-211998'}, Target = {'logs-231998', 'logs-191998', 'logs-241998', 'nyc_taxis', 'geonames', 'logs-201998', 'logs-221998', 'sonested', 'logs-181998', 'logs-211998'}
======== 2 failed, 5 passed, 1 skipped, 7 warnings in 311.66s (0:05:11) ========

@peternied peternied merged commit aee343f into opensearch-project:main Jun 19, 2024
7 checks passed
@peternied peternied deleted the fix-test-requirements branch June 19, 2024 20:55
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants