Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Console] Implement start/stop for RFS backfill on ECS #740

Conversation

mikaylathompson
Copy link
Collaborator

Description

This PR implements start and stop for an RFS backfill running on ECS, by setting the desired count of the ECS service to either the scale number in services.yaml (default is 1 if not provided) or to 0 (for stop).

I created an ECSService class that handles the actual communication with ECS and will be reused to implement the same thing for the replayer.

Tested manually in an AWS deployment.

Issues Resolved

MIGRATIONS-1789

Testing

Manually in an AWS deployment & via unit tests.

⚠️ We don't currently have an E2E tests that use RFS.

Check List

  • New functionality includes testing
    • All tests pass, including unit test, integration test and doctest
  • New functionality has been documented
  • Commits are signed per the DCO using --signoff

By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.
For more information on following Developer Certificate of Origin and signing off your commits, please check here.

Signed-off-by: Mikayla Thompson <thomika@amazon.com>
Signed-off-by: Mikayla Thompson <thomika@amazon.com>
Signed-off-by: Mikayla Thompson <thomika@amazon.com>
Signed-off-by: Mikayla Thompson <thomika@amazon.com>
Copy link

codecov bot commented Jun 19, 2024

Codecov Report

Attention: Patch coverage is 66.10169% with 20 lines in your changes missing coverage. Please review.

Project coverage is 64.95%. Comparing base (8e4c8a7) to head (729049e).
Report is 55 commits behind head on main.

Files Patch % Lines
...le/lib/console_link/console_link/logic/backfill.py 0.00% 12 Missing ⚠️
...rationConsole/lib/console_link/console_link/cli.py 16.66% 5 Missing ⚠️
...console_link/console_link/models/command_result.py 25.00% 3 Missing ⚠️
Additional details and impacted files
@@             Coverage Diff              @@
##               main     #740      +/-   ##
============================================
+ Coverage     64.85%   64.95%   +0.09%     
- Complexity     1588     1591       +3     
============================================
  Files           238      239       +1     
  Lines          9879     9918      +39     
  Branches        771      771              
============================================
+ Hits           6407     6442      +35     
- Misses         3064     3068       +4     
  Partials        408      408              
Flag Coverage Δ
gradle-test ?
python-test ?
unittests 64.08% <ø> (?)

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Signed-off-by: Mikayla Thompson <thomika@amazon.com>
@mikaylathompson mikaylathompson merged commit 39cf3b7 into opensearch-project:main Jun 19, 2024
9 checks passed
@mikaylathompson mikaylathompson deleted the console-lib-implement-rfs-on-ecs branch June 25, 2024 08:28
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants