Add job that passed when all other CI jobs have completed #741
+14
−1
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
GitHub allows 'requiring' a job to be run before a pull request can be merged, by adding a new job that 'needs' all the other ci jobs, this job will run last and only if they all pass. After this is merged someone from the admin team can update the repo settings to enforce this requirement. Signed-off-by: Peter Nied <peternied@hotmail.com>
peternied
requested review from
AndreKurait,
chelma,
gregschohn,
lewijacn,
mikaylathompson,
okhasawn and
sumobrian
as code owners
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #741 +/- ##
============================================
+ Coverage 63.96% 64.75% +0.79%
- Complexity 1584 1585 +1
============================================
Files 223 238 +15
Lines 9093 9880 +787
Branches 771 771
============================================
+ Hits 5816 6398 +582
- Misses 2866 3072 +206
+ Partials 411 410 -1
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. |
AndreKurait
approved these changes
Jun 19, 2024
|
@opensearch-project/admin Can you please add a branch protection on main that required check for |
Done! Also added |
|
@gaiksaya Thanks for the fast turn around! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
GitHub allows 'requiring' a job to be run before a pull request can be merged, by adding a new job that 'needs' all the other ci jobs, this job will run last and only if they all pass.
After this is merged someone from the admin team can update the repo settings to enforce this requirement.
Check List
New functionality includes testingAll tests pass, including unit test, integration test and doctestNew functionality has been documentedBy submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.
For more information on following Developer Certificate of Origin and signing off your commits, please check here.