Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Switch all python projects to use pipenv #752

Merged
merged 15 commits into from
Jun 21, 2024

Conversation

peternied
Copy link
Member

Description

No more *requirements.txt files for any python dependencies, move all the way over to Pipfile with Pipfile.lock to ensure we are only using the expected dependencies.

For follow up - ideally we would have a single lock file at the root of the project. I'm going to leave that up to future iteration in this if we reorganize any of our python projects. This is far outside my domain of knowledge.

Issues Resolved

We are still seeing failures [1] when build analyze runs where outdated versions of our dependencies are being picked up. By switching the infrastructure of our python projects to have a lock file this should prevent the adhoc references to older versions via transitive dependencies.

Check List

  • New functionality includes testing
    • All tests pass, including unit test, integration test and doctest
  • New functionality has been documented
  • Commits are signed per the DCO using --signoff

By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.
For more information on following Developer Certificate of Origin and signing off your commits, please check here.

Signed-off-by: Peter Nied <peternied@hotmail.com>
Signed-off-by: Peter Nied <peternied@hotmail.com>
Signed-off-by: Peter Nied <peternied@hotmail.com>
Signed-off-by: Peter Nied <peternied@hotmail.com>
Signed-off-by: Peter Nied <peternied@hotmail.com>
Signed-off-by: Peter Nied <peternied@hotmail.com>
Signed-off-by: Peter Nied <peternied@hotmail.com>
Signed-off-by: Peter Nied <peternied@hotmail.com>
Signed-off-by: Peter Nied <peternied@hotmail.com>
Signed-off-by: Peter Nied <peternied@hotmail.com>
Signed-off-by: Peter Nied <peternied@hotmail.com>
Copy link

codecov bot commented Jun 20, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 69.82%. Comparing base (11dc524) to head (57007c0).
Report is 1 commits behind head on main.

Current head 57007c0 differs from pull request most recent head 58be4d3

Please upload reports for the commit 58be4d3 to get more accurate results.

Additional details and impacted files
@@             Coverage Diff              @@
##               main     #752      +/-   ##
============================================
+ Coverage     64.79%   69.82%   +5.02%     
- Complexity     1588     1593       +5     
============================================
  Files           241      269      +28     
  Lines         10039    11815    +1776     
  Branches        772      772              
============================================
+ Hits           6505     8250    +1745     
- Misses         3126     3158      +32     
+ Partials        408      407       -1     
Flag Coverage Δ
gradle-test 64.02% <ø> (+0.05%) ⬆️
python-test 89.37% <ø> (+16.48%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Signed-off-by: Peter Nied <peternied@hotmail.com>
Signed-off-by: Peter Nied <peternied@hotmail.com>
Signed-off-by: Peter Nied <peternied@hotmail.com>
name = "pypi"

[packages]
console-link = {file = "../lib/console_link", editable = true}
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Ah, great, I was wondering how it handled local packages.

@peternied
Copy link
Member Author

image

🥳

@peternied peternied merged commit bc07a76 into opensearch-project:main Jun 21, 2024
10 checks passed
@peternied peternied deleted the pipenv branch June 21, 2024 16:15
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants