-
Notifications
You must be signed in to change notification settings - Fork 27
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fix FetchMigration build #753
Fix FetchMigration build #753
Conversation
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #753 +/- ##
=============================================
- Coverage 89.37% 68.21% -21.17%
- Complexity 0 1579 +1579
=============================================
Files 46 270 +224
Lines 2702 11139 +8437
Branches 0 736 +736
=============================================
+ Hits 2415 7598 +5183
- Misses 287 3140 +2853
- Partials 0 401 +401
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks for fixing this, looks like we are missing attempting to build the fetch migration cluster in our GHA, can you please add a check that would build this image?
a3f68ea
to
b160070
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks!
Signed-off-by: Andre Kurait <akurait@amazon.com>
Signed-off-by: Andre Kurait <akurait@amazon.com>
b160070
to
4ed4450
Compare
Description
Fix FetchMigration build
Issues Resolved
Currently getting
Is this a backport? If so, please add backport PR # and/or commits #
Testing
Ran build
Check List
By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.
For more information on following Developer Certificate of Origin and signing off your commits, please check here.