-
Notifications
You must be signed in to change notification settings - Fork 27
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[Console] Make changes for filesystem snapshots #755
[Console] Make changes for filesystem snapshots #755
Conversation
Signed-off-by: Mikayla Thompson <thomika@amazon.com>
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #755 +/- ##
============================================
+ Coverage 68.18% 68.35% +0.17%
Complexity 1577 1577
============================================
Files 270 270
Lines 11139 11175 +36
Branches 736 736
============================================
+ Hits 7595 7639 +44
+ Misses 3141 3133 -8
Partials 403 403
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. |
Signed-off-by: Mikayla Thompson <thomika@amazon.com>
Signed-off-by: Mikayla Thompson <thomika@amazon.com>
Signed-off-by: Mikayla Thompson <thomika@amazon.com>
Signed-off-by: Mikayla Thompson <thomika@amazon.com>
428674a
to
293ab14
Compare
snapshot: | ||
snapshot_name: "snapshot_2023_01_01" | ||
s3_repo_uri: "s3://my-snapshot-bucket" | ||
s3_region: "us-east-2" | ||
s3: |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Should this have the fs keys to make snapshots with docker solution?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Oh, yep, definitely. Fixing now.
Signed-off-by: Mikayla Thompson <thomika@amazon.com>
Signed-off-by: Mikayla Thompson <thomika@amazon.com>
Signed-off-by: Mikayla Thompson <thomika@amazon.com>
d18c737
to
2be3d70
Compare
179aef1
into
opensearch-project:main
Description
Console library support for the Java changes in #754.
Supports snapshot descriptions like:
or
Tests are fixed up (and a number are added), includes CDK support, etc.
Issues Resolved
n/a
Testing
[Please provide details of testing done: unit testing, integration testing and manual testing]
Check List
By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.
For more information on following Developer Certificate of Origin and signing off your commits, please check here.