-
Notifications
You must be signed in to change notification settings - Fork 27
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[Console] Status for RFS Backfill #771
[Console] Status for RFS Backfill #771
Conversation
Signed-off-by: Mikayla Thompson <thomika@amazon.com>
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #771 +/- ##
=============================================
+ Coverage 68.51% 87.56% +19.05%
=============================================
Files 275 50 -225
Lines 11596 3242 -8354
Branches 735 0 -735
=============================================
- Hits 7945 2839 -5106
+ Misses 3248 403 -2845
+ Partials 403 0 -403
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. |
if exitcode != ExitCode.SUCCESS: | ||
raise click.ClickException(message) | ||
click.echo(message) | ||
if len(message) == 2: |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
nit: For consistency, can we just have the message be a single string with '\n'
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
yup, this was ugly, I like that better.
Signed-off-by: Mikayla Thompson <thomika@amazon.com>
Signed-off-by: Mikayla Thompson <thomika@amazon.com>
Description
Add status output for
backfill
if the backfill type is RFS running on ECS.console backfill status
will print:Additionally, if
--deep-check
is added to the command, it will query the.migrations_working_state
index on the target cluster and check how many shards are remaining.Issues Resolved
https://opensearch.atlassian.net/browse/MIGRATIONS-1790
Testing
Unit tests added, plus manual testing on ECS
Check List
By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.
For more information on following Developer Certificate of Origin and signing off your commits, please check here.