Skip to content

Commit

Permalink
Rename to QueryShapeGenerator
Browse files Browse the repository at this point in the history
Signed-off-by: David Zane <davizane@amazon.com>
  • Loading branch information
dzane17 committed Jul 25, 2024
1 parent 38eef6a commit 3bee0cf
Show file tree
Hide file tree
Showing 3 changed files with 7 additions and 7 deletions.
Original file line number Diff line number Diff line change
Expand Up @@ -22,7 +22,7 @@
import java.util.Collections;
import java.util.List;

public class QueryShapeService {
public class QueryShapeGenerator {
static final String TWO_SPACE_INDENT = " ";

public static String buildShape(SearchSourceBuilder source, Boolean showFields) {
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -88,7 +88,7 @@ public void categorize(SearchQueryRecord record) {
incrementQueryAggregationCounters(source.aggregations(), measurements);
incrementQuerySortCounters(source.sorts(), measurements);

String searchShape = QueryShapeService.buildShape(source, true);
String searchShape = QueryShapeGenerator.buildShape(source, true);
logger.trace(searchShape);
}

Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -13,14 +13,14 @@
import org.opensearch.index.query.QueryBuilders;
import org.opensearch.index.query.RegexpQueryBuilder;
import org.opensearch.index.query.TermQueryBuilder;
import org.opensearch.plugin.insights.core.service.categorizer.QueryShapeService;
import org.opensearch.plugin.insights.core.service.categorizer.QueryShapeGenerator;
import org.opensearch.search.aggregations.bucket.terms.TermsAggregationBuilder;
import org.opensearch.search.aggregations.support.ValueType;
import org.opensearch.search.builder.SearchSourceBuilder;
import org.opensearch.search.sort.SortOrder;
import org.opensearch.test.OpenSearchTestCase;

public final class QueryShapeServiceTests extends OpenSearchTestCase {
public final class QueryShapeGeneratorTests extends OpenSearchTestCase {
public void testQueryShape() {
SearchSourceBuilder sourceBuilder = new SearchSourceBuilder();
sourceBuilder.size(0);
Expand All @@ -29,7 +29,7 @@ public void testQueryShape() {
RegexpQueryBuilder regexpQueryBuilder = new RegexpQueryBuilder("field", "text");
sourceBuilder.query(new BoolQueryBuilder().must(termQueryBuilder).filter(matchQueryBuilder).should(regexpQueryBuilder));

String shape = QueryShapeService.buildShape(sourceBuilder, true);
String shape = QueryShapeGenerator.buildShape(sourceBuilder, true);

String expected = "bool\n" + " must:\n" + " term\n" + " filter:\n" + " match\n" + " should:\n" + " regexp\n";
assertEquals(expected, shape);
Expand All @@ -46,7 +46,7 @@ public void testAggregationShape() {
.subAggregation(new TermsAggregationBuilder("child-agg2").userValueTypeHint(ValueType.STRING).field("key.sub2"))
);

String shape = QueryShapeService.buildShape(sourceBuilder, true);
String shape = QueryShapeGenerator.buildShape(sourceBuilder, true);

String expected = "aggregation:\n"
+ " terms [key]\n"
Expand All @@ -65,7 +65,7 @@ public void testSortShape() {
sourceBuilder.sort("price", SortOrder.ASC);
sourceBuilder.sort("album", SortOrder.ASC);

String shape = QueryShapeService.buildShape(sourceBuilder, true);
String shape = QueryShapeGenerator.buildShape(sourceBuilder, true);

String expected = "sort:\n" + " asc [album]\n" + " asc [price]\n" + " desc [color]\n" + " desc [vendor]\n";
assertEquals(expected, shape);
Expand Down

0 comments on commit 3bee0cf

Please sign in to comment.