Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Backport 2.17] Query grouping framework for Top N queries and group by query similarity #104

Merged
merged 1 commit into from
Sep 5, 2024

Conversation

opensearch-trigger-bot[bot]
Copy link

Backport 65e4489 from #66.

…ity (#66)

* Query grouping framework and group by query similarity

Signed-off-by: Siddhant Deshmukh <deshsid@amazon.com>

* Spotless apply

Signed-off-by: Siddhant Deshmukh <deshsid@amazon.com>

* Build fix

Signed-off-by: Siddhant Deshmukh <deshsid@amazon.com>

* Properly configure settings update consumer

Signed-off-by: Siddhant Deshmukh <deshsid@amazon.com>

* Address review comments

Signed-off-by: Siddhant Deshmukh <deshsid@amazon.com>

* Refactor unit tests

Signed-off-by: Siddhant Deshmukh <deshsid@amazon.com>

* Decouple Measurement and MetricType

Signed-off-by: Siddhant Deshmukh <deshsid@amazon.com>

* Aggregate type NONE will ensure no aggregations computed

Signed-off-by: Siddhant Deshmukh <deshsid@amazon.com>

* Perform renaming

Signed-off-by: Siddhant Deshmukh <deshsid@amazon.com>

* Integrate query shape library with grouping

Signed-off-by: Siddhant Deshmukh <deshsid@amazon.com>

* Spotless

Signed-off-by: Siddhant Deshmukh <deshsid@amazon.com>

* Create and consume string hashcode interface

Signed-off-by: Siddhant Deshmukh <deshsid@amazon.com>

* Health checks in code

Signed-off-by: Siddhant Deshmukh <deshsid@amazon.com>

* Fix tests and spotless apply

Signed-off-by: Siddhant Deshmukh <deshsid@amazon.com>

* Minor fixes

Signed-off-by: Siddhant Deshmukh <deshsid@amazon.com>

* Max groups setting and unit tests

Signed-off-by: Siddhant Deshmukh <deshsid@amazon.com>

* Address review comments

Signed-off-by: Siddhant Deshmukh <deshsid@amazon.com>

* Address review comments

Signed-off-by: Siddhant Deshmukh <deshsid@amazon.com>

* Create query grouper interface and top query store interface

Signed-off-by: Siddhant Deshmukh <deshsid@amazon.com>

* Address review comments

Signed-off-by: Siddhant Deshmukh <deshsid@amazon.com>

* Removed unused interface

Signed-off-by: Siddhant Deshmukh <deshsid@amazon.com>

* Rebase main and spotless

Signed-off-by: Siddhant Deshmukh <deshsid@amazon.com>

* Renaming variable

Signed-off-by: Siddhant Deshmukh <deshsid@amazon.com>

* Remove TopQueriesStore interface

Signed-off-by: Siddhant Deshmukh <deshsid@amazon.com>

* Drain top queries service on group change

Signed-off-by: Siddhant Deshmukh <deshsid@amazon.com>

* Rename max groups setting and allow minimum 0

Signed-off-by: Siddhant Deshmukh <deshsid@amazon.com>

* Make write/read from io backword compatible

Signed-off-by: Siddhant Deshmukh <deshsid@amazon.com>

* Minor fix

Signed-off-by: Siddhant Deshmukh <deshsid@amazon.com>

* Refactor query grouper

Signed-off-by: Siddhant Deshmukh <deshsid@amazon.com>

---------

Signed-off-by: Siddhant Deshmukh <deshsid@amazon.com>
(cherry picked from commit 65e4489)
Signed-off-by: github-actions[bot] <github-actions[bot]@users.noreply.github.com>
@ansjcy ansjcy merged commit fb6afb2 into 2.17 Sep 5, 2024
23 of 24 checks passed
@ansjcy ansjcy deleted the backport/backport-66-to-2.17 branch September 5, 2024 19:46
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant