Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Upgrade deprecated actions/upload-artifact versions to v3 #117

Merged
merged 1 commit into from
Sep 17, 2024

Conversation

dzane17
Copy link
Collaborator

@dzane17 dzane17 commented Sep 17, 2024

Description

Upgrade deprecated actions/upload-artifact versions to v3

Issues Resolved

Error: This request has been automatically failed because it uses a deprecated version of actions/upload-artifact: v1. Learn more: https://github.blog/changelog/2024-02-13-deprecation-notice-v1-and-v2-of-the-artifact-actions/. This request has been automatically failed because it uses a deprecated version of actions/upload-artifact: v2. Learn more: https://github.blog/changelog/2024-02-13-deprecation-notice-v1-and-v2-of-the-artifact-actions/
By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.
For more information on following Developer Certificate of Origin and signing off your commits, please check here.

Signed-off-by: David Zane <davizane@amazon.com>
@ansjcy
Copy link
Member

ansjcy commented Sep 17, 2024

Why do we need to upgrade actions/checkout?

@ansjcy
Copy link
Member

ansjcy commented Sep 17, 2024

LGTM, thanks for fixing the CI!

@ansjcy ansjcy merged commit 290c701 into opensearch-project:main Sep 17, 2024
16 checks passed
opensearch-trigger-bot bot pushed a commit that referenced this pull request Sep 17, 2024
Signed-off-by: David Zane <davizane@amazon.com>
(cherry picked from commit 290c701)
Signed-off-by: github-actions[bot] <github-actions[bot]@users.noreply.github.com>
@dzane17 dzane17 deleted the upload-artifact branch September 17, 2024 20:35
@dzane17
Copy link
Collaborator Author

dzane17 commented Sep 17, 2024

Regarding actions/checkout, I saw some warnings that it is also deprecated but not causing errors yet. We can open a separate PR for it.

@dzane17 dzane17 changed the title Upgrade deprecated actions/upload-artifact versions to v4 Upgrade deprecated actions/upload-artifact versions to v3 Sep 17, 2024
ansjcy pushed a commit that referenced this pull request Sep 17, 2024
(cherry picked from commit 290c701)

Signed-off-by: David Zane <davizane@amazon.com>
Signed-off-by: github-actions[bot] <github-actions[bot]@users.noreply.github.com>
Co-authored-by: github-actions[bot] <github-actions[bot]@users.noreply.github.com>
opensearch-trigger-bot bot pushed a commit that referenced this pull request Sep 24, 2024
(cherry picked from commit 290c701)

Signed-off-by: David Zane <davizane@amazon.com>
Signed-off-by: github-actions[bot] <github-actions[bot]@users.noreply.github.com>
Co-authored-by: github-actions[bot] <github-actions[bot]@users.noreply.github.com>
(cherry picked from commit 5a76db2)
Signed-off-by: github-actions[bot] <github-actions[bot]@users.noreply.github.com>
opensearch-trigger-bot bot pushed a commit that referenced this pull request Sep 24, 2024
(cherry picked from commit 290c701)

Signed-off-by: David Zane <davizane@amazon.com>
Signed-off-by: github-actions[bot] <github-actions[bot]@users.noreply.github.com>
Co-authored-by: github-actions[bot] <github-actions[bot]@users.noreply.github.com>
(cherry picked from commit 5a76db2)
Signed-off-by: github-actions[bot] <github-actions[bot]@users.noreply.github.com>
ansjcy pushed a commit that referenced this pull request Sep 24, 2024
(cherry picked from commit 290c701)




(cherry picked from commit 5a76db2)

Signed-off-by: David Zane <davizane@amazon.com>
Signed-off-by: github-actions[bot] <github-actions[bot]@users.noreply.github.com>
Co-authored-by: github-actions[bot] <github-actions[bot]@users.noreply.github.com>
ansjcy pushed a commit that referenced this pull request Sep 24, 2024
(cherry picked from commit 290c701)




(cherry picked from commit 5a76db2)

Signed-off-by: David Zane <davizane@amazon.com>
Signed-off-by: github-actions[bot] <github-actions[bot]@users.noreply.github.com>
Co-authored-by: github-actions[bot] <github-actions[bot]@users.noreply.github.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants