Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Query instrumentation Minor Enhancements #73

Merged

Conversation

deshsidd
Copy link
Collaborator

Description

Minor enhancements to query categorization based on local testing.

  1. Make sure query type and aggregation type are 2 separate tags/attributes and do not overlap
  2. Change the unit type for histograms for latency, cpu and memory

Issues Resolved

List any issues this PR will resolve, e.g. Closes [...].

By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.
For more information on following Developer Certificate of Origin and signing off your commits, please check here.

Signed-off-by: Siddhant Deshmukh <deshsid@amazon.com>
Signed-off-by: Siddhant Deshmukh <deshsid@amazon.com>
Signed-off-by: Siddhant Deshmukh <deshsid@amazon.com>
Signed-off-by: Siddhant Deshmukh <deshsid@amazon.com>
@jainankitk jainankitk merged commit c6a46f5 into opensearch-project:main Aug 27, 2024
16 checks passed
@opensearch-trigger-bot
Copy link

The backport to 2.x failed:

The process '/usr/bin/git' failed with exit code 128

To backport manually, run these commands in your terminal:

# Navigate to the root of your repository
cd $(git rev-parse --show-toplevel)
# Fetch latest updates from GitHub
git fetch
# Create a new working tree
git worktree add ../.worktrees/query-insights/backport-2.x 2.x
# Navigate to the new working tree
pushd ../.worktrees/query-insights/backport-2.x
# Create a new branch
git switch --create backport/backport-73-to-2.x
# Cherry-pick the merged commit of this pull request and resolve the conflicts
git cherry-pick -x --mainline 1 c6a46f512d6cf05699bfbc0ee4d00713b24eecb1
# Push it to GitHub
git push --set-upstream origin backport/backport-73-to-2.x
# Go back to the original working tree
popd
# Delete the working tree
git worktree remove ../.worktrees/query-insights/backport-2.x

Then, create a pull request where the base branch is 2.x and the compare/head branch is backport/backport-73-to-2.x.

deshsidd added a commit to deshsidd/query-insights that referenced this pull request Aug 28, 2024
* Query instrumentation minor fixes

Signed-off-by: Siddhant Deshmukh <deshsid@amazon.com>

* Fix unit tests

Signed-off-by: Siddhant Deshmukh <deshsid@amazon.com>

* Rename package

Signed-off-by: Siddhant Deshmukh <deshsid@amazon.com>

* Spotless

Signed-off-by: Siddhant Deshmukh <deshsid@amazon.com>

---------

Signed-off-by: Siddhant Deshmukh <deshsid@amazon.com>
deshsidd added a commit to deshsidd/query-insights that referenced this pull request Aug 28, 2024
* Query instrumentation minor fixes

Signed-off-by: Siddhant Deshmukh <deshsid@amazon.com>

* Fix unit tests

Signed-off-by: Siddhant Deshmukh <deshsid@amazon.com>

* Rename package

Signed-off-by: Siddhant Deshmukh <deshsid@amazon.com>

* Spotless

Signed-off-by: Siddhant Deshmukh <deshsid@amazon.com>

---------

Signed-off-by: Siddhant Deshmukh <deshsid@amazon.com>
opensearch-trigger-bot bot pushed a commit that referenced this pull request Aug 28, 2024
* Query instrumentation minor fixes

Signed-off-by: Siddhant Deshmukh <deshsid@amazon.com>

* Fix unit tests

Signed-off-by: Siddhant Deshmukh <deshsid@amazon.com>

* Rename package

Signed-off-by: Siddhant Deshmukh <deshsid@amazon.com>

* Spotless

Signed-off-by: Siddhant Deshmukh <deshsid@amazon.com>

---------

Signed-off-by: Siddhant Deshmukh <deshsid@amazon.com>
(cherry picked from commit c6a46f5)
Signed-off-by: github-actions[bot] <github-actions[bot]@users.noreply.github.com>
deshsidd pushed a commit that referenced this pull request Aug 28, 2024
* Query instrumentation minor fixes



* Fix unit tests



* Rename package



* Spotless



---------


(cherry picked from commit c6a46f5)

Signed-off-by: Siddhant Deshmukh <deshsid@amazon.com>
Signed-off-by: github-actions[bot] <github-actions[bot]@users.noreply.github.com>
Co-authored-by: github-actions[bot] <github-actions[bot]@users.noreply.github.com>
dzane17 pushed a commit to dzane17/query-insights that referenced this pull request Aug 30, 2024
* Query instrumentation minor fixes

Signed-off-by: Siddhant Deshmukh <deshsid@amazon.com>

* Fix unit tests

Signed-off-by: Siddhant Deshmukh <deshsid@amazon.com>

* Rename package

Signed-off-by: Siddhant Deshmukh <deshsid@amazon.com>

* Spotless

Signed-off-by: Siddhant Deshmukh <deshsid@amazon.com>

---------

Signed-off-by: Siddhant Deshmukh <deshsid@amazon.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants