Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Adds system index permission as allowed action under static drop down list #1695

Conversation

DarshitChanpura
Copy link
Member

@DarshitChanpura DarshitChanpura commented Dec 13, 2023

Description

At present, the allowed action system:admin/system_index is not visible in the static drop down list and hence is not available to be assigned to a role. This PR adds that capability

Category

Bug fix

Issues Resolved

Testing

  • Should be present in Index permissions:
    Screenshot 2023-12-13 at 6 14 12 PM

  • Should not be present in cluster permissions:
    Screenshot 2023-12-13 at 6 16 28 PM

Check List

  • New functionality includes testing
    - [ ] New functionality has been documented
  • Commits are signed per the DCO using --signoff

By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.
For more information on following Developer Certificate of Origin and signing off your commits, please check here.

… list

Signed-off-by: Darshit Chanpura <dchanp@amazon.com>
Signed-off-by: Darshit Chanpura <dchanp@amazon.com>
Copy link

codecov bot commented Dec 13, 2023

Codecov Report

All modified and coverable lines are covered by tests ✅

Comparison is base (96a449f) 67.09% compared to head (1ef5ccc) 67.09%.

Additional details and impacted files
@@           Coverage Diff           @@
##             main    #1695   +/-   ##
=======================================
  Coverage   67.09%   67.09%           
=======================================
  Files          94       94           
  Lines        2404     2404           
  Branches      318      318           
=======================================
  Hits         1613     1613           
  Misses        713      713           
  Partials       78       78           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@DarshitChanpura DarshitChanpura marked this pull request as ready for review December 13, 2023 23:20
@DarshitChanpura DarshitChanpura added backport 2.x backport to 2.x branch v2.12.0 Items targeting 2.12.0 labels Dec 13, 2023
@DarshitChanpura DarshitChanpura self-assigned this Dec 13, 2023
Copy link
Collaborator

@derek-ho derek-ho left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Do we want to separate out the two functionality? It seems like this is packaging the index permission with some of the admin:admin work, but I am generally ok with this as is

@DarshitChanpura
Copy link
Member Author

DarshitChanpura commented Jan 2, 2024

Do we want to separate out the two functionality? It seems like this is packaging the index permission with some of the admin:admin work, but I am generally ok with this as is

Its a relatively small change, and IMO is okay to merge.

Copy link
Member

@peternied peternied left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Do we want to separate out the two functionality? It seems like this is packaging the index permission with some of the admin:admin work, but I am generally ok with this as is

Lets separate the permissions changes from the default password changes. The additional permissions option doesn't seem time sensitive and it would be good to make a clear PR / commit when we've been changing how passwords are handled.

@DarshitChanpura DarshitChanpura merged commit d64ee48 into opensearch-project:main Jan 4, 2024
18 checks passed
DarshitChanpura added a commit to DarshitChanpura/security-dashboards-plugin that referenced this pull request Jan 4, 2024
… list (opensearch-project#1695)

Signed-off-by: Darshit Chanpura <dchanp@amazon.com>
Co-authored-by: Stephen Crawford <65832608+scrawfor99@users.noreply.github.com>
(cherry picked from commit d64ee48)
Signed-off-by: Darshit Chanpura <dchanp@amazon.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
backport 2.x backport to 2.x branch v2.12.0 Items targeting 2.12.0
Projects
None yet
Development

Successfully merging this pull request may close these issues.

system:admin/system_index permission not visible in index-permissions drop down
5 participants