-
Notifications
You must be signed in to change notification settings - Fork 158
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Adds system index permission as allowed action under static drop down list #1695
Adds system index permission as allowed action under static drop down list #1695
Conversation
… list Signed-off-by: Darshit Chanpura <dchanp@amazon.com>
Signed-off-by: Darshit Chanpura <dchanp@amazon.com>
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #1695 +/- ##
=======================================
Coverage 67.09% 67.09%
=======================================
Files 94 94
Lines 2404 2404
Branches 318 318
=======================================
Hits 1613 1613
Misses 713 713
Partials 78 78 ☔ View full report in Codecov by Sentry. |
a89de8b
to
54b649f
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Do we want to separate out the two functionality? It seems like this is packaging the index permission with some of the admin:admin work, but I am generally ok with this as is
Its a relatively small change, and IMO is okay to merge. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Do we want to separate out the two functionality? It seems like this is packaging the index permission with some of the admin:admin work, but I am generally ok with this as is
Lets separate the permissions changes from the default password changes. The additional permissions option doesn't seem time sensitive and it would be good to make a clear PR / commit when we've been changing how passwords are handled.
9229cdb
to
12aad7c
Compare
… list (opensearch-project#1695) Signed-off-by: Darshit Chanpura <dchanp@amazon.com> Co-authored-by: Stephen Crawford <65832608+scrawfor99@users.noreply.github.com> (cherry picked from commit d64ee48) Signed-off-by: Darshit Chanpura <dchanp@amazon.com>
Description
At present, the allowed action
system:admin/system_index
is not visible in the static drop down list and hence is not available to be assigned to a role. This PR adds that capabilityCategory
Bug fix
Issues Resolved
system:admin/system_index
permission not visible in index-permissions drop down #1697Testing
Should be present in Index permissions:
Should not be present in cluster permissions:
Check List
- [ ] New functionality has been documentedBy submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.
For more information on following Developer Certificate of Origin and signing off your commits, please check here.