Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Backport 2.x] Add indices:data/read/search/template/render to cluster permissions dropdown #1732

Merged
merged 2 commits into from
Jan 18, 2024

Conversation

opensearch-trigger-bot[bot]
Copy link
Contributor

Backport 780b3aa from #1725

…ropdown (#1725)

Signed-off-by: Craig Perkins <cwperx@amazon.com>
(cherry picked from commit 780b3aa)
Copy link
Collaborator

@derek-ho derek-ho left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

Copy link

codecov bot commented Jan 11, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Comparison is base (46eee99) 66.76% compared to head (b0ac87b) 66.76%.

Additional details and impacted files
@@           Coverage Diff           @@
##              2.x    #1732   +/-   ##
=======================================
  Coverage   66.76%   66.76%           
=======================================
  Files          93       93           
  Lines        2353     2353           
  Branches      311      311           
=======================================
  Hits         1571     1571           
  Misses        705      705           
  Partials       77       77           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@peternied
Copy link
Member

@cwperks does your PR [1] fix this as this looks like a firefox issue, or is this something else that we might need to look into?

Cypress failed to make a connection to Firefox.

This usually indicates there was a problem opening the Firefox browser.

Error: could not find CRI target
    at lazyAssLogic (/home/runner/.cache/Cypress/9.5.4/Cypress/resources/app/node_modules/lazy-ass/index.js:110:14)
    at lazyAss (/home/runner/.cache/Cypress/9.5.4/Cypress/resources/app/node_modules/lazy-ass/index.js:115:28)
    at findStartPage (/home/runner/.cache/Cypress/9.5.4/Cypress/resources/app/packages/server/lib/browsers/protocol.js:56:28)
    at runMicrotasks (<anonymous>:null:null)
    at processTicksAndRejections (node:internal/process/task_queues:96:5)

@cwperks
Copy link
Member

cwperks commented Jan 11, 2024

@peternied Yes that PR will fix the failing checks

@DarshitChanpura DarshitChanpura merged commit 753c7de into 2.x Jan 18, 2024
24 checks passed
@github-actions github-actions bot deleted the backport/backport-1725-to-2.x branch January 18, 2024 15:41
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants