Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Adding @derek-ho as a maintainer #1758

Merged

Conversation

cwperks
Copy link
Member

@cwperks cwperks commented Jan 25, 2024

Description

@derek-ho has been an avid contributor to the security-dashboards-plugin repo since June '23 with 12 Pull Requests merged into main to date. Derek regularly engages on Pull Requests by giving other contributors valuable feedback, helps to maintain all release branches with critical bug fixes and ensuring dependencies are free of known security vulnerabilities, and contributes new features to the security-dashboards-plugin. Some of @derek-ho's notable contributions include:

Check List

  • New functionality includes testing
  • New functionality has been documented
  • Commits are signed per the DCO using --signoff

By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.
For more information on following Developer Certificate of Origin and signing off your commits, please check here.

Signed-off-by: Craig Perkins <cwperx@amazon.com>
Copy link
Collaborator

@derek-ho derek-ho left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🚢

Copy link

codecov bot commented Jan 25, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Comparison is base (d7d3c97) 67.09% compared to head (ecf6838) 67.09%.

Additional details and impacted files
@@           Coverage Diff           @@
##             main    #1758   +/-   ##
=======================================
  Coverage   67.09%   67.09%           
=======================================
  Files          94       94           
  Lines        2404     2404           
  Branches      318      318           
=======================================
  Hits         1613     1613           
  Misses        713      713           
  Partials       78       78           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Copy link

@davidlago davidlago left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🙌

@stephen-crawford stephen-crawford merged commit 00f647c into opensearch-project:main Jan 25, 2024
15 checks passed
stephen-crawford added a commit to stephen-crawford/security-dashboards-plugin that referenced this pull request Jan 26, 2024
Signed-off-by: Stephen Crawford <steecraw@amazon.com>
peternied pushed a commit that referenced this pull request Jan 26, 2024
Signed-off-by: Stephen Crawford <steecraw@amazon.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants