[Backport 2.x] Add JWT authentication type to MultipleAuthentication #2133
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
![opensearch-trigger-bot[bot]](https://avatars.githubusercontent.com/u/80134844?s=60&v=4){kind=small}
* Add JWT authentication type to MultipleAuthentication Signed-off-by: merlinz01 <na@notaccessible.xyz> * clarify comments in AuthenticationType.authHandler Signed-off-by: merlinz01 <na@notaccessible.xyz> * collect additional auth headers from all multi-auth handlers Signed-off-by: merlinz01 <na@notaccessible.xyz> * implement MultipleAuthentication.getCookie Signed-off-by: merlinz01 <na@notaccessible.xyz> * Add test for multiauth with JWT Signed-off-by: merlinz01 <na@notaccessible.xyz> * add explanatory comments in login page Signed-off-by: merlinz01 <na@notaccessible.xyz> * remove logging of JWT in test Signed-off-by: merlinz01 <na@notaccessible.xyz> * add check for empty auth options list in login page Signed-off-by: merlinz01 <na@notaccessible.xyz> * Add comments about getCookie method Signed-off-by: merlinz01 <na@notaccessible.xyz> * remove unneeded comment Signed-off-by: merlinz01 <na@notaccessible.xyz> * Don't load sample data in JWT multiauth test Signed-off-by: merlinz01 <na@notaccessible.xyz> * remove sample data code and unneeded promise handling Signed-off-by: merlinz01 <na@notaccessible.xyz> * update test for missing JWT Signed-off-by: merlinz01 <na@notaccessible.xyz> * ensure JWT signing key consistency Signed-off-by: merlinz01 <na@notaccessible.xyz> --------- Signed-off-by: merlinz01 <na@notaccessible.xyz> Co-authored-by: Derek Ho <dxho@amazon.com> (cherry picked from commit 252d8fb) Signed-off-by: github-actions[bot] <github-actions[bot]@users.noreply.github.com>
opensearch-trigger-bot
bot
requested review from
cliu123,
cwperks,
DarshitChanpura,
derek-ho and
RyanL1997
as code owners
derek-ho
approved these changes
Oct 7, 2024
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## 2.x #2133 +/- ##
==========================================
+ Coverage 71.40% 71.46% +0.05%
==========================================
Files 97 97
Lines 2651 2649 -2
Branches 411 403 -8
==========================================
Hits 1893 1893
+ Misses 642 641 -1
+ Partials 116 115 -1 ☔ View full report in Codecov by Sentry. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Backport 252d8fb from #2107.