-
Notifications
You must be signed in to change notification settings - Fork 274
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Bump Apache cxf from 4.0.4 to 4.0.5 #4578
Conversation
Signed-off-by: Craig Perkins <cwperx@amazon.com>
@@ -27,7 +27,7 @@ buildscript { | |||
common_utils_version = System.getProperty("common_utils.version", '3.0.0.0-SNAPSHOT') | |||
|
|||
kafka_version = '3.7.1' | |||
apache_cxf_version = '4.0.4' | |||
apache_cxf_version = '4.0.5' |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
nit: this might not be needed on newer versions after #3421
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Right, looks like cxf can be removed on the head of main and 2.x. The only references remaining are in CxfTestTools, but it appears that class is not used. Should we merge this PR and trigger that automatic backport process or specifically target 1.3 for this change?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I plan to close this PR and open a targeted one based on 1.3.
I opened a separate PR to remove CXF from main and 2.x since there's no longer any references that are used: #4580
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #4578 +/- ##
==========================================
+ Coverage 65.25% 65.28% +0.03%
==========================================
Files 317 317
Lines 22272 22272
Branches 3582 3582
==========================================
+ Hits 14534 14541 +7
+ Misses 5946 5939 -7
Partials 1792 1792 |
Description
Bump Apache cxf from 4.0.4 to 4.0.5
This new release contains a bugfix for an issue experienced in this repo: apache/cxf#1872
Maintenance
Issues Resolved
Check List
By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.
For more information on following Developer Certificate of Origin and signing off your commits, please check here.