Bump Apache cxf from 4.0.4 to 4.0.5 #4578
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Craig Perkins <cwperx@amazon.com>
cwperks
requested review from
cliu123,
DarshitChanpura,
peternied,
RyanL1997,
stephen-crawford,
reta and
willyborankin
as code owners
cwperks
added
backport 1.x
willyborankin
approved these changes
Jul 18, 2024
shikharj05
approved these changes
Jul 18, 2024
reta
approved these changes
Jul 18, 2024
shikharj05
reviewed
Jul 18, 2024
| @@ -27,7 +27,7 @@ buildscript { | |||
| common_utils_version = System.getProperty("common_utils.version", '3.0.0.0-SNAPSHOT') | |||
|
|
|||
| kafka_version = '3.7.1' | |||
| apache_cxf_version = '4.0.4' | |||
| apache_cxf_version = '4.0.5' | |||
There was a problem hiding this comment.
nit: this might not be needed on newer versions after #3421
There was a problem hiding this comment.
Right, looks like cxf can be removed on the head of main and 2.x. The only references remaining are in CxfTestTools, but it appears that class is not used. Should we merge this PR and trigger that automatic backport process or specifically target 1.3 for this change?
There was a problem hiding this comment.
I plan to close this PR and open a targeted one based on 1.3.
I opened a separate PR to remove CXF from main and 2.x since there's no longer any references that are used: #4580
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #4578 +/- ##
==========================================
+ Coverage 65.25% 65.28% +0.03%
==========================================
Files 317 317
Lines 22272 22272
Branches 3582 3582
==========================================
+ Hits 14534 14541 +7
+ Misses 5946 5939 -7
Partials 1792 1792 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Bump Apache cxf from 4.0.4 to 4.0.5
This new release contains a bugfix for an issue experienced in this repo: apache/cxf#1872
Maintenance
Issues Resolved
Check List
By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.
For more information on following Developer Certificate of Origin and signing off your commits, please check here.