Add verification job for OCPBUGS-112613 - #84191
Conversation
This job tests the aarch64 ISO checksum validation fix in a multi-arch bare metal deployment. It uses an AMD64 build host with ARM workers to trigger cross-arch ISO extraction where the checksum validation code runs. Job details: - Name: metal-ipi-ovn-ipv4-amd-ocpbugs-112613-verify - Type: Multi-arch (AMD64 + ARM) - Trigger: Manual only (always_run: false) - Workflow: baremetal-lab-ipi This verifies that the fix from openshift/machine-os-images#110 correctly validates checksums during real cluster deployment. Jira: https://issues.redhat.com/browse/OCPBUGS-112613
|
No actionable comments were generated in the recent review. 🎉 ℹ️ Recent review info⚙️ Run configurationConfiguration used: Repository YAML (base), Central YAML (inherited) Review profile: CHILL Plan: Pro Plus Run ID: ⛔ Files ignored due to path filters (1)
📒 Files selected for processing (1)
Included review availability: Your plan provides up to 2 included reviews per hour; 1 remains after this review. WalkthroughThe multi-nightly configuration renames the metal IPI verification job and schedules it at 16:54 on the 7th and 23rd of each month. Its workflow and test settings remain unchanged. ChangesMetal IPI verification
Estimated code review effort: 1 (Trivial) | ~2 minutes Merge Risk: ⚪ Minimal · up to The PR adds a manual verification job with matching generated configuration and schedule; no actionable merge-blocking risk remains beyond normal checks and review. Suggested reviewers: 🚥 Pre-merge checks | ✅ 15✅ Passed checks (15 passed)
Full details: Title checkExplanation The title clearly identifies the OCPBUGS-112613 verification job, which is the main subject of the changes. Although the changes also rename and schedule the job as a periodic test, the title remains accurate and sufficiently specific. Full details: Docstring CoverageExplanation No functions found in the changed files to evaluate docstring coverage. Skipping docstring coverage check. Docstring coverage is scoped to functions touched by this diff. Analyzed 0 functions across 0 files. (1 skipped: 1 unsupported.) Full details: Stable And Deterministic Test NamesExplanation PASS. The pull request changes only CI YAML and a generated Prow periodic-job declaration. The additions define the static job identifier Full details: Test Structure And QualityExplanation PASS: The pull request changes only CI YAML configuration and generated periodic-job YAML. The diff from the inferred base adds no Ginkgo test code, Full details: Microshift Test CompatibilityExplanation PASS: The pull request changes only CI configuration and a generated periodic-job manifest. It adds no Go files and no new Ginkgo declarations such as Full details: Single Node Openshift (Sno) Test CompatibilityExplanation PASS: The pull request adds and reschedules CI configuration only. The diff changes the multi-nightly YAML and generated periodic-job YAML; it adds no Ginkgo declarations or test source files. Therefore, the SNO compatibility check is not applicable. Full details: Topology-Aware Scheduling CompatibilityExplanation PASS. The pull request changes only ci-operator test configuration and generated Prow job YAML. The source change renames the test target and replaces Full details: Ote Binary Stdout ContractExplanation PASS — The pull request changes only two YAML CI configuration files. The diff adds and schedules a Full details: Ipv6 And Disconnected Network Test CompatibilityExplanation PASS: The pull request changes only CI YAML and generated Prow configuration. It adds or schedules a job that references the existing Full details: No-Weak-CryptoExplanation PASS. The PR changes only CI YAML job scheduling, naming, and generated periodic/presubmit configuration. The changed lines introduce no MD5, SHA1, DES, RC4, 3DES, Blowfish, ECB, custom crypto implementation, or non-constant-time secret/token comparison. The added secret and OAuth path references are CI credential wiring, not cryptographic usage. Full details: Container-PrivilegesExplanation PASS. The PR adds a periodic Prow job and changes its name and schedule. The full PR diff adds no Full details: No-Sensitive-Data-In-LogsExplanation PASS: The pull request adds no logging statement and no literal password, token, API key, PII, customer data, or hostname to log output. The source change only renames the job and replaces manual/optional fields with a cron schedule. Generated Prow changes move the existing job between presubmit and periodic configurations; secret references remain file paths and Kubernetes Secret names, not secret values. The existing ✨ Finishing Touches🧪 Generate unit tests (beta)
Comment |
|
[APPROVALNOTIFIER] This PR is NOT APPROVED This pull-request has been approved by: snaoum-lang The full list of commands accepted by this bot can be found here. DetailsNeeds approval from an approver in each of these files:
Approvers can indicate their approval by writing |
|
/test metal-ipi-ovn-ipv4-amd-ocpbugs-112613-verify |
|
@snaoum-lang: your |
|
/test multi-nightly-metal-ipi-ovn-ipv4-amd-ocpbugs-112613-verify |
|
/pj-rehearse pull-ci-openshift-openshift-tests-private-release-5.1-multi-nightly-metal-ipi-ovn-ipv4-amd-ocpbugs-112613-verify |
|
@snaoum-lang: now processing your pj-rehearse request. Please allow up to 10 minutes for jobs to trigger or cancel. |
|
/retest |
|
/pj-rehearse pull-ci-openshift-openshift-tests-private-release-5.1-multi-nightly-metal-ipi-ovn-ipv4-amd-ocpbugs-112613-verify |
|
@snaoum-lang: now processing your pj-rehearse request. Please allow up to 10 minutes for jobs to trigger or cancel. |
|
/test multi-nightly-metal-ipi-ovn-ipv4-amd-f7 |
|
@snaoum-lang: The specified target(s) for The following commands are available to trigger optional jobs: Use DetailsIn response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. |
A cron is required for prowgen to emit a periodic instead of a presubmit. Co-authored-by: Cursor <cursoragent@cursor.com>
|
[REHEARSALNOTIFIER]
Interacting with pj-rehearseComment: Once you are satisfied with the results of the rehearsals, comment: |
|
/pj-rehearse periodic-ci-openshift-openshift-tests-private-release-5.1-multi-nightly-metal-ipi-ovn-ipv4-amd-ocpbugs-112613-verify-f14 |
|
@snaoum-lang: now processing your pj-rehearse request. Please allow up to 10 minutes for jobs to trigger or cancel. |
|
@snaoum-lang: The following tests failed, say
Full PR test history. Your PR dashboard. DetailsInstructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. I understand the commands that are listed here. |
1 participant
Purpose
This PR adds a QA verification job for OCPBUGS-112613 to validate the aarch64 ISO checksum fix in a production-like multi-arch deployment.
Background
The fix from openshift/machine-os-images#110 adds SHA256 checksum validation for cross-architecture ISO extraction. This job verifies it works correctly during real cluster deployments.
Job Details
metal-ipi-ovn-ipv4-amd-ocpbugs-112613-verifyalways_run: false)baremetal-lab-ipiWhat This Tests
When deploying on AMD64 with ARM workers, the machine-os-images container extracts aarch64 ISOs and validates their checksums. This verifies:
References
Summary by CodeRabbit
baremetal-lab-ipiworkflow to deploy a multi-architecture cluster with an AMD64 build host and ARM workers.-f14variant with cron expression54 16 7,23 * *.