Add TLSAdherence periodics to testgrid allow-list as informing - #84196
Add TLSAdherence periodics to testgrid allow-list as informing#84196richardsonnick wants to merge 1 commit into
Conversation
The tls13-adherence periodics for 5.0 and 5.1 produce junit tagged [OCPFeatureGate:TLSAdherence] but are not on any testgrid dashboard, so sippy does not ingest them and the feature gate dashboard shows no promotion signal. Adding them to the allow-list puts them on the ocp-5.0/5.1 informing dashboards, which is the ingestion path sippy uses for repo periodics. Tier note: DPTP-5129 is still evaluating a candidate JobTier for this signal; informing is the initially requested tier and can be revisited. DPTP-5128 Co-Authored-By: Claude Fable 5 <noreply@anthropic.com> Claude-Session: https://claude.ai/code/session_01CcXcWcLYVhDzdq713dXt9e
|
No actionable comments were generated in the recent review. 🎉 ℹ️ Recent review info⚙️ Run configurationConfiguration used: Repository YAML (base), Central YAML (inherited) Review profile: CHILL Plan: Enterprise Run ID: 📒 Files selected for processing (1)
Included review availability: Your plan provides up to 12 included reviews per hour; 11 remain after this review. WalkthroughThe allow-list now includes eight informing TLS 1.3 adherence periodic jobs for TLS scanner releases 5.0 and 5.1 across default, Azure, GCP, and metal platforms. ChangesTLS scanner periodic jobs
Estimated code review effort: 1 (Trivial) | ~2 minutes Merge Risk: ⚪ Minimal · up to This localized change adds existing TLS adherence periodics to informing dashboards so their results can contribute to promotion signals; no actionable merge-blocking risk remains beyond normal checks and review. 🚥 Pre-merge checks | ✅ 15✅ Passed checks (15 passed)
Full details: Docstring CoverageExplanation No functions found in the changed files to evaluate docstring coverage. Skipping docstring coverage check. Docstring coverage is scoped to functions touched by this diff. Analyzed 0 functions across 0 files. (1 skipped: 1 unsupported.) Full details: Stable And Deterministic Test NamesExplanation PASS: The pull request changes only Full details: Test Structure And QualityExplanation PASS: The pull request changes only Full details: Microshift Test CompatibilityExplanation PASS: The pull request changes only Full details: Single Node Openshift (Sno) Test CompatibilityExplanation PASS: The pull request changes only Full details: Topology-Aware Scheduling CompatibilityExplanation PASS: The pull request changes only Full details: Ote Binary Stdout ContractExplanation PASS: The pull request changes only Full details: Ipv6 And Disconnected Network Test CompatibilityExplanation PASS — The pull request changes only Full details: No-Weak-CryptoExplanation PASS. The pull request changes only Full details: Container-PrivilegesExplanation PASS: The pull request changes only Full details: No-Sensitive-Data-In-LogsExplanation PASS: The pull request changes only ✨ Finishing Touches🧪 Generate unit tests (beta)
Comment |
|
[APPROVALNOTIFIER] This PR is NOT APPROVED This pull-request has been approved by: richardsonnick The full list of commands accepted by this bot can be found here. DetailsNeeds approval from an approver in each of these files:Approvers can indicate their approval by writing |
|
@richardsonnick: |
|
@richardsonnick: all tests passed! Full PR test history. Your PR dashboard. DetailsInstructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. I understand the commands that are listed here. |
The tls13-adherence periodics for 5.0 and 5.1 produce junit tagged [OCPFeatureGate:TLSAdherence] but are not on any testgrid dashboard, so sippy does not ingest them and the feature gate dashboard shows no promotion signal. Adding them to the allow-list puts them on the ocp-5.0/5.1 informing dashboards, which is the ingestion path sippy uses for repo periodics.
Summary by CodeRabbit
informingand assigns them to theocp-5.0andocp-5.1dashboards.OCPFeatureGate:TLSAdherencefeature gate.