Skip to content

Add TLSAdherence periodics to testgrid allow-list as informing - #84196

Open
richardsonnick wants to merge 1 commit into
openshift:mainfrom
richardsonnick:tls-adherence-testgrid
Open

Add TLSAdherence periodics to testgrid allow-list as informing#84196
richardsonnick wants to merge 1 commit into
openshift:mainfrom
richardsonnick:tls-adherence-testgrid

Conversation

@richardsonnick

@richardsonnick richardsonnick commented Aug 27, 2026

Copy link
Copy Markdown
Contributor

The tls13-adherence periodics for 5.0 and 5.1 produce junit tagged [OCPFeatureGate:TLSAdherence] but are not on any testgrid dashboard, so sippy does not ingest them and the feature gate dashboard shows no promotion signal. Adding them to the allow-list puts them on the ocp-5.0/5.1 informing dashboards, which is the ingestion path sippy uses for repo periodics.

Summary by CodeRabbit

  • Adds eight TLS 1.3 adherence periodic jobs for OpenShift 5.0 and 5.1 to the TestGrid allow-list.
  • Covers default, Azure, GCP, and metal test environments.
  • Classifies the jobs as informing and assigns them to the ocp-5.0 and ocp-5.1 dashboards.
  • Enables Sippy ingestion and promotion signals for the OCPFeatureGate:TLSAdherence feature gate.

The tls13-adherence periodics for 5.0 and 5.1 produce junit tagged
[OCPFeatureGate:TLSAdherence] but are not on any testgrid dashboard,
so sippy does not ingest them and the feature gate dashboard shows no
promotion signal. Adding them to the allow-list puts them on the
ocp-5.0/5.1 informing dashboards, which is the ingestion path sippy
uses for repo periodics.

Tier note: DPTP-5129 is still evaluating a candidate JobTier for this
signal; informing is the initially requested tier and can be revisited.

DPTP-5128

Co-Authored-By: Claude Fable 5 <noreply@anthropic.com>
Claude-Session: https://claude.ai/code/session_01CcXcWcLYVhDzdq713dXt9e
@coderabbitai

coderabbitai Bot commented Aug 27, 2026

Copy link
Copy Markdown
Contributor

No actionable comments were generated in the recent review. 🎉

ℹ️ Recent review info
⚙️ Run configuration

Configuration used: Repository YAML (base), Central YAML (inherited)

Review profile: CHILL

Plan: Enterprise

Run ID: 68f49440-c379-4902-bf11-7d080c7237e7

📥 Commits

Reviewing files that changed from the base of the PR and between 24fab75 and e96b59d.

📒 Files selected for processing (1)
  • core-services/testgrid-config-generator/_allow-list.yaml

Included review availability: Your plan provides up to 12 included reviews per hour; 11 remain after this review.


Walkthrough

The allow-list now includes eight informing TLS 1.3 adherence periodic jobs for TLS scanner releases 5.0 and 5.1 across default, Azure, GCP, and metal platforms.

Changes

TLS scanner periodic jobs

Layer / File(s) Summary
TLS 1.3 adherence allow-list entries
core-services/testgrid-config-generator/_allow-list.yaml
Adds informing entries for eight TLS scanner periodic jobs across releases 5.0 and 5.1 and the default, Azure, GCP, and metal platforms.

Estimated code review effort: 1 (Trivial) | ~2 minutes

Merge Risk: ⚪ Minimal · up to e96b5

This localized change adds existing TLS adherence periodics to informing dashboards so their results can contribute to promotion signals; no actionable merge-blocking risk remains beyond normal checks and review.

🚥 Pre-merge checks | ✅ 15
✅ Passed checks (15 passed)
Check name Status Explanation
Description Check ✅ Passed Check skipped - CodeRabbit’s high-level summary is enabled.
Title check ✅ Passed The title clearly and concisely describes the main change: adding TLSAdherence periodic jobs to the TestGrid allow-list as informing jobs.
Docstring Coverage ✅ Passed No functions found in the changed files to evaluate docstring coverage. Skipping docstring coverage check. Docstring coverage is scoped to functions touched by this diff. Analyzed 0 functions across 0…
Linked Issues check ✅ Passed Check skipped because no linked issues were found for this pull request.
Out of Scope Changes check ✅ Passed Check skipped because no linked issues were found for this pull request.
Stable And Deterministic Test Names ✅ Passed PASS: The pull request changes only _allow-list.yaml and adds eight static job-name mappings. The diff contains no Ginkgo test-title calls such as It(), Describe(), Context(), or When(). The…
Test Structure And Quality ✅ Passed PASS: The pull request changes only core-services/testgrid-config-generator/_allow-list.yaml, adding eight informing job entries. The diff contains no Ginkgo tests or other test code, so the listed …
Microshift Test Compatibility ✅ Passed PASS: The pull request changes only core-services/testgrid-config-generator/_allow-list.yaml and adds eight informing job entries. It adds no Ginkgo tests or other test code, so the MicroShift test …
Single Node Openshift (Sno) Test Compatibility ✅ Passed PASS: The pull request changes only core-services/testgrid-config-generator/_allow-list.yaml, adding eight existing TLS scanner periodic job names as informing. The diff contains no new Ginkgo sou…
Topology-Aware Scheduling Compatibility ✅ Passed PASS: The pull request changes only core-services/testgrid-config-generator/_allow-list.yaml. It adds eight TestGrid job allow-list entries with the informing tier. It does not add or modify deplo…
Ote Binary Stdout Contract ✅ Passed PASS: The pull request changes only core-services/testgrid-config-generator/_allow-list.yaml, adding eight informing entries. The exact diff contains no OTE source, process-level setup, logging, o…
Ipv6 And Disconnected Network Test Compatibility ✅ Passed PASS — The pull request changes only core-services/testgrid-config-generator/_allow-list.yaml and adds eight informing job entries. The exact diff contains no Go files or Ginkgo test declarations. T…
No-Weak-Crypto ✅ Passed PASS. The pull request changes only _allow-list.yaml and adds eight job names with informing values. The added lines contain no MD5, SHA1, DES, 3DES, RC4, Blowfish, or ECB usage, and they add no c…
Container-Privileges ✅ Passed PASS: The pull request changes only _allow-list.yaml by adding eight job-name-to-informing mappings. It adds no container or Kubernetes privilege fields. The related TLS scanner job manifests and …
No-Sensitive-Data-In-Logs ✅ Passed PASS: The pull request changes only core-services/testgrid-config-generator/_allow-list.yaml. The exact diff adds eight TestGrid job identifiers mapped to informing. It adds no logging code, log m…
Full details: Docstring Coverage

Explanation

No functions found in the changed files to evaluate docstring coverage. Skipping docstring coverage check. Docstring coverage is scoped to functions touched by this diff. Analyzed 0 functions across 0 files. (1 skipped: 1 unsupported.)

Full details: Stable And Deterministic Test Names

Explanation

PASS: The pull request changes only _allow-list.yaml and adds eight static job-name mappings. The diff contains no Ginkgo test-title calls such as It(), Describe(), Context(), or When(). The added release, provider, and architecture text is configuration data, not a dynamic test title.

Full details: Test Structure And Quality

Explanation

PASS: The pull request changes only core-services/testgrid-config-generator/_allow-list.yaml, adding eight informing job entries. The diff contains no Ginkgo tests or other test code, so the listed Ginkgo quality requirements do not apply.

Full details: Microshift Test Compatibility

Explanation

PASS: The pull request changes only core-services/testgrid-config-generator/_allow-list.yaml and adds eight informing job entries. It adds no Ginkgo tests or other test code, so the MicroShift test compatibility check does not apply.

Full details: Single Node Openshift (Sno) Test Compatibility

Explanation

PASS: The pull request changes only core-services/testgrid-config-generator/_allow-list.yaml, adding eight existing TLS scanner periodic job names as informing. The diff contains no new Ginkgo source or test declarations such as It(), Describe(), Context(), or When(). Therefore, the SNO test-compatibility failure condition does not apply.

Full details: Topology-Aware Scheduling Compatibility

Explanation

PASS: The pull request changes only core-services/testgrid-config-generator/_allow-list.yaml. It adds eight TestGrid job allow-list entries with the informing tier. It does not add or modify deployment manifests, operator code, controllers, replica settings, affinity, topology spread, node selectors, tolerations, or PDBs. The topology-aware scheduling check is therefore not applicable.

Full details: Ote Binary Stdout Contract

Explanation

PASS: The pull request changes only core-services/testgrid-config-generator/_allow-list.yaml, adding eight informing entries. The exact diff contains no OTE source, process-level setup, logging, or stdout writes. Therefore, this pull request does not introduce the stated stdout contract violation.

Full details: Ipv6 And Disconnected Network Test Compatibility

Explanation

PASS — The pull request changes only core-services/testgrid-config-generator/_allow-list.yaml and adds eight informing job entries. The exact diff contains no Go files or Ginkgo test declarations. Therefore, it introduces no test IPv4 assumption or external connectivity requirement covered by this check.

Full details: No-Weak-Crypto

Explanation

PASS. The pull request changes only _allow-list.yaml and adds eight job names with informing values. The added lines contain no MD5, SHA1, DES, 3DES, RC4, Blowfish, or ECB usage, and they add no crypto implementation or secret comparison. The referenced jobs and TLS scanner code are pre-existing and unchanged.

Full details: Container-Privileges

Explanation

PASS: The pull request changes only _allow-list.yaml by adding eight job-name-to-informing mappings. It adds no container or Kubernetes privilege fields. The related TLS scanner job manifests and scanner script are unchanged from the parent revision. Existing conditional privileged: true, hostPID, hostNetwork, and root settings are outside this pull request and therefore do not meet the required pull-request causality.

Full details: No-Sensitive-Data-In-Logs

Explanation

PASS: The pull request changes only core-services/testgrid-config-generator/_allow-list.yaml. The exact diff adds eight TestGrid job identifiers mapped to informing. It adds no logging code, log messages, credentials, tokens, personal data, hostnames, or customer data. The added identifiers contain only product, release, platform, and test names.

✨ Finishing Touches
🧪 Generate unit tests (beta)
  • Create PR with unit tests

Comment @coderabbitai help to get the list of available commands.

@openshift-ci

openshift-ci Bot commented Aug 27, 2026

Copy link
Copy Markdown
Contributor

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by: richardsonnick
Once this PR has been reviewed and has the lgtm label, please assign bear-redhat for approval. For more information see the Code Review Process.

The full list of commands accepted by this bot can be found here.

Details Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@openshift-merge-bot

Copy link
Copy Markdown
Contributor

@richardsonnick: pj-rehearse could not automatically process this event because the request waited in queue for longer than 5 minutes. Use /pj-rehearse to trigger rehearsals manually.

@openshift-ci

openshift-ci Bot commented Aug 27, 2026

Copy link
Copy Markdown
Contributor

@richardsonnick: all tests passed!

Full PR test history. Your PR dashboard.

Details

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. I understand the commands that are listed here.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant