checkconfig: revert to mismatched-tide-lenient warning exclusion - #84197
checkconfig: revert to mismatched-tide-lenient warning exclusion#84197redhat-chai-bot wants to merge 1 commit into
Conversation
Co-Authored-By: Claude Opus 4.6 <noreply@anthropic.com>
|
No actionable comments were generated in the recent review. 🎉 ℹ️ Recent review info⚙️ Run configurationConfiguration used: Repository YAML (base), Central YAML (inherited) Review profile: CHILL Plan: Pro Plus Run ID: ⛔ Files ignored due to path filters (1)
📒 Files selected for processing (1)
Included review availability: Your plan provides up to 2 included reviews per hour; 1 remains after this review. WalkthroughThe Makefile changes the ChangesCheckconfig warning handling
Estimated code review effort: 1 (Trivial) | ~2 minutes Merge Risk: ⚪ Minimal · up to This localized change restores the narrower warning exclusion in the build and presubmit configuration; no actionable merge-blocking risk remains beyond normal checks and review. Suggested reviewers: 🚥 Pre-merge checks | ✅ 15✅ Passed checks (15 passed)
Full details: Docstring CoverageExplanation No functions found in the changed files to evaluate docstring coverage. Skipping docstring coverage check. Docstring coverage is scoped to functions touched by this diff. Analyzed 0 functions across 0 files. (1 skipped: 1 unsupported.) Full details: Stable And Deterministic Test NamesExplanation PASS: The pull request changes only two checkconfig warning arguments in Full details: Test Structure And QualityExplanation PASS: The pull request changes only Full details: Microshift Test CompatibilityExplanation PASS: The pull request adds no Ginkgo e2e tests. The only changes are two warning-exclusion values in Makefile and the checkconfig presubmit YAML, from Full details: Single Node Openshift (Sno) Test CompatibilityExplanation PASS: The pull request changes only Full details: Topology-Aware Scheduling CompatibilityExplanation PASS: The pull request changes only the Full details: Ote Binary Stdout ContractExplanation PASS: The pull request changes only the Full details: Ipv6 And Disconnected Network Test CompatibilityExplanation PASS: The pull request changes only the Full details: No-Weak-CryptoExplanation PASS: The pull request changes only two checkconfig warning names: Full details: Container-PrivilegesExplanation The pull request changes only warning-exclusion values in Full details: No-Sensitive-Data-In-LogsExplanation The pull request changes only two ✨ Finishing Touches🧪 Generate unit tests (beta)
Comment |
|
[REHEARSALNOTIFIER]
Prior to this PR being merged, you will need to either run and acknowledge or opt to skip these rehearsals. Interacting with pj-rehearseComment: Once you are satisfied with the results of the rehearsals, comment: |
|
/pj-rehearse pull-ci-openshift-release-main-config |
|
@petr-muller: now processing your pj-rehearse request. Please allow up to 10 minutes for jobs to trigger or cancel. |
|
/pj-rehearse pull-ci-openshift-release-main-config AI-generated. Review for accuracy. |
|
@redhat-chai-bot: now processing your pj-rehearse request. Please allow up to 10 minutes for jobs to trigger or cancel. |
|
@redhat-chai-bot: all tests passed! Full PR test history. Your PR dashboard. DetailsInstructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. I understand the commands that are listed here. |
|
/pj-rehearse ack |
|
@petr-muller: now processing your pj-rehearse request. Please allow up to 10 minutes for jobs to trigger or cancel. |
|
[APPROVALNOTIFIER] This PR is NOT APPROVED This pull-request has been approved by: petr-muller, redhat-chai-bot The full list of commands accepted by this bot can be found here. DetailsNeeds approval from an approver in each of these files:Approvers can indicate their approval by writing |
Reverts the workaround from #83772, which broadened the checkconfig warning exclusion from
mismatched-tide-lenienttomismatched-tideto unblock #83764.Now that the upstream fix (kubernetes-sigs/prow#864) has landed via a recent prow bump, we can restore the stricter
mismatched-tide-lenientexclusion.Changes
--exclude-warning mismatched-tide→--exclude-warning mismatched-tide-lenient- mismatched-tide→- mismatched-tide-lenientAI-generated. Review for accuracy.
@petr-muller requested in Slack thread
Summary by CodeRabbit
mismatched-tide-lenientwarning exclusion in the OpenShift CI configuration.Makefileand the generated release presubmit job configuration.