Skip to content

checkconfig: revert to mismatched-tide-lenient warning exclusion - #84197

Open
redhat-chai-bot wants to merge 1 commit into
openshift:mainfrom
redhat-chai-bot:revert-checkconfig-lenient
Open

checkconfig: revert to mismatched-tide-lenient warning exclusion#84197
redhat-chai-bot wants to merge 1 commit into
openshift:mainfrom
redhat-chai-bot:revert-checkconfig-lenient

Conversation

@redhat-chai-bot

@redhat-chai-bot redhat-chai-bot commented Aug 27, 2026

Copy link
Copy Markdown
Contributor

Reverts the workaround from #83772, which broadened the checkconfig warning exclusion from mismatched-tide-lenient to mismatched-tide to unblock #83764.

Now that the upstream fix (kubernetes-sigs/prow#864) has landed via a recent prow bump, we can restore the stricter mismatched-tide-lenient exclusion.

Changes

  • Makefile: --exclude-warning mismatched-tide--exclude-warning mismatched-tide-lenient
  • ci-operator/jobs/.../openshift-release-main-presubmits.yaml: - mismatched-tide- mismatched-tide-lenient

AI-generated. Review for accuracy.

@petr-muller requested in Slack thread

Summary by CodeRabbit

  • Restores the stricter mismatched-tide-lenient warning exclusion in the OpenShift CI configuration.
  • Updates the Makefile and the generated release presubmit job configuration.
  • Allows stricter tide mismatch warnings after the upstream Prow fix became available.

Co-Authored-By: Claude Opus 4.6 <noreply@anthropic.com>
@coderabbitai

coderabbitai Bot commented Aug 27, 2026

Copy link
Copy Markdown
Contributor

No actionable comments were generated in the recent review. 🎉

ℹ️ Recent review info
⚙️ Run configuration

Configuration used: Repository YAML (base), Central YAML (inherited)

Review profile: CHILL

Plan: Pro Plus

Run ID: eda6965a-60ea-4b98-bb33-07225edeb4e7

📥 Commits

Reviewing files that changed from the base of the PR and between 24fab75 and 59f056f.

⛔ Files ignored due to path filters (1)
  • ci-operator/jobs/openshift/release/openshift-release-main-presubmits.yaml is excluded by !ci-operator/jobs/**
📒 Files selected for processing (1)
  • Makefile

Included review availability: Your plan provides up to 2 included reviews per hour; 1 remains after this review.


Walkthrough

The Makefile changes the checkconfig target to exclude mismatched-tide-lenient instead of mismatched-tide.

Changes

Checkconfig warning handling

Layer / File(s) Summary
Update excluded checkconfig warning
Makefile
The checkconfig container invocation now excludes mismatched-tide-lenient.

Estimated code review effort: 1 (Trivial) | ~2 minutes

Merge Risk: ⚪ Minimal · up to 59f05

This localized change restores the narrower warning exclusion in the build and presubmit configuration; no actionable merge-blocking risk remains beyond normal checks and review.

Suggested reviewers: openshift-bot

🚥 Pre-merge checks | ✅ 15
✅ Passed checks (15 passed)
Check name Status Explanation
Description Check ✅ Passed Check skipped - CodeRabbit’s high-level summary is enabled.
Title check ✅ Passed The title clearly and concisely describes the main change: restoring the exclusion of the mismatched-tide-lenient warning for checkconfig.
Docstring Coverage ✅ Passed No functions found in the changed files to evaluate docstring coverage. Skipping docstring coverage check. Docstring coverage is scoped to functions touched by this diff. Analyzed 0 functions across 0…
Linked Issues check ✅ Passed Check skipped because no linked issues were found for this pull request.
Out of Scope Changes check ✅ Passed Check skipped because no linked issues were found for this pull request.
Stable And Deterministic Test Names ✅ Passed PASS: The pull request changes only two checkconfig warning arguments in Makefile and openshift-release-main-presubmits.yaml. The diff contains no Ginkgo test declarations or test titles, and it i…
Test Structure And Quality ✅ Passed PASS: The pull request changes only Makefile and a presubmit YAML file. The exact diff changes mismatched-tide to mismatched-tide-lenient in two checkconfig configurations. It adds no Ginkgo tes…
Microshift Test Compatibility ✅ Passed PASS: The pull request adds no Ginkgo e2e tests. The only changes are two warning-exclusion values in Makefile and the checkconfig presubmit YAML, from mismatched-tide to mismatched-tide-lenient. …
Single Node Openshift (Sno) Test Compatibility ✅ Passed PASS: The pull request changes only Makefile and ci-operator/jobs/openshift/release/openshift-release-main-presubmits.yaml. The diff restores the mismatched-tide-lenient checkconfig warning excl…
Topology-Aware Scheduling Compatibility ✅ Passed PASS: The pull request changes only the checkconfig warning exclusion from mismatched-tide to mismatched-tide-lenient in the Makefile and one Prow presubmit job. The exact diff introduces no rep…
Ote Binary Stdout Contract ✅ Passed PASS: The pull request changes only the Makefile warning-exclusion argument and one checkconfig job YAML argument. The commit diff contains no OTE binary source, main() code, suite setup, logging …
Ipv6 And Disconnected Network Test Compatibility ✅ Passed PASS: The pull request changes only the checkconfig warning argument in Makefile and the matching generated job configuration. The diff adds no Ginkgo tests, e2e tests, test code, network addresse…
No-Weak-Crypto ✅ Passed PASS: The pull request changes only two checkconfig warning names: mismatched-tide to mismatched-tide-lenient in Makefile and the presubmit YAML. The exact diff introduces no MD5, SHA1, DES, 3DE…
Container-Privileges ✅ Passed The pull request changes only warning-exclusion values in Makefile and one Kubernetes job argument. The diff adds no privileged: true, host namespace settings, SYS_ADMIN, `allowPrivilegeEscalati…
No-Sensitive-Data-In-Logs ✅ Passed The pull request changes only two --exclude-warning values: mismatched-tide to mismatched-tide-lenient in the Makefile and the presubmit YAML. It adds no logging code or sensitive values. The ex…
Full details: Docstring Coverage

Explanation

No functions found in the changed files to evaluate docstring coverage. Skipping docstring coverage check. Docstring coverage is scoped to functions touched by this diff. Analyzed 0 functions across 0 files. (1 skipped: 1 unsupported.)

Full details: Stable And Deterministic Test Names

Explanation

PASS: The pull request changes only two checkconfig warning arguments in Makefile and openshift-release-main-presubmits.yaml. The diff contains no Ginkgo test declarations or test titles, and it introduces no dynamic test-name values.

Full details: Test Structure And Quality

Explanation

PASS: The pull request changes only Makefile and a presubmit YAML file. The exact diff changes mismatched-tide to mismatched-tide-lenient in two checkconfig configurations. It adds no Ginkgo test code, so the listed test-structure requirements do not apply.

Full details: Microshift Test Compatibility

Explanation

PASS: The pull request adds no Ginkgo e2e tests. The only changes are two warning-exclusion values in Makefile and the checkconfig presubmit YAML, from mismatched-tide to mismatched-tide-lenient. The MicroShift test-compatibility check is therefore not applicable.

Full details: Single Node Openshift (Sno) Test Compatibility

Explanation

PASS: The pull request changes only Makefile and ci-operator/jobs/openshift/release/openshift-release-main-presubmits.yaml. The diff restores the mismatched-tide-lenient checkconfig warning exclusion and adds no Ginkgo tests or test topology assumptions. The SNO compatibility check is therefore not applicable.

Full details: Topology-Aware Scheduling Compatibility

Explanation

PASS: The pull request changes only the checkconfig warning exclusion from mismatched-tide to mismatched-tide-lenient in the Makefile and one Prow presubmit job. The exact diff introduces no replicas, affinity, topology spread, node selector, toleration, or PDB settings. It introduces no topology-dependent scheduling constraint.

Full details: Ote Binary Stdout Contract

Explanation

PASS: The pull request changes only the Makefile warning-exclusion argument and one checkconfig job YAML argument. The commit diff contains no OTE binary source, main() code, suite setup, logging setup, or stdout write. The OTE Binary Stdout Contract is therefore not applicable.

Full details: Ipv6 And Disconnected Network Test Compatibility

Explanation

PASS: The pull request changes only the checkconfig warning argument in Makefile and the matching generated job configuration. The diff adds no Ginkgo tests, e2e tests, test code, network addresses, or external connectivity logic. The IPv6 and disconnected-network test compatibility check is therefore not applicable.

Full details: No-Weak-Crypto

Explanation

PASS: The pull request changes only two checkconfig warning names: mismatched-tide to mismatched-tide-lenient in Makefile and the presubmit YAML. The exact diff introduces no MD5, SHA1, DES, 3DES, RC4, Blowfish, ECB, custom crypto, or secret/token comparison logic.

Full details: Container-Privileges

Explanation

The pull request changes only warning-exclusion values in Makefile and one Kubernetes job argument. The diff adds no privileged: true, host namespace settings, SYS_ADMIN, allowPrivilegeEscalation: true, or root user configuration. The changed job container only shows arguments, image, secret volume, and resource requests.

Full details: No-Sensitive-Data-In-Logs

Explanation

The pull request changes only two --exclude-warning values: mismatched-tide to mismatched-tide-lenient in the Makefile and the presubmit YAML. It adds no logging code or sensitive values. The existing GitHub secret reference is unchanged. No explicit sensitive-data-in-logs failure condition is introduced.

✨ Finishing Touches
🧪 Generate unit tests (beta)
  • Create PR with unit tests

Comment @coderabbitai help to get the list of available commands.

@openshift-merge-bot

Copy link
Copy Markdown
Contributor

[REHEARSALNOTIFIER]
@redhat-chai-bot: the pj-rehearse plugin accommodates running rehearsal tests for the changes in this PR. Expand 'Interacting with pj-rehearse' for usage details. The following rehearsable tests have been affected by this change:

Test name Repo Type Reason
pull-ci-openshift-release-main-config openshift/release presubmit Presubmit changed

Prior to this PR being merged, you will need to either run and acknowledge or opt to skip these rehearsals.

Interacting with pj-rehearse

Comment: /pj-rehearse to run up to 5 rehearsals
Comment: /pj-rehearse skip to opt-out of rehearsals
Comment: /pj-rehearse {test-name}, with each test separated by a space, to run one or more specific rehearsals
Comment: /pj-rehearse more to run up to 10 rehearsals
Comment: /pj-rehearse max to run up to 25 rehearsals
Comment: /pj-rehearse auto-ack to run up to 5 rehearsals, and add the rehearsals-ack label on success
Comment: /pj-rehearse list to get an up-to-date list of affected jobs
Comment: /pj-rehearse abort to abort all active rehearsals
Comment: /pj-rehearse network-access-allowed to allow rehearsals of tests that have the restrict_network_access field set to false. This must be executed by an openshift org member who is not the PR author

Once you are satisfied with the results of the rehearsals, comment: /pj-rehearse ack to unblock merge. When the rehearsals-ack label is present on your PR, merge will no longer be blocked by rehearsals.
If you would like the rehearsals-ack label removed, comment: /pj-rehearse reject to re-block merging.

@petr-muller

Copy link
Copy Markdown
Member

/pj-rehearse pull-ci-openshift-release-main-config

@openshift-merge-bot

Copy link
Copy Markdown
Contributor

@petr-muller: now processing your pj-rehearse request. Please allow up to 10 minutes for jobs to trigger or cancel.

@redhat-chai-bot

Copy link
Copy Markdown
Contributor Author

/pj-rehearse pull-ci-openshift-release-main-config


AI-generated. Review for accuracy.

@openshift-merge-bot

Copy link
Copy Markdown
Contributor

@redhat-chai-bot: now processing your pj-rehearse request. Please allow up to 10 minutes for jobs to trigger or cancel.

@openshift-ci

openshift-ci Bot commented Aug 27, 2026

Copy link
Copy Markdown
Contributor

@redhat-chai-bot: all tests passed!

Full PR test history. Your PR dashboard.

Details

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. I understand the commands that are listed here.

@petr-muller

Copy link
Copy Markdown
Member

/pj-rehearse ack

@openshift-ci openshift-ci Bot added the lgtm Indicates that a PR is ready to be merged. label Aug 27, 2026
@openshift-merge-bot

Copy link
Copy Markdown
Contributor

@petr-muller: now processing your pj-rehearse request. Please allow up to 10 minutes for jobs to trigger or cancel.

@openshift-merge-bot openshift-merge-bot Bot added the rehearsals-ack Signifies that rehearsal jobs have been acknowledged label Aug 27, 2026
@openshift-ci

openshift-ci Bot commented Aug 27, 2026

Copy link
Copy Markdown
Contributor

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by: petr-muller, redhat-chai-bot
Once this PR has been reviewed and has the lgtm label, please assign droslean for approval. For more information see the Code Review Process.

The full list of commands accepted by this bot can be found here.

Details Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

lgtm Indicates that a PR is ready to be merged. rehearsals-ack Signifies that rehearsal jobs have been acknowledged

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants