Skip HyperShift-incompatible tests in serial-techpreview conformance - #84201
Skip HyperShift-incompatible tests in serial-techpreview conformance#84201redhat-chai-bot wants to merge 2 commits into
Conversation
5 IngressComponentRouteLabels tests and 1 ClusterUpdateAcceptRisks test are incompatible with HyperShift architecture. The IngressComponentRouteLabels tests attempt to modify Ingress resources directly on the guest cluster, which is blocked by ValidatingAdmissionPolicy (Ingress is managed via the HostedCluster CR). The ClusterUpdateAcceptRisks test expects ClusterVersion Update objects that are not reliably present in HyperShift. Tracks: OCPBUGS-114676 Co-Authored-By: Claude Opus 4.6 <noreply@anthropic.com>
|
No actionable comments were generated in the recent review. 🎉 ℹ️ Recent review info⚙️ Run configurationConfiguration used: Repository YAML (base), Central YAML (inherited) Review profile: CHILL Plan: Pro Plus Run ID: 📒 Files selected for processing (2)
🚧 Files skipped from review as they are similar to previous changes (1)
Included review availability: Your plan provides up to 2 included reviews per hour; 0 remain after this review. WalkthroughThe serial OVN conformance periodic jobs for Hypershift releases 5.0 and 5.1 now use the revised route-label propagation test name in ChangesHypershift conformance configuration
Estimated code review effort: 1 (Trivial) | ~2 minutes Merge Risk: ⚪ Minimal · up to This change only adds targeted skips for six HyperShift-incompatible conformance tests in the release 5.0 and 5.1 periodic jobs; no actionable merge-blocking risk remains. Suggested reviewers: 🚥 Pre-merge checks | ✅ 15✅ Passed checks (15 passed)
Full details: Docstring CoverageExplanation No functions found in the changed files to evaluate docstring coverage. Skipping docstring coverage check. Docstring coverage is scoped to functions touched by this diff. Analyzed 0 functions across 0 files. (2 skipped: 2 unsupported.) Full details: Stable And Deterministic Test NamesExplanation PASS. The full pull-request range changes only two YAML CI configuration files. It adds or updates static Full details: Test Structure And QualityExplanation PASS: The inferred PR range changes only two YAML periodic-job configuration files. It adds or updates Full details: Microshift Test CompatibilityExplanation PASS: The pull request changes only two YAML Full details: Single Node Openshift (Sno) Test CompatibilityExplanation PASS: The pull request changes only two HyperShift periodic YAML files. The diff adds or updates Full details: Topology-Aware Scheduling CompatibilityExplanation PASS: The pull request changes only two CI periodic-job YAML files. The diff adds Full details: Ote Binary Stdout ContractExplanation PASS: The full PR diff changes only two YAML configuration files. It adds a Full details: Ipv6 And Disconnected Network Test CompatibilityExplanation PASS: The pull request changes only Full details: No-Weak-CryptoExplanation PASS — The complete PR delta changes only two YAML files and adds two Full details: Container-PrivilegesExplanation PASS: The complete PR diff only adds Full details: No-Sensitive-Data-In-LogsExplanation PASS — The pull request only adds or updates ✨ Finishing Touches🧪 Generate unit tests (beta)
Comment |
|
[APPROVALNOTIFIER] This PR is NOT APPROVED This pull-request has been approved by: redhat-chai-bot The full list of commands accepted by this bot can be found here. DetailsNeeds approval from an approver in each of these files:Approvers can indicate their approval by writing |
|
/cc @sdminonne |
|
/pj-rehearse Triggering rehearsal to verify the TEST_SKIPS fix causes the serial-techpreview conformance jobs to pass. AI-generated. Review for accuracy. |
|
@redhat-chai-bot: now processing your pj-rehearse request. Please allow up to 10 minutes for jobs to trigger or cancel. |
|
/uncc |
…st names The previous pattern 'should propagate the route labels to' did not match the actual test names. The correct common prefix is 'Console operator route label propagation' which matches all 5 failing tests. Tracks: OCPBUGS-114676 Co-Authored-By: Claude Opus 4.6 <noreply@anthropic.com>
|
[REHEARSALNOTIFIER]
Interacting with pj-rehearseComment: Once you are satisfied with the results of the rehearsals, comment: |
|
@redhat-chai-bot: The following tests failed, say
Full PR test history. Your PR dashboard. DetailsInstructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. I understand the commands that are listed here. |
What
Add
TEST_SKIPSto thee2e-aws-ovn-conformance-serial-techpreviewperiodic jobs on release-5.0 and release-5.1 to skip 6 tests that are incompatible with HyperShift architecture.Why
These jobs are at 0% pass rate despite 99.2% of tests passing (2,182 total). Only 6 blocking test failures cause the entire job to fail:
5× IngressComponentRouteLabels (never passed — 0/30 on 5.0, 0/14 on 5.1):
These tests attempt to modify
ingresses.config.openshift.io/clusterdirectly on the guest cluster. In HyperShift, this is rejected byValidatingAdmissionPolicybecause Ingress is managed via the HostedCluster CR on the management cluster. They pass at 100% on standalone OCP.1× ClusterUpdateAcceptRisks (flake — 33% pass rate on 5.0, 36% on 5.1):
Expects ClusterVersion Update objects that are sometimes nil in HyperShift because cluster updates are managed through the HostedCluster CR. Passes at 100% on standalone OCP.
Skip patterns
should propagate the route labels tomatches all 5 IngressComponentRouteLabels variantsoc can operate accept risksmatches the ClusterUpdateAcceptRisks testTracks: OCPBUGS-114676
AI-generated. Review for accuracy.
@sdminonne requested in Slack thread
Summary by CodeRabbit
The OpenShift CI configuration updates the
e2e-aws-ovn-conformance-serial-techpreviewperiodic jobs for release-5.0 and release-5.1.The jobs now skip six HyperShift-incompatible tests: five
Console operator route label propagationvariants and oneoc can operate accept riskstest. This prevents failures caused by HyperShift-managed Ingress and cluster updates.