Skip to content

Skip HyperShift-incompatible tests in serial-techpreview conformance - #84201

Open
redhat-chai-bot wants to merge 2 commits into
openshift:mainfrom
redhat-chai-bot:add-test-skips-hypershift
Open

Skip HyperShift-incompatible tests in serial-techpreview conformance#84201
redhat-chai-bot wants to merge 2 commits into
openshift:mainfrom
redhat-chai-bot:add-test-skips-hypershift

Conversation

@redhat-chai-bot

@redhat-chai-bot redhat-chai-bot commented Aug 27, 2026

Copy link
Copy Markdown
Contributor

What

Add TEST_SKIPS to the e2e-aws-ovn-conformance-serial-techpreview periodic jobs on release-5.0 and release-5.1 to skip 6 tests that are incompatible with HyperShift architecture.

Why

These jobs are at 0% pass rate despite 99.2% of tests passing (2,182 total). Only 6 blocking test failures cause the entire job to fail:

5× IngressComponentRouteLabels (never passed — 0/30 on 5.0, 0/14 on 5.1):
These tests attempt to modify ingresses.config.openshift.io/cluster directly on the guest cluster. In HyperShift, this is rejected by ValidatingAdmissionPolicy because Ingress is managed via the HostedCluster CR on the management cluster. They pass at 100% on standalone OCP.

1× ClusterUpdateAcceptRisks (flake — 33% pass rate on 5.0, 36% on 5.1):
Expects ClusterVersion Update objects that are sometimes nil in HyperShift because cluster updates are managed through the HostedCluster CR. Passes at 100% on standalone OCP.

Skip patterns

TEST_SKIPS: should propagate the route labels to\| oc can operate accept risks
  • should propagate the route labels to matches all 5 IngressComponentRouteLabels variants
  • oc can operate accept risks matches the ClusterUpdateAcceptRisks test

Tracks: OCPBUGS-114676


AI-generated. Review for accuracy.

@sdminonne requested in Slack thread

Summary by CodeRabbit

The OpenShift CI configuration updates the e2e-aws-ovn-conformance-serial-techpreview periodic jobs for release-5.0 and release-5.1.

The jobs now skip six HyperShift-incompatible tests: five Console operator route label propagation variants and one oc can operate accept risks test. This prevents failures caused by HyperShift-managed Ingress and cluster updates.

5 IngressComponentRouteLabels tests and 1 ClusterUpdateAcceptRisks test
are incompatible with HyperShift architecture. The IngressComponentRouteLabels
tests attempt to modify Ingress resources directly on the guest cluster,
which is blocked by ValidatingAdmissionPolicy (Ingress is managed via
the HostedCluster CR). The ClusterUpdateAcceptRisks test expects
ClusterVersion Update objects that are not reliably present in HyperShift.

Tracks: OCPBUGS-114676

Co-Authored-By: Claude Opus 4.6 <noreply@anthropic.com>
@coderabbitai

coderabbitai Bot commented Aug 27, 2026

Copy link
Copy Markdown
Contributor

No actionable comments were generated in the recent review. 🎉

ℹ️ Recent review info
⚙️ Run configuration

Configuration used: Repository YAML (base), Central YAML (inherited)

Review profile: CHILL

Plan: Pro Plus

Run ID: 24b86296-bcbe-4059-9543-6a9fd1d65a54

📥 Commits

Reviewing files that changed from the base of the PR and between 0df44fe and 33df957.

📒 Files selected for processing (2)
  • ci-operator/config/openshift/hypershift/openshift-hypershift-release-5.0__periodics.yaml
  • ci-operator/config/openshift/hypershift/openshift-hypershift-release-5.1__periodics.yaml
🚧 Files skipped from review as they are similar to previous changes (1)
  • ci-operator/config/openshift/hypershift/openshift-hypershift-release-5.0__periodics.yaml

Included review availability: Your plan provides up to 2 included reviews per hour; 0 remain after this review.


Walkthrough

The serial OVN conformance periodic jobs for Hypershift releases 5.0 and 5.1 now use the revised route-label propagation test name in TEST_SKIPS and retain the existing risk-acceptance test skip.

Changes

Hypershift conformance configuration

Layer / File(s) Summary
Update serial conformance skips
ci-operator/config/openshift/hypershift/openshift-hypershift-release-5.0__periodics.yaml, ci-operator/config/openshift/hypershift/openshift-hypershift-release-5.1__periodics.yaml
The e2e-aws-ovn-conformance-serial-techpreview jobs replace should propagate the route labels to with Console operator route label propagation. They retain oc can operate accept risks.

Estimated code review effort: 1 (Trivial) | ~2 minutes

Merge Risk: ⚪ Minimal · up to 33df9

This change only adds targeted skips for six HyperShift-incompatible conformance tests in the release 5.0 and 5.1 periodic jobs; no actionable merge-blocking risk remains.

Suggested reviewers: sdminonne, dhgautam99

🚥 Pre-merge checks | ✅ 15
✅ Passed checks (15 passed)
Check name Status Explanation
Description Check ✅ Passed Check skipped - CodeRabbit’s high-level summary is enabled.
Title check ✅ Passed The title clearly and concisely describes the main change: skipping HyperShift-incompatible tests in serial-techpreview conformance jobs.
Docstring Coverage ✅ Passed No functions found in the changed files to evaluate docstring coverage. Skipping docstring coverage check. Docstring coverage is scoped to functions touched by this diff. Analyzed 0 functions across 0…
Linked Issues check ✅ Passed Check skipped because no linked issues were found for this pull request.
Out of Scope Changes check ✅ Passed Check skipped because no linked issues were found for this pull request.
Stable And Deterministic Test Names ✅ Passed PASS. The full pull-request range changes only two YAML CI configuration files. It adds or updates static TEST_SKIPS patterns and does not change any Ginkgo test declaration or test title. The added…
Test Structure And Quality ✅ Passed PASS: The inferred PR range changes only two YAML periodic-job configuration files. It adds or updates TEST_SKIPS under e2e-aws-ovn-conformance-serial-techpreview; it does not change Ginkgo test c…
Microshift Test Compatibility ✅ Passed PASS: The pull request changes only two YAML TEST_SKIPS values. The committed diff adds no Go files or Ginkgo test declarations such as It, Describe, Context, or When. Therefore, the MicroSh…
Single Node Openshift (Sno) Test Compatibility ✅ Passed PASS: The pull request changes only two HyperShift periodic YAML files. The diff adds or updates TEST_SKIPS values and contains no Go files or new Ginkgo declarations such as It, Describe, `Cont…
Topology-Aware Scheduling Compatibility ✅ Passed PASS: The pull request changes only two CI periodic-job YAML files. The diff adds TEST_SKIPS values and introduces no deployment manifests, operator code, controllers, or scheduling fields such as a…
Ote Binary Stdout Contract ✅ Passed PASS: The full PR diff changes only two YAML configuration files. It adds a TEST_SKIPS environment value to the e2e-aws-ovn-conformance-serial-techpreview jobs. It changes no OTE binary source, `m…
Ipv6 And Disconnected Network Test Compatibility ✅ Passed PASS: The pull request changes only TEST_SKIPS values in two periodic-job YAML files. The combined diff adds no Ginkgo test declarations or test networking code. Therefore, this check's IPv4 and dis…
No-Weak-Crypto ✅ Passed PASS — The complete PR delta changes only two YAML files and adds two TEST_SKIPS values. The added text contains only test-name skip patterns: Console operator route label propagation and `oc can …
Container-Privileges ✅ Passed PASS: The complete PR diff only adds TEST_SKIPS values to two CI periodic-job YAML files. No changed line introduces privileged: true, hostPID, hostNetwork, hostIPC, SYS_ADMIN, `allowPrivi…
No-Sensitive-Data-In-Logs ✅ Passed PASS — The pull request only adds or updates TEST_SKIPS literals in two periodic-job YAML files. The introduced values are test-name fragments: Console operator route label propagation and `oc can…
Full details: Docstring Coverage

Explanation

No functions found in the changed files to evaluate docstring coverage. Skipping docstring coverage check. Docstring coverage is scoped to functions touched by this diff. Analyzed 0 functions across 0 files. (2 skipped: 2 unsupported.)

Full details: Stable And Deterministic Test Names

Explanation

PASS. The full pull-request range changes only two YAML CI configuration files. It adds or updates static TEST_SKIPS patterns and does not change any Ginkgo test declaration or test title. The added text contains no dynamic values such as pod names, timestamps, UUIDs, node names, namespaces, or IP addresses.

Full details: Test Structure And Quality

Explanation

PASS: The inferred PR range changes only two YAML periodic-job configuration files. It adds or updates TEST_SKIPS under e2e-aws-ovn-conformance-serial-techpreview; it does not change Ginkgo test code, It blocks, resource setup or cleanup, waits, or assertions. Therefore the listed Ginkgo quality requirements are not applicable to this change.

Full details: Microshift Test Compatibility

Explanation

PASS: The pull request changes only two YAML TEST_SKIPS values. The committed diff adds no Go files or Ginkgo test declarations such as It, Describe, Context, or When. Therefore, the MicroShift Test Compatibility check is not applicable.

Full details: Single Node Openshift (Sno) Test Compatibility

Explanation

PASS: The pull request changes only two HyperShift periodic YAML files. The diff adds or updates TEST_SKIPS values and contains no Go files or new Ginkgo declarations such as It, Describe, Context, or When. Therefore, the SNO test-compatibility check is not applicable.

Full details: Topology-Aware Scheduling Compatibility

Explanation

PASS: The pull request changes only two CI periodic-job YAML files. The diff adds TEST_SKIPS values and introduces no deployment manifests, operator code, controllers, or scheduling fields such as affinity, topology spread, node selectors, tolerations, replicas, or PDBs. The topology-aware scheduling check is therefore not applicable.

Full details: Ote Binary Stdout Contract

Explanation

PASS: The full PR diff changes only two YAML configuration files. It adds a TEST_SKIPS environment value to the e2e-aws-ovn-conformance-serial-techpreview jobs. It changes no OTE binary source, main, suite setup, logging configuration, or stdout write. The custom check is therefore not violated.

Full details: Ipv6 And Disconnected Network Test Compatibility

Explanation

PASS: The pull request changes only TEST_SKIPS values in two periodic-job YAML files. The combined diff adds no Ginkgo test declarations or test networking code. Therefore, this check's IPv4 and disconnected-network conditions do not apply.

Full details: No-Weak-Crypto

Explanation

PASS — The complete PR delta changes only two YAML files and adds two TEST_SKIPS values. The added text contains only test-name skip patterns: Console operator route label propagation and oc can operate accept risks. No MD5, SHA1, DES, RC4, 3DES, Blowfish, ECB, custom cryptography, or secret/token comparisons were introduced.

Full details: Container-Privileges

Explanation

PASS: The complete PR diff only adds TEST_SKIPS values to two CI periodic-job YAML files. No changed line introduces privileged: true, hostPID, hostNetwork, hostIPC, SYS_ADMIN, allowPrivilegeEscalation: true, or root execution settings. The custom check therefore has no introduced failure condition.

Full details: No-Sensitive-Data-In-Logs

Explanation

PASS — The pull request only adds or updates TEST_SKIPS literals in two periodic-job YAML files. The introduced values are test-name fragments: Console operator route label propagation and oc can operate accept risks. They contain no passwords, tokens, API keys, PII, session IDs, internal hostnames, or customer data, and the diff adds no logging code.

✨ Finishing Touches
🧪 Generate unit tests (beta)
  • Create PR with unit tests

Comment @coderabbitai help to get the list of available commands.

@openshift-ci
openshift-ci Bot requested review from cblecker and dhgautam99 August 27, 2026 16:25
@openshift-ci

openshift-ci Bot commented Aug 27, 2026

Copy link
Copy Markdown
Contributor

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by: redhat-chai-bot
Once this PR has been reviewed and has the lgtm label, please assign bryan-cox for approval. For more information see the Code Review Process.

The full list of commands accepted by this bot can be found here.

Details Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@sdminonne

Copy link
Copy Markdown
Contributor

/cc @sdminonne

@openshift-ci
openshift-ci Bot requested a review from sdminonne August 27, 2026 16:37
@redhat-chai-bot

Copy link
Copy Markdown
Contributor Author

/pj-rehearse

Triggering rehearsal to verify the TEST_SKIPS fix causes the serial-techpreview conformance jobs to pass.


AI-generated. Review for accuracy.

@openshift-merge-bot

Copy link
Copy Markdown
Contributor

@redhat-chai-bot: now processing your pj-rehearse request. Please allow up to 10 minutes for jobs to trigger or cancel.

@cblecker

Copy link
Copy Markdown
Member

/uncc

@openshift-ci
openshift-ci Bot removed the request for review from cblecker August 27, 2026 20:20
…st names

The previous pattern 'should propagate the route labels to' did not match the
actual test names. The correct common prefix is 'Console operator route label
propagation' which matches all 5 failing tests.

Tracks: OCPBUGS-114676

Co-Authored-By: Claude Opus 4.6 <noreply@anthropic.com>
@openshift-merge-bot

Copy link
Copy Markdown
Contributor

[REHEARSALNOTIFIER]
@redhat-chai-bot: the pj-rehearse plugin accommodates running rehearsal tests for the changes in this PR. Expand 'Interacting with pj-rehearse' for usage details. The following rehearsable tests have been affected by this change:

Test name Repo Type Reason
periodic-ci-openshift-hypershift-release-5.1-periodics-e2e-aws-ovn-conformance-serial-techpreview N/A periodic Ci-operator config changed
periodic-ci-openshift-hypershift-release-5.0-periodics-e2e-aws-ovn-conformance-serial-techpreview N/A periodic Ci-operator config changed
Interacting with pj-rehearse

Comment: /pj-rehearse to run up to 5 rehearsals
Comment: /pj-rehearse skip to opt-out of rehearsals
Comment: /pj-rehearse {test-name}, with each test separated by a space, to run one or more specific rehearsals
Comment: /pj-rehearse more to run up to 10 rehearsals
Comment: /pj-rehearse max to run up to 25 rehearsals
Comment: /pj-rehearse auto-ack to run up to 5 rehearsals, and add the rehearsals-ack label on success
Comment: /pj-rehearse list to get an up-to-date list of affected jobs
Comment: /pj-rehearse abort to abort all active rehearsals
Comment: /pj-rehearse network-access-allowed to allow rehearsals of tests that have the restrict_network_access field set to false. This must be executed by an openshift org member who is not the PR author

Once you are satisfied with the results of the rehearsals, comment: /pj-rehearse ack to unblock merge. When the rehearsals-ack label is present on your PR, merge will no longer be blocked by rehearsals.
If you would like the rehearsals-ack label removed, comment: /pj-rehearse reject to re-block merging.

@openshift-ci

openshift-ci Bot commented Aug 27, 2026

Copy link
Copy Markdown
Contributor

@redhat-chai-bot: The following tests failed, say /retest to rerun all failed tests or /retest-required to rerun all mandatory failed tests:

Test name Commit Details Required Rerun command
ci/rehearse/periodic-ci-openshift-hypershift-release-5.0-periodics-e2e-aws-ovn-conformance-serial-techpreview 0df44fe link unknown /pj-rehearse periodic-ci-openshift-hypershift-release-5.0-periodics-e2e-aws-ovn-conformance-serial-techpreview
ci/rehearse/periodic-ci-openshift-hypershift-release-5.1-periodics-e2e-aws-ovn-conformance-serial-techpreview 0df44fe link unknown /pj-rehearse periodic-ci-openshift-hypershift-release-5.1-periodics-e2e-aws-ovn-conformance-serial-techpreview

Full PR test history. Your PR dashboard.

Details

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. I understand the commands that are listed here.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants