Skip to content

Remove retired Sippy Chat image - #84221

Open
not-stbenjam wants to merge 2 commits into
openshift:mainfrom
not-stbenjam:remove-sippy-chat-image
Open

Remove retired Sippy Chat image#84221
not-stbenjam wants to merge 2 commits into
openshift:mainfrom
not-stbenjam:remove-sippy-chat-image

Conversation

@not-stbenjam

@not-stbenjam not-stbenjam commented Aug 27, 2026

Copy link
Copy Markdown
Contributor

Removes the obsolete sippy-chat ci-operator image and its promotion exclusion after openshift/sippy#3964 removes the Sippy Chat service and source tree.

Validation: false || podman pull --platform linux quay.io/openshift/ci-public:ci_ci-operator-checkconfig_latest
bbec844967952042af0e898e1a5dd6a48a3c9c5fb9193082cb980e097b456cd9
podman run --platform linux --rm -v "/tmp/sippy-ci-release/ci-operator/config:/ci-operator/config:z" -v "/tmp/sippy-ci-release/ci-operator/step-registry:/ci-operator/step-registry:z" -v "/tmp/sippy-ci-release/ci-operator/step-registry/cluster-profiles:/ci-operator/step-registry/cluster-profiles:z" -v "/tmp/sippy-ci-release/core-services/cluster-pools:/core-services/cluster-pools:z" quay.io/openshift/ci-public:ci_ci-operator-checkconfig_latest --config-dir /ci-operator/config --registry /ci-operator/step-registry --cluster-profiles-config /ci-operator/step-registry/cluster-profiles/cluster-profiles-config.yaml --cluster-claim-owners-config /core-services/cluster-pools/_config.yaml

Summary by CodeRabbit

  • Removes the obsolete sippy-chat image from the Sippy CI build configuration.
  • Removes sippy-chat from the promotion exclusion list.
  • Keeps OpenShift CI configuration aligned with the removed Sippy Chat service and source tree.
  • Includes ci-operator configuration validation.

@openshift-ci openshift-ci Bot added the needs-ok-to-test Indicates a PR that requires an org member to verify it is safe to test. label Aug 27, 2026
@openshift-ci

openshift-ci Bot commented Aug 27, 2026

Copy link
Copy Markdown
Contributor

Hi @not-stbenjam. Thanks for your PR.

I'm waiting for a openshift member to verify that this patch is reasonable to test. If it is, they should reply with /ok-to-test on its own line. Until that is done, I will not automatically test new commits in this PR, but the usual testing commands by org members will still work.

Tip

We noticed you've done this a few times! Consider joining the org to skip this step and gain /lgtm and other bot rights. We recommend asking approvers on your previous PRs to sponsor you.

Once the patch is verified, the new status will be reflected by the ok-to-test label.

I understand the commands that are listed here.

Details

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.

@coderabbitai

coderabbitai Bot commented Aug 27, 2026

Copy link
Copy Markdown
Contributor

Important

Review skipped

Review was skipped due to path filters

⛔ Files ignored due to path filters (2)
  • ci-operator/jobs/openshift/sippy/openshift-sippy-main-postsubmits.yaml is excluded by !ci-operator/jobs/**
  • ci-operator/jobs/openshift/sippy/openshift-sippy-main-presubmits.yaml is excluded by !ci-operator/jobs/**

CodeRabbit blocks several paths by default. You can override this behavior by explicitly including those paths in the path filters. For example, including **/dist/** will override the default block on the dist directory, by removing the pattern from both the lists.

⚙️ Run configuration

Configuration used: Repository YAML (base), Central YAML (inherited)

Review profile: CHILL

Plan: Pro Plus

Run ID: f02e30c5-74db-41a2-867a-35a5f569591e

You can disable this status message by setting the reviews.review_status to false in the CodeRabbit configuration file.

Use the checkbox below for a quick retry:

  • 🔍 Trigger review

No actionable comments were generated in the recent review. 🎉

ℹ️ Recent review info
⚙️ Run configuration

Configuration used: Repository YAML (base), Central YAML (inherited)

Review profile: CHILL

Plan: Pro Plus

Run ID: 8c610f71-d9d8-4dfb-abf1-9a1adb2ed093

📥 Commits

Reviewing files that changed from the base of the PR and between 899b2a6 and f180881.

📒 Files selected for processing (1)
  • ci-operator/config/openshift/sippy/openshift-sippy-main.yaml
💤 Files with no reviewable changes (1)
  • ci-operator/config/openshift/sippy/openshift-sippy-main.yaml

Included review availability: Your plan provides up to 2 included reviews per hour; 1 remains after this review.


Walkthrough

The Sippy CI configuration removes the sippy-chat image from image builds and promotion exclusions.

Changes

Sippy image configuration

Layer / File(s) Summary
Remove sippy-chat configuration
ci-operator/config/openshift/sippy/openshift-sippy-main.yaml
The configuration no longer builds sippy-chat or excludes it during promotion.

Estimated code review effort: 1 (Trivial) | ~2 minutes

Merge Risk: ⚪ Minimal · up to f1808

This removes an obsolete image and its promotion exclusion in a single configuration file; no actionable merge-blocking risk remains after normal checks and review.

🚥 Pre-merge checks | ✅ 15
✅ Passed checks (15 passed)
Check name Status Explanation
Description Check ✅ Passed Check skipped - CodeRabbit’s high-level summary is enabled.
Title check ✅ Passed The title clearly and concisely describes the removal of the retired sippy-chat image, which is the main change in the pull request.
Docstring Coverage ✅ Passed No functions found in the changed files to evaluate docstring coverage. Skipping docstring coverage check. Docstring coverage is scoped to functions touched by this diff. Analyzed 0 functions across 0…
Linked Issues check ✅ Passed Check skipped because no linked issues were found for this pull request.
Out of Scope Changes check ✅ Passed Check skipped because no linked issues were found for this pull request.
Stable And Deterministic Test Names ✅ Passed PASS — The pull request changes only ci-operator/config/openshift/sippy/openshift-sippy-main.yaml. The diff removes the obsolete sippy-chat image and promotion exclusion. It does not add or modify…
Test Structure And Quality ✅ Passed PASS: The pull request changes only ci-operator/config/openshift/sippy/openshift-sippy-main.yaml, removing the retired sippy-chat image and promotion exclusion. The commit changes no Ginkgo test f…
Microshift Test Compatibility ✅ Passed PASS: The pull request changes only ci-operator/config/openshift/sippy/openshift-sippy-main.yaml. It removes the obsolete sippy-chat image and promotion entry. The commit adds no Ginkgo e2e tests …
Single Node Openshift (Sno) Test Compatibility ✅ Passed The pull request changes only ci-operator/config/openshift/sippy/openshift-sippy-main.yaml. It removes the obsolete sippy-chat image and promotion exclusion. No Go, Ginkgo, or e2e test files were …
Topology-Aware Scheduling Compatibility ✅ Passed PASS: The pull request changes only ci-operator/config/openshift/sippy/openshift-sippy-main.yaml. The diff removes the sippy-chat image entry and its promotion exclusion. It does not add or modify…
Ote Binary Stdout Contract ✅ Passed PASS: The pull request changes only ci-operator/config/openshift/sippy/openshift-sippy-main.yaml. It removes the sippy-chat image entry and promotion exclusion. It does not change OTE binaries, su…
Ipv6 And Disconnected Network Test Compatibility ✅ Passed PASS: The pull request changes only ci-operator/config/openshift/sippy/openshift-sippy-main.yaml. The diff removes the obsolete sippy-chat image and promotion exclusion. It adds no Ginkgo e2e test…
No-Weak-Crypto ✅ Passed PASS. The pull request changes only one YAML file and removes the obsolete sippy-chat image and promotion exclusion. It adds no crypto usage, custom crypto implementation, or secret/token comparison…
Container-Privileges ✅ Passed PASS: The pull request changes only ci-operator/config/openshift/sippy/openshift-sippy-main.yaml and removes four lines. The diff removes the sippy-chat image and promotion exclusion. It adds no `…
No-Sensitive-Data-In-Logs ✅ Passed PASS — The pull request changes only ci-operator/config/openshift/sippy/openshift-sippy-main.yaml and removes four obsolete YAML lines. The commit adds no lines and introduces no logging statements …
Full details: Docstring Coverage

Explanation

No functions found in the changed files to evaluate docstring coverage. Skipping docstring coverage check. Docstring coverage is scoped to functions touched by this diff. Analyzed 0 functions across 0 files.

Full details: Stable And Deterministic Test Names

Explanation

PASS — The pull request changes only ci-operator/config/openshift/sippy/openshift-sippy-main.yaml. The diff removes the obsolete sippy-chat image and promotion exclusion. It does not add or modify Ginkgo tests or test titles, so it introduces no unstable or overly specific test name.

Full details: Test Structure And Quality

Explanation

PASS: The pull request changes only ci-operator/config/openshift/sippy/openshift-sippy-main.yaml, removing the retired sippy-chat image and promotion exclusion. The commit changes no Ginkgo test files or test code, so the listed Ginkgo quality requirements are not applicable.

Full details: Microshift Test Compatibility

Explanation

PASS: The pull request changes only ci-operator/config/openshift/sippy/openshift-sippy-main.yaml. It removes the obsolete sippy-chat image and promotion entry. The commit adds no Ginkgo e2e tests or test code, so the MicroShift API compatibility check does not apply.

Full details: Single Node Openshift (Sno) Test Compatibility

Explanation

The pull request changes only ci-operator/config/openshift/sippy/openshift-sippy-main.yaml. It removes the obsolete sippy-chat image and promotion exclusion. No Go, Ginkgo, or e2e test files were added or modified, so the SNO compatibility check is not applicable.

Full details: Topology-Aware Scheduling Compatibility

Explanation

PASS: The pull request changes only ci-operator/config/openshift/sippy/openshift-sippy-main.yaml. The diff removes the sippy-chat image entry and its promotion exclusion. It does not add or modify deployment manifests, operator code, controllers, replicas, affinity, topology spread, node selectors, tolerations, or PDBs. The topology-aware scheduling check is therefore not applicable.

Full details: Ote Binary Stdout Contract

Explanation

PASS: The pull request changes only ci-operator/config/openshift/sippy/openshift-sippy-main.yaml. It removes the sippy-chat image entry and promotion exclusion. It does not change OTE binaries, suite setup, or any process-level stdout behavior.

Full details: Ipv6 And Disconnected Network Test Compatibility

Explanation

PASS: The pull request changes only ci-operator/config/openshift/sippy/openshift-sippy-main.yaml. The diff removes the obsolete sippy-chat image and promotion exclusion. It adds no Ginkgo e2e tests, IPv4 assumptions, or external connectivity requirements.

Full details: No-Weak-Crypto

Explanation

PASS. The pull request changes only one YAML file and removes the obsolete sippy-chat image and promotion exclusion. It adds no crypto usage, custom crypto implementation, or secret/token comparison. The added-line check found no listed weak-crypto indicator.

Full details: Container-Privileges

Explanation

PASS: The pull request changes only ci-operator/config/openshift/sippy/openshift-sippy-main.yaml and removes four lines. The diff removes the sippy-chat image and promotion exclusion. It adds no privileged, host namespace, SYS_ADMIN, root-runtime, or allowPrivilegeEscalation: true settings.

Full details: No-Sensitive-Data-In-Logs

Explanation

PASS — The pull request changes only ci-operator/config/openshift/sippy/openshift-sippy-main.yaml and removes four obsolete YAML lines. The commit adds no lines and introduces no logging statements or sensitive-data output. No passwords, tokens, API keys, PII, session IDs, hostnames, or customer data are added to logs.

✨ Finishing Touches
🧪 Generate unit tests (beta)
  • Create PR with unit tests

Comment @coderabbitai help to get the list of available commands.

@stbenjam

Copy link
Copy Markdown
Member

/ok-to-test

@openshift-ci openshift-ci Bot added ok-to-test Indicates a non-member PR verified by an org member that is safe to test. and removed needs-ok-to-test Indicates a PR that requires an org member to verify it is safe to test. labels Aug 27, 2026
@openshift-ci

openshift-ci Bot commented Aug 27, 2026

Copy link
Copy Markdown
Contributor

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by: not-stbenjam
Once this PR has been reviewed and has the lgtm label, please assign dgoodwin for approval. For more information see the Code Review Process.

The full list of commands accepted by this bot can be found here.

Details Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@openshift-merge-bot

Copy link
Copy Markdown
Contributor

[REHEARSALNOTIFIER]
@not-stbenjam: the pj-rehearse plugin accommodates running rehearsal tests for the changes in this PR. Expand 'Interacting with pj-rehearse' for usage details. The following rehearsable tests have been affected by this change:

Test name Repo Type Reason
pull-ci-openshift-sippy-main-agentic-images openshift/sippy presubmit Ci-operator config changed
pull-ci-openshift-sippy-main-agentic-staging openshift/sippy presubmit Ci-operator config changed
pull-ci-openshift-sippy-main-build openshift/sippy presubmit Ci-operator config changed
pull-ci-openshift-sippy-main-e2e openshift/sippy presubmit Ci-operator config changed
pull-ci-openshift-sippy-main-images openshift/sippy presubmit Ci-operator config changed
pull-ci-openshift-sippy-main-integration openshift/sippy presubmit Ci-operator config changed
pull-ci-openshift-sippy-main-lint openshift/sippy presubmit Ci-operator config changed
pull-ci-openshift-sippy-main-security openshift/sippy presubmit Ci-operator config changed
pull-ci-openshift-sippy-main-unit openshift/sippy presubmit Ci-operator config changed
pull-ci-openshift-sippy-main-verify openshift/sippy presubmit Ci-operator config changed
pull-ci-openshift-sippy-main-yaml-lint openshift/sippy presubmit Ci-operator config changed
periodic-ci-openshift-sippy-main-agentic-periodic-sippy-pr-followup-agent N/A periodic Ci-operator config changed
periodic-ci-openshift-sippy-main-agentic-periodic-sippy-jira-agent N/A periodic Ci-operator config changed
Interacting with pj-rehearse

Comment: /pj-rehearse to run up to 5 rehearsals
Comment: /pj-rehearse skip to opt-out of rehearsals
Comment: /pj-rehearse {test-name}, with each test separated by a space, to run one or more specific rehearsals
Comment: /pj-rehearse more to run up to 10 rehearsals
Comment: /pj-rehearse max to run up to 25 rehearsals
Comment: /pj-rehearse auto-ack to run up to 5 rehearsals, and add the rehearsals-ack label on success
Comment: /pj-rehearse list to get an up-to-date list of affected jobs
Comment: /pj-rehearse abort to abort all active rehearsals
Comment: /pj-rehearse network-access-allowed to allow rehearsals of tests that have the restrict_network_access field set to false. This must be executed by an openshift org member who is not the PR author

Once you are satisfied with the results of the rehearsals, comment: /pj-rehearse ack to unblock merge. When the rehearsals-ack label is present on your PR, merge will no longer be blocked by rehearsals.
If you would like the rehearsals-ack label removed, comment: /pj-rehearse reject to re-block merging.

@openshift-ci

openshift-ci Bot commented Aug 27, 2026

Copy link
Copy Markdown
Contributor

@not-stbenjam: all tests passed!

Full PR test history. Your PR dashboard.

Details

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. I understand the commands that are listed here.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

ok-to-test Indicates a non-member PR verified by an org member that is safe to test.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants