NE-2507: update CI jobs to add secrets

[rhamini3]

This PR is updating the standard cloud e2e and gatewayapi conformance tests to inject the required pull secrets and apply the correct source policies to run with the pre-release OSSM images

dependent on openshift/cluster-ingress-operator#1567

Summary by CodeRabbit

• Updates standard cloud end-to-end and Gateway API conformance CI tests for openshift/cluster-ingress-operator.
• Runs test-pre-release-ossm before the existing tests.
• Mounts OSSM credentials and exports token, Brew, and staging secrets.
• Applies the source policies required to run prerelease OSSM images.
• Depends on openshift/cluster-ingress-operator#1567.

[openshift-ci-robot]

@rhamini3: This pull request references NE-2507 which is a valid jira issue.

Warning: The referenced jira issue has an invalid target version for the target branch this PR targets: expected the epic to target the "5.1.0" version, but no target version was set.

Details

In response to this:

This PR is updating the standard cloud e2e and gatewayapi conformance tests to inject the required pull secrets and apply the correct source policies to run with the pre-release OSSM images

dependent on openshift/cluster-ingress-operator#1567

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository.

[rhamini3]

/pj-rehearse

[openshift-merge-bot]

@rhamini3: now processing your pj-rehearse request. Please allow up to 10 minutes for jobs to trigger or cancel.

[coderabbitai]

No actionable comments were generated in the recent review. 🎉

ℹ️ Recent review info

⚙️ Run configuration

Configuration used: Repository YAML (base), Central YAML (inherited)

Review profile: CHILL

Plan: Enterprise

Run ID: c476f1a5-52a2-4140-b8fe-52459a5acb81

📥 Commits

Reviewing files that changed from the base of the PR and between 899b2a6 and 9888169.

📒 Files selected for processing (1)

• ci-operator/config/openshift/cluster-ingress-operator/openshift-cluster-ingress-operator-master.yaml

Included review availability: Your plan provides up to 12 included reviews per hour; 10 remain after this review.

---

Walkthrough

Four test configurations now mount OSSM credentials, export related token, Brew, and staging secrets, and run test-pre-release-ossm before their existing operator or Gateway API conformance tests.

Changes

OSSM pre-release test integration

Layer / File(s)	Summary
Operator test credential and execution updates ci-operator/config/openshift/cluster-ingress-operator/openshift-cluster-ingress-operator-master.yaml	AWS, GCP, and Azure operator tests mount test-credentials, export OSSM variables, and run test-pre-release-ossm before test-e2e.
Gateway API conformance test updates ci-operator/config/openshift/cluster-ingress-operator/openshift-cluster-ingress-operator-master.yaml	The AWS Gateway API conformance test mounts test-credentials, exports OSSM variables, and runs test-pre-release-ossm before gatewayapi-conformance.

Estimated code review effort: 2 (Simple) | ~10 minutes

Merge Risk: ⚪ Minimal · up to 98881

This PR updates a single CI configuration for pull secrets and source policies; no actionable merge-blocking risk remains based on the supplied evidence.

Suggested reviewers: gcs278, enxebre, deepsm007

🚥 Pre-merge checks | ✅ 15

✅ Passed checks (15 passed)

Check name	Status	Explanation
Description Check	✅ Passed	Check skipped - CodeRabbit’s high-level summary is enabled.
Title check	✅ Passed	The title accurately summarizes the main change: updating CI jobs to add required secrets. It is concise and specific, although it does not mention the related prerelease OSSM configuration.
Docstring Coverage	✅ Passed	No functions found in the changed files to evaluate docstring coverage. Skipping docstring coverage check. Docstring coverage is scoped to functions touched by this diff. Analyzed 0 functions across 0…
Linked Issues check	✅ Passed	Check skipped because no linked issues were found for this pull request.
Out of Scope Changes check	✅ Passed	Check skipped because no linked issues were found for this pull request.
Stable And Deterministic Test Names	✅ Passed	PASS. The pull request changes only one CI YAML file. The diff adds static CI command steps, credential mounts, and environment-variable exports for four jobs. It does not add or modify any Ginkgo `It…
Test Structure And Quality	✅ Passed	PASS: The pull request changes only one CI YAML file. The diff updates command steps and mounts OSSM credentials; it does not add or modify Ginkgo It blocks, setup or cleanup hooks, waits, or assert…
Microshift Test Compatibility	✅ Passed	PASS: The pull request changes only one CI YAML file. The parent-to-HEAD diff adds credentials and runs existing test-pre-release-ossm, test-e2e, and gatewayapi-conformance commands. It adds no …
Single Node Openshift (Sno) Test Compatibility	✅ Passed	The pull request changes only one CI YAML file. The committed diff adds credentials and shell commands that run existing make test-e2e and make gatewayapi-conformance targets. It adds no Go files …
Topology-Aware Scheduling Compatibility	✅ Passed	PASS. The PR changes only one CI YAML file. The added lines export OSSM credentials, mount a secret, and run existing test targets. The diff adds no deployment manifests, operator/controller code, rep…
Ote Binary Stdout Contract	✅ Passed	PASS: The pull request changes one YAML CI configuration file only. Its added lines export credentials and invoke make test-pre-release-ossm before existing tests; they do not add or modify OTE bina…
Ipv6 And Disconnected Network Test Compatibility	✅ Passed	PASS — The pull request changes one CI YAML file only. It adds no Ginkgo test code and introduces no IPv4 literals, IP parsing, URLs, public hostnames, or registry endpoints. The added OSSM credential…
No-Weak-Crypto	✅ Passed	PASS: The pull request changes one CI YAML file. The added lines only read mounted credential files, export variables, invoke existing test targets, and declare a credential mount. The parent-to-HEAD …
Container-Privileges	✅ Passed	The pull request adds command exports, make test-pre-release-ossm, make test-e2e, make gatewayapi-conformance, and credential mounts. It does not add privileged, hostPID, hostNetwork, `hos…
No-Sensitive-Data-In-Logs	✅ Passed	No sensitive-data logging was introduced. The committed diff changes only one CI YAML file and adds secret-file reads plus environment exports for TOKEN, AUTHBREW, and AUTHSTAGE; it does not pri…

Full details: Docstring Coverage

Explanation

No functions found in the changed files to evaluate docstring coverage. Skipping docstring coverage check. Docstring coverage is scoped to functions touched by this diff. Analyzed 0 functions across 0 files. (1 skipped: 1 unsupported.)

Full details: Stable And Deterministic Test Names

Explanation

PASS. The pull request changes only one CI YAML file. The diff adds static CI command steps, credential mounts, and environment-variable exports for four jobs. It does not add or modify any Ginkgo It, Describe, Context, or When test title. The CI identifiers remain static strings, and the changed commands place credential values in shell setup rather than test titles.

Full details: Test Structure And Quality

Explanation

PASS: The pull request changes only one CI YAML file. The diff updates command steps and mounts OSSM credentials; it does not add or modify Ginkgo It blocks, setup or cleanup hooks, waits, or assertions. Therefore, none of the stated Ginkgo test quality failure conditions apply.

Full details: Microshift Test Compatibility

Explanation

PASS: The pull request changes only one CI YAML file. The parent-to-HEAD diff adds credentials and runs existing test-pre-release-ossm, test-e2e, and gatewayapi-conformance commands. It adds no Ginkgo tests (It, Describe, Context, or When) and introduces no MicroShift API or feature references. The MicroShift compatibility check is therefore not applicable.

Full details: Single Node Openshift (Sno) Test Compatibility

Explanation

The pull request changes only one CI YAML file. The committed diff adds credentials and shell commands that run existing make test-e2e and make gatewayapi-conformance targets. It adds no Go files or Ginkgo declarations such as It(), Describe(), Context(), or When(). Therefore, the SNO test-compatibility check is not applicable.

Full details: Topology-Aware Scheduling Compatibility

Explanation

PASS. The PR changes only one CI YAML file. The added lines export OSSM credentials, mount a secret, and run existing test targets. The diff adds no deployment manifests, operator/controller code, replica settings, affinity, topology spread, node selectors, tolerations, or PDBs. Therefore it introduces no scheduling constraint covered by this check.

Full details: Ote Binary Stdout Contract

Explanation

PASS: The pull request changes one YAML CI configuration file only. Its added lines export credentials and invoke make test-pre-release-ossm before existing tests; they do not add or modify OTE binary code, suite setup, logging, or stdout writes. The referenced Makefile target runs a shell setup script, not an OTE binary. The changed content contains no main, init, TestMain, Ginkgo suite setup, klog, fmt.Print, or logging calls. Therefore, the explicit OTE Binary Stdout Contract failure condition is not introduced.

Full details: Ipv6 And Disconnected Network Test Compatibility

Explanation

PASS — The pull request changes one CI YAML file only. It adds no Ginkgo test code and introduces no IPv4 literals, IP parsing, URLs, public hostnames, or registry endpoints. The added OSSM credentials and make test-pre-release-ossm commands do not themselves match an explicit failure condition.

Full details: No-Weak-Crypto

Explanation

PASS: The pull request changes one CI YAML file. The added lines only read mounted credential files, export variables, invoke existing test targets, and declare a credential mount. The parent-to-HEAD diff contains no MD5, SHA1, DES, 3DES, RC4, Blowfish, or ECB usage, custom crypto implementation, or secret/token comparison. The existing make test-e2e and make gatewayapi-conformance commands were not changed in substance.

Full details: Container-Privileges

Explanation

The pull request adds command exports, make test-pre-release-ossm, make test-e2e, make gatewayapi-conformance, and credential mounts. It does not add privileged, hostPID, hostNetwork, hostIPC, SYS_ADMIN, allowPrivilegeEscalation, or a security context that runs as root. The existing capabilities: intranet entries are unchanged and are not SYS_ADMIN. No explicit custom-check failure condition is introduced.

Full details: No-Sensitive-Data-In-Logs

Explanation

No sensitive-data logging was introduced. The committed diff changes only one CI YAML file and adds secret-file reads plus environment exports for TOKEN, AUTHBREW, and AUTHSTAGE; it does not print their values. The dependent OSSM script uses echo "${AUTHBREW}" and echo "${AUTHSTAGE}" with output redirected to temporary files, and it has no shell tracing. A source scan found no other logging use of these variables.

✨ Finishing Touches

🧪 Generate unit tests (beta)

• Create PR with unit tests

---

_{Comment @coderabbitai help to get the list of available commands.}

[openshift-ci]

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by: rhamini3
Once this PR has been reviewed and has the lgtm label, please assign knobunc for approval. For more information see the Code Review Process.

The full list of commands accepted by this bot can be found here.

Details

Needs approval from an approver in each of these files:

• ci-operator/config/openshift/cluster-ingress-operator/OWNERS

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

[openshift-merge-bot]

[REHEARSALNOTIFIER]
@rhamini3: the pj-rehearse plugin accommodates running rehearsal tests for the changes in this PR. Expand 'Interacting with pj-rehearse' for usage details. The following rehearsable tests have been affected by this change:

Test name	Repo	Type	Reason
pull-ci-openshift-cluster-ingress-operator-master-e2e-aws-gatewayapi-conformance	openshift/cluster-ingress-operator	presubmit	Ci-operator config changed
pull-ci-openshift-cluster-ingress-operator-master-e2e-aws-operator	openshift/cluster-ingress-operator	presubmit	Ci-operator config changed
pull-ci-openshift-cluster-ingress-operator-master-e2e-azure-operator	openshift/cluster-ingress-operator	presubmit	Ci-operator config changed
pull-ci-openshift-cluster-ingress-operator-master-e2e-gcp-operator	openshift/cluster-ingress-operator	presubmit	Ci-operator config changed

Prior to this PR being merged, you will need to either run and acknowledge or opt to skip these rehearsals.

Interacting with pj-rehearse

Comment: /pj-rehearse to run up to 5 rehearsals
Comment: /pj-rehearse skip to opt-out of rehearsals
Comment: /pj-rehearse {test-name}, with each test separated by a space, to run one or more specific rehearsals
Comment: /pj-rehearse more to run up to 10 rehearsals
Comment: /pj-rehearse max to run up to 25 rehearsals
Comment: /pj-rehearse auto-ack to run up to 5 rehearsals, and add the rehearsals-ack label on success
Comment: /pj-rehearse list to get an up-to-date list of affected jobs
Comment: /pj-rehearse abort to abort all active rehearsals
Comment: /pj-rehearse network-access-allowed to allow rehearsals of tests that have the restrict_network_access field set to false. This must be executed by an openshift org member who is not the PR author

Once you are satisfied with the results of the rehearsals, comment: /pj-rehearse ack to unblock merge. When the rehearsals-ack label is present on your PR, merge will no longer be blocked by rehearsals.
If you would like the rehearsals-ack label removed, comment: /pj-rehearse reject to re-block merging.

[openshift-ci]

@rhamini3: The following tests failed, say /retest to rerun all failed tests or /retest-required to rerun all mandatory failed tests:

Test name	Commit	Details	Required	Rerun command
ci/rehearse/openshift/cluster-ingress-operator/master/e2e-azure-operator	9888169	link	unknown	/pj-rehearse pull-ci-openshift-cluster-ingress-operator-master-e2e-azure-operator
ci/rehearse/openshift/cluster-ingress-operator/master/e2e-aws-operator	9888169	link	unknown	/pj-rehearse pull-ci-openshift-cluster-ingress-operator-master-e2e-aws-operator
ci/rehearse/openshift/cluster-ingress-operator/master/e2e-gcp-operator	9888169	link	unknown	/pj-rehearse pull-ci-openshift-cluster-ingress-operator-master-e2e-gcp-operator
ci/rehearse/openshift/cluster-ingress-operator/master/e2e-aws-gatewayapi-conformance	9888169	link	unknown	/pj-rehearse pull-ci-openshift-cluster-ingress-operator-master-e2e-aws-gatewayapi-conformance

Full PR test history. Your PR dashboard.

Details

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. I understand the commands that are listed here.