Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Added progress indicator on Insight Screen #3484

Open
wants to merge 8 commits into
base: main
Choose a base branch
from
Open

Added progress indicator on Insight Screen #3484

wants to merge 8 commits into from

Conversation

aurangzaibumer
Copy link
Contributor

@aurangzaibumer aurangzaibumer commented Sep 6, 2024

added progress indicator while quering/fetching the data on insight screen

IMPORTANT: Where possible all PRs must be linked to a Github issue

Fixes #3476

Engineer Checklist

  • I have written Unit tests for any new feature(s) and edge cases for bug fixes
  • I have added any strings visible on UI components to the strings.xml file
  • I have updated the CHANGELOG.md file for any notable changes to the codebase
  • I have run ./gradlew spotlessApply and ./gradlew spotlessCheck to check my code follows the project's style guide
  • I have built and run the FHIRCore app to verify my change fixes the issue and/or does not break the app
  • I have checked that this PR does NOT introduce breaking changes that require an update to Content and/or Configs? If it does add a sample here or a link to exactly what changes need to be made to the content.

Code Reviewer Checklist

  • I have verified Unit tests have been written for any new feature(s) and edge cases
  • I have verified any strings visible on UI components are in the strings.xml file
  • I have verifed the CHANGELOG.md file has any notable changes to the codebase
  • I have verified the solution has been implemented in a configurable and generic way for reuseable components
  • I have built and run the FHIRCore app to verify the change fixes the issue and/or does not break the app

@aurangzaibumer aurangzaibumer self-assigned this Sep 6, 2024
@aurangzaibumer aurangzaibumer changed the title added progress indicator while quering/fetching the data on insight s… Added progress indicator on Insight Screen Sep 6, 2024
Copy link

codecov bot commented Sep 6, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 27.7%. Comparing base (6fc15b0) to head (d4be994).

Additional details and impacted files

Impacted file tree graph

@@            Coverage Diff            @@
##              main   #3484     +/-   ##
=========================================
+ Coverage     27.1%   27.7%   +0.5%     
  Complexity     775     775             
=========================================
  Files          279     279             
  Lines        14563   14244    -319     
  Branches      2608    2543     -65     
=========================================
- Hits          3957    3953      -4     
+ Misses       10065    9752    -313     
+ Partials       541     539      -2     
Flag Coverage Δ
engine 63.7% <ø> (ø)
geowidget 16.0% <ø> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

Files with missing lines Coverage Δ
.../quest/ui/usersetting/UserInsightScreenFragment.kt 43.4% <ø> (ø)
...e/quest/ui/usersetting/UserSettingInsightScreen.kt 17.6% <ø> (+<0.1%) ⬆️
...fhircore/quest/ui/usersetting/UserSettingScreen.kt 2.2% <ø> (ø)

... and 15 files with indirect coverage changes

@ndegwamartin
Copy link
Contributor

@aurangzaibumer tested the update it still doesn't seem to work, check out the recording below:

Screen_recording_20240919_194616.webm

@aurangzaibumer
Copy link
Contributor Author

3476.mp4

I have created some household members in a family and recorded this.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Insights view not rendering correct unsynced records status on initial load
3 participants