Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add service method for mapping resources to extracted values string #3572

Merged
merged 2 commits into from
Oct 24, 2024

Conversation

Rkareko
Copy link
Contributor

@Rkareko Rkareko commented Oct 23, 2024

IMPORTANT: Where possible all PRs must be linked to a Github issue

Fixes [link to issue]

Engineer Checklist

  • I have written Unit tests for any new feature(s) and edge cases for bug fixes
  • I have added any strings visible on UI components to the strings.xml file
  • I have updated the CHANGELOG.md file for any notable changes to the codebase
  • I have run ./gradlew spotlessApply and ./gradlew spotlessCheck to check my code follows the project's style guide
  • I have built and run the FHIRCore app to verify my change fixes the issue and/or does not break the app
  • I have checked that this PR does NOT introduce breaking changes that require an update to Content and/or Configs? If it does add a sample here or a link to exactly what changes need to be made to the content.

Code Reviewer Checklist

  • I have verified Unit tests have been written for any new feature(s) and edge cases
  • I have verified any strings visible on UI components are in the strings.xml file
  • I have verifed the CHANGELOG.md file has any notable changes to the codebase
  • I have verified the solution has been implemented in a configurable and generic way for reuseable components
  • I have built and run the FHIRCore app to verify the change fixes the issue and/or does not break the app

@Rkareko Rkareko self-assigned this Oct 23, 2024
Copy link

codecov bot commented Oct 23, 2024

Codecov Report

Attention: Patch coverage is 77.77778% with 2 lines in your changes missing coverage. Please review.

Project coverage is 27.3%. Comparing base (36808ea) to head (ebf49cf).
Report is 1 commits behind head on main.

Files with missing lines Patch % Lines
...gister/fhircore/engine/rulesengine/RulesFactory.kt 77.7% 2 Missing ⚠️
Additional details and impacted files

Impacted file tree graph

@@           Coverage Diff           @@
##              main   #3572   +/-   ##
=======================================
  Coverage     27.2%   27.3%           
  Complexity     775     775           
=======================================
  Files          278     278           
  Lines        14425   14434    +9     
  Branches      2591    2592    +1     
=======================================
+ Hits          3932    3942   +10     
+ Misses        9955    9953    -2     
- Partials       538     539    +1     
Flag Coverage Δ
engine 63.8% <77.7%> (+<0.1%) ⬆️
geowidget 15.4% <ø> (ø)
quest 5.8% <ø> (+<0.1%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

Files with missing lines Coverage Δ
...gister/fhircore/engine/rulesengine/RulesFactory.kt 67.5% <77.7%> (+0.3%) ⬆️

... and 1 file with indirect coverage changes

@Rkareko Rkareko marked this pull request as ready for review October 24, 2024 06:31
@Rkareko Rkareko requested review from ellykits and LZRS October 24, 2024 06:31
Comment on lines +573 to +579
* This function combines all the string values retrieved from the [resources] using the
* [fhirPathExpression] to a list separated by the [separator]
*
* e.g for a provided list of Patients we can extract a string containing the family names using
* the [Patient.name.family] as the [fhirpathExpression] and [ | ] as the [separator] the
* returned string would be [John | Jane | James]
*/
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice! Well documented.

@Rkareko Rkareko added this pull request to the merge queue Oct 24, 2024
@Rkareko Rkareko removed this pull request from the merge queue due to a manual request Oct 24, 2024
@Rkareko Rkareko merged commit 64a55e6 into main Oct 24, 2024
5 checks passed
@Rkareko Rkareko deleted the map-resources-to-extracted-values-string branch October 24, 2024 09:40
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants