QGPSDDevice: tell gpsd to send nmea data

[z3ntu]

The initialization sequence is not valid anymore since gpsd 2.91, so
update the command for gpsd to send data.
Otherwise no data will be received by Merkaartor from gpsd.

Tested with gpsd 3.18.1

[Krakonos]

Thanks! Do you have a way to test it without an actual GPS device supported by gpsd? I know they have some simulation tool, but I was unable to make it work last time I touched it.

Anyway, the place you put it is probably wrong. Two issues: at the time this call gets executed, the link may not be established yet. I'm not sure what happens in that case. Second issue is that onLinkReady function is called as soon as the link is established, and might get mixed up (or at least change the order) with this call. Perhaps the correct place to put it is into the onLinkReady?

[z3ntu]

I tested this with a real device connected via ssh port forwarding.

As for what happens if the link isn't established, according to the documentation, the call returns -1 if an error occurred.

I have to say that file is really confusing to read with all the ifdefs in there.. Anyways, it seems that in both instances of QGPSDDevice::onLinkReady there are already some Server->write or Server->stream statements that probably should do something...

[Krakonos]

Yes, it's a mess. It actually seems we could replace this completely with QtPositioning, see #169 . There even seems to be a gpsd plugin, so we might not loose any functionality at all.

[Krakonos]

Hi!
Would you mind updating the PR and moving the call into onLinkReady function? I'd like to merge this PR for 0.18.4 and do the release soon.

Thanks.

[z3ntu]

I believe I made the requested changes. It should work in theory but I haven't tested it yet. If you want, I can test it tomorrow

[z3ntu]

Updated and confirmed working with gpsd 3.18.1.

[Krakonos]

Thanks, merged.