Configurable ImageIO output format #318
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
![github-advanced-security[bot]](https://avatars.githubusercontent.com/in/57789?s=60&v=4){kind=small}
There was a problem hiding this comment.
Flawfinder found more than 10 potential problems in the proposed changes. Check the Files changed tab for more details.
|
Alright @motiejus, let me know if this works for you. Thanks! |
|
It works wonderfully! I use renderd with go_tile, PR there for webp: nielsole/go_tile#13 |
|
Note the footgun described in nielsole/go_tile#13 (comment) : it will return only the image that has been configured. I will use both webp and png256, but these will be under different renderd maps. It would be useful to document it. Ah, it is documented and is status quo already. Nevermind! |
…string. For instance: TYPE=png image/png TYPE=png image/png png256 TYPE=png image/png png24 TYPE=png image/png png
Added documentation for output format.
hummeltech
force-pushed
the
feature-configurableOutputFormat
branch
from
5d7cfd1
to
517aab3
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Replaces #191 (thanks @timautin!) as it has been inactive for @ 2.3 years:
Also added additional tests for various image output formats:
TYPE=jpg image/jpeg jpegTYPE=png image/png png256TYPE=png image/png png32TYPE=webp image/webp webpCloses #64
Closes #301