-
Notifications
You must be signed in to change notification settings - Fork 165
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[CI] Enable genai_package tests for debug build #832
base: master
Are you sure you want to change the base?
[CI] Enable genai_package tests for debug build #832
Conversation
The second place I referred to that needs to be enabled is https://github.com/openvinotoolkit/openvino.genai/pull/602/files#diff-4aa4c95372c9c357ede241a7e2e9333fcd514f275d9f96cd04bd1b6a7887431bL116. When it moved to The corresponding build logs in this PR don't have any output for both: Release and Debug debug builds. Can you check why there's no generated text for them? |
run: | | ||
. "${{ env.OV_INSTALL_DIR }}/setupvars.ps1" | ||
cmake --install ./build/ --config ${{ matrix.build-type }} --prefix ${{ env.OV_INSTALL_DIR }} | ||
call "${{ env.OV_INSTALL_DIR }}\setupvars.bat" |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
why did you revert the powershell?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
See #832 (comment)
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
There is no output for Test C++ samples (greedy_causal_lm) step on Windows, but it exists for other OSes.
The suggestion was that there might be some linking issues on Windows but PowerShell command succeeds or does not print anything. I tried to switch to cmd to check it.
Let's try to update tokenizers. |
97dd18d
to
029e018
Compare
run: | | ||
. "${{ env.OV_INSTALL_DIR }}/setupvars.ps1" | ||
call "${{ env.OV_INSTALL_DIR }}\setupvars.bat" | ||
python ${{ env.OV_INSTALL_DIR }}\samples\python\multinomial_causal_lm\multinomial_causal_lm.py TinyLlama-1.1B-Chat-v1.0 0 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
we don't have debug python API for OpenVINO
. "${{ env.OV_INSTALL_DIR }}/setupvars.ps1" | ||
Start-Process -FilePath "${{ github.workspace }}/samples_install/samples_bin/greedy_causal_lm.exe" -ArgumentList "TinyLlama-1.1B-Chat-v1.0 ''" | ||
call "${{ env.OV_INSTALL_DIR }}\setupvars.bat" | ||
start "" "${{ github.workspace }}\samples_install\samples_bin\greedy_causal_lm.exe" "TinyLlama-1.1B-Chat-v1.0" "" |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
BTW, I don't see any output from this sample. Is it run?
No description provided.