Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[CI] Enable genai_package tests for debug build #832

Open
wants to merge 4 commits into
base: master
Choose a base branch
from

Conversation

yatarkan
Copy link
Contributor

@yatarkan yatarkan commented Sep 5, 2024

No description provided.

@github-actions github-actions bot added the category: llm_bench Label for tool/llm_bench folder label Sep 5, 2024
@yatarkan yatarkan changed the base branch from master to releases/2024/4 September 5, 2024 17:44
@yatarkan yatarkan removed the category: llm_bench Label for tool/llm_bench folder label Sep 5, 2024
@Wovchena
Copy link
Collaborator

Wovchena commented Sep 6, 2024

The second place I referred to that needs to be enabled is https://github.com/openvinotoolkit/openvino.genai/pull/602/files#diff-4aa4c95372c9c357ede241a7e2e9333fcd514f275d9f96cd04bd1b6a7887431bL116. When it moved to windows.yml, it was already enabled. Strangely it passed back then.

The corresponding build logs in this PR don't have any output for both: Release and Debug debug builds. Can you check why there's no generated text for them?

@ilya-lavrenov ilya-lavrenov marked this pull request as ready for review September 6, 2024 19:31
@ilya-lavrenov ilya-lavrenov added this to the 2024.4 milestone Sep 7, 2024
run: |
. "${{ env.OV_INSTALL_DIR }}/setupvars.ps1"
cmake --install ./build/ --config ${{ matrix.build-type }} --prefix ${{ env.OV_INSTALL_DIR }}
call "${{ env.OV_INSTALL_DIR }}\setupvars.bat"
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

why did you revert the powershell?

Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

There is no output for Test C++ samples (greedy_causal_lm) step on Windows, but it exists for other OSes.
The suggestion was that there might be some linking issues on Windows but PowerShell command succeeds or does not print anything. I tried to switch to cmd to check it.

@Wovchena Wovchena mentioned this pull request Sep 10, 2024
@ilya-lavrenov
Copy link
Contributor

Let's try to update tokenizers.
Fixes for debug build were merged

@yatarkan yatarkan changed the base branch from releases/2024/4 to master September 13, 2024 08:04
@yatarkan yatarkan changed the base branch from master to releases/2024/4 September 13, 2024 08:04
@yatarkan yatarkan force-pushed the yt/enable-genai-package-debug-tests branch from 97dd18d to 029e018 Compare September 13, 2024 09:11
@yatarkan yatarkan changed the base branch from releases/2024/4 to master September 13, 2024 09:12
run: |
. "${{ env.OV_INSTALL_DIR }}/setupvars.ps1"
call "${{ env.OV_INSTALL_DIR }}\setupvars.bat"
python ${{ env.OV_INSTALL_DIR }}\samples\python\multinomial_causal_lm\multinomial_causal_lm.py TinyLlama-1.1B-Chat-v1.0 0
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

we don't have debug python API for OpenVINO

. "${{ env.OV_INSTALL_DIR }}/setupvars.ps1"
Start-Process -FilePath "${{ github.workspace }}/samples_install/samples_bin/greedy_causal_lm.exe" -ArgumentList "TinyLlama-1.1B-Chat-v1.0 ''"
call "${{ env.OV_INSTALL_DIR }}\setupvars.bat"
start "" "${{ github.workspace }}\samples_install\samples_bin\greedy_causal_lm.exe" "TinyLlama-1.1B-Chat-v1.0" ""
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

BTW, I don't see any output from this sample. Is it run?

@ilya-lavrenov ilya-lavrenov removed this from the 2024.4 milestone Oct 15, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants