[agent] Send extended device info after config is updated #119
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@nemesisdesign Is there anything I can do to get this merged? |
I would not merge this until I can test all the implications of allowing the agent to provide updates to openwisp-controller (including changing the name of the device), which is something we want but I think there are many corner cases to handle and it's not as simple as it looks, so for the moment I want to play the safe side and not merge this because we are working on other fronts which are really important for the adoption of the project. |
|
@nemesisdesign What is the status of this? It's here since more than a year... We are using this without issues. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes openwisp/openwisp-controller#293 together with openwisp/openwisp-controller#305