Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fixes #224: Added ipv6 support to openwisp-get-address #225

Open
wants to merge 1 commit into
base: master
Choose a base branch
from
Open

Fixes #224: Added ipv6 support to openwisp-get-address #225

wants to merge 1 commit into from

Conversation

Bartosz-lab
Copy link

Checklist

  • I have read the OpenWISP Contributing Guidelines.
  • I have manually tested the changes proposed in this pull request.
  • I have written new test cases for new code and/or updated existing tests for changes to existing code.
  • I have updated the documentation.

Reference to Existing Issue

Fixes #224.

Description of Changes

  • Added support for getting the IPv6 address if the IPv4 address is not found in openwisp-get-address.
  • Added a --prefer-ipv6 flag to search for IPv6 addresses first.

nemesifier
nemesifier reviewed Oct 22, 2024
View reviewed changes
Copy link
Member

@nemesifier nemesifier left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for this. I have one doubt, what's the point of the --prefer-ipv6 flag if it's not used in the rest of the code?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@nemesifier nemesifier nemesifier left review comments

At least 1 approving review is required to merge this pull request.

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

[bug] openwisp-get-address not work with IPv6 only interface
2 participants
@Bartosz-lab @nemesifier