Skip to content

Commit

Permalink
[qa] Automatic reformatting of code and docs
Browse files Browse the repository at this point in the history
  • Loading branch information
nemesifier committed Jul 30, 2024
1 parent c745e64 commit 745a6ca
Show file tree
Hide file tree
Showing 17 changed files with 31 additions and 38 deletions.
50 changes: 27 additions & 23 deletions CHANGES.rst
Original file line number Diff line number Diff line change
Expand Up @@ -14,13 +14,16 @@ Bugfixes

- Fixed `hardcoded storage backend of the "FirmwareImage.file" field
<https://github.com/openwisp/openwisp-firmware-upgrader/issues/195>`_.
``FirmwareImage.file`` was configured to use ``PrivateFileSystemStorage``,
which made it impossible to use other private storage backends.
The `"OPENWISP_FIRMWARE_PRIVATE_STORAGE_INSTANCE"
``FirmwareImage.file`` was configured to use
``PrivateFileSystemStorage``, which made it impossible to use other
private storage backends. The
`"OPENWISP_FIRMWARE_PRIVATE_STORAGE_INSTANCE"
<https://github.com/openwisp/openwisp-firmware-upgrader#openwisp_firmware_private_storage_instance>`_
setting is added to make the ``FirmwareImage.file`` storage configurable.
- Fixed `inconsistent URL keyword argument in "serve_private_file"
URL pattern <https://github.com/openwisp/openwisp-firmware-upgrader/issues/197>`_.
setting is added to make the ``FirmwareImage.file`` storage
configurable.
- Fixed `inconsistent URL keyword argument in "serve_private_file" URL
pattern
<https://github.com/openwisp/openwisp-firmware-upgrader/issues/197>`_.
This broke the reverse proxy feature of `django-private-storage
<https://github.com/edoburu/django-private-storage>`_.

Expand Down Expand Up @@ -93,15 +96,15 @@ Changes
-------

Backward incompatible changes
^^^^^^^^^^^^^^^^^^^^^^^^^^^^^
~~~~~~~~~~~~~~~~~~~~~~~~~~~~~

- REST APIs are enabled by default. You can disable them by setting
``OPENWISP_FIRMWARE_UPGRADER_API`` to ``False``.
- Changed REST API prefix from ``/upgrader/`` to ``/firmware-upgrader/``.
This makes it consistent with REST API endpoints of other modules

Dependencies
^^^^^^^^^^^^
~~~~~~~~~~~~

- Dropped support for Python 3.6
- Dropped support for Django 2.2
Expand All @@ -110,32 +113,33 @@ Dependencies
- Upgraded openwisp-controller to 1.0.x

Other changes
^^^^^^^^^^^^^
~~~~~~~~~~~~~

- Avoid deletion of ``UpgradeOperation`` when related
``Firmware Image`` is deleted
- Increased default retries in OpenWRT upgrader from
``15`` to ``40``
- Avoid deletion of ``UpgradeOperation`` when related ``Firmware Image``
is deleted
- Increased default retries in OpenWRT upgrader from ``15`` to ``40``
- Made firmware upgrade logs translatable
- Changed the default API throttle rate from ``400/hour`` to ``1000/minute``
- Added time limits to ``openwisp_firmware_upgrader.tasks.create_device_firmware``
and ``openwisp_firmware_upgrader.tasks.create_all_device_firmwares`` celery tasks
- Changed the default API throttle rate from ``400/hour`` to
``1000/minute``
- Added time limits to
``openwisp_firmware_upgrader.tasks.create_device_firmware`` and
``openwisp_firmware_upgrader.tasks.create_all_device_firmwares`` celery
tasks

Bugfixes
--------

- Fixed firmware checksum check
- Improved error handling for upgrade operations
- Remove openwisp-config persistent checksum:
openwisp-config 0.6.0 makes the checksum persistent,
but this causes upgraded devices to not download the configuration
again after the upgrade, which is an issue if the configuration
contains any file which is not stored in ``/etc/``.
- Remove openwisp-config persistent checksum: openwisp-config 0.6.0 makes
the checksum persistent, but this causes upgraded devices to not
download the configuration again after the upgrade, which is an issue if
the configuration contains any file which is not stored in ``/etc/``.
- Fixed a bug which caused ``Server 500`` error on creating a new
``Build`` object if ``category`` field was left empty
- Fixed bugs in restoring deleted devices using ``django-reversion``
- Fixed migrations referencing non-swappable OpenWISP modules
that broke OpenWISP's extensibility
- Fixed migrations referencing non-swappable OpenWISP modules that broke
OpenWISP's extensibility

Version 0.1.1 [2021-01-08]
--------------------------
Expand Down
3 changes: 2 additions & 1 deletion CONTRIBUTING.rst
Original file line number Diff line number Diff line change
@@ -1 +1,2 @@
Please refer to the `OpenWISP contributing guidelines <http://openwisp.io/docs/developer/contributing.html>`_.
Please refer to the `OpenWISP contributing guidelines
<http://openwisp.io/docs/developer/contributing.html>`_.
1 change: 0 additions & 1 deletion openwisp_firmware_upgrader/migrations/0001_initial.py
Original file line number Diff line number Diff line change
Expand Up @@ -13,7 +13,6 @@


class Migration(migrations.Migration):

initial = True

dependencies = [
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -9,7 +9,6 @@ def create_permissions_for_default_groups_helper(apps, schema_editor):


class Migration(migrations.Migration):

dependencies = [
('firmware_upgrader', '0001_initial'),
]
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -7,7 +7,6 @@


class Migration(migrations.Migration):

dependencies = [
('firmware_upgrader', '0002_default_permissions'),
]
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -4,7 +4,6 @@


class Migration(migrations.Migration):

dependencies = [
('firmware_upgrader', '0003_private_media'),
]
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -4,7 +4,6 @@


class Migration(migrations.Migration):

dependencies = [
('firmware_upgrader', '0004_batch_upgrade_operation_idle_status'),
]
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -11,7 +11,6 @@ def create_device_firmware_for_connections_helper(apps, schema_editor):


class Migration(migrations.Migration):

dependencies = [
('firmware_upgrader', '0005_build_os_identifier'),
]
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -6,7 +6,6 @@


class Migration(migrations.Migration):

dependencies = [
('firmware_upgrader', '0006_create_device_firmware'),
]
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -9,7 +9,6 @@


class Migration(migrations.Migration):

dependencies = [
('firmware_upgrader', '0007_nullable_upgrade_operation_image'),
]
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -4,7 +4,6 @@


class Migration(migrations.Migration):

dependencies = [
('firmware_upgrader', '0008_firmware_image_baseurl'),
]
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -9,7 +9,6 @@


class Migration(migrations.Migration):

dependencies = [
("firmware_upgrader", "0009_upgrade_options"),
]
Expand Down
2 changes: 2 additions & 0 deletions pyproject.toml
Original file line number Diff line number Diff line change
@@ -0,0 +1,2 @@
[tool.docstrfmt]
extend_exclude = ["**/*.py", "README.rst"]
Original file line number Diff line number Diff line change
Expand Up @@ -17,7 +17,6 @@


class Migration(migrations.Migration):

initial = True

dependencies = [
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -11,7 +11,6 @@ def create_permissions_for_default_groups_helper(apps, schema_editor):


class Migration(migrations.Migration):

dependencies = [
('sample_firmware_upgrader', '0001_initial'),
]
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -11,7 +11,6 @@ def create_device_firmware_for_connections_helper(apps, schema_editor):


class Migration(migrations.Migration):

dependencies = [
('sample_firmware_upgrader', '0002_default_permissions'),
]
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -9,7 +9,6 @@


class Migration(migrations.Migration):

dependencies = [
("sample_firmware_upgrader", "0003_create_device_firmware"),
]
Expand Down

0 comments on commit 745a6ca

Please sign in to comment.