Skip to content

Commit

Permalink
Update interpreter checklist (#1323)
Browse files Browse the repository at this point in the history
The checklist is updated to enable additional tests in the `testdata`
directory now that we have them to use extensively.
  • Loading branch information
ghpvnist authored Mar 13, 2023
1 parent 0c7b9b1 commit 63b6f5a
Showing 1 changed file with 7 additions and 0 deletions.
7 changes: 7 additions & 0 deletions docs/reference_checklist.md
Original file line number Diff line number Diff line change
Expand Up @@ -65,6 +65,13 @@ After implementing the interpreter:
1. In [interpreter tests](https://github.com/openxla/stablehlo/tree/main/stablehlo/tests):
1. Add file called `interpret_<op_mnemonic>.mlir`.
1. Write tests following the [testing guidelines](https://github.com/openxla/stablehlo/blob/main/docs/reference.md#testing-guidelines).
1. In [testdata directory](https://github.com/openxla/stablehlo/tree/main/stablehlo/testdata):
1. Run any disabled tests which is covered by the newly added operation.
1. If the tests pass, enable them by converting `RUN-DISABLED` to `RUN`.
1. If the test fails due to reason other than precision mismatches, fix the
implementation/test.
1. For precision mismatches, tag the test with `RUN-DISABLED(#1278)` if not
already done so.
1. In [ops_stablehlo.mlir](https://github.com/openxla/stablehlo/blob/main/stablehlo/tests/ops_stablehlo.mlir):
1. Make sure that there is at least one test for each constraint in verifier
and type inference methods; constraints covered in ODS will not be
Expand Down

0 comments on commit 63b6f5a

Please sign in to comment.